Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: takes long time to retrieve feature.dataset.name #547

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

xgui3783
Copy link
Member

No description provided.

@xgui3783 xgui3783 requested a review from AhmetNSimsek January 24, 2024 13:41
@codecov-commenter
Copy link

Codecov Report

Attention: 1289 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (50f038f) 53.40%.
Report is 372 commits behind head on main.

Files Patch % Lines
siibra/features/feature.py 48.55% 125 Missing ⚠️
siibra/volumes/volume.py 44.85% 118 Missing ⚠️
siibra/core/region.py 56.75% 112 Missing ⚠️
siibra/volumes/parcellationmap.py 18.97% 111 Missing ⚠️
siibra/explorer/url.py 0.00% 107 Missing ⚠️
...bra/features/connectivity/regional_connectivity.py 33.33% 56 Missing ⚠️
siibra/retrieval/datasets.py 49.53% 54 Missing ⚠️
siibra/explorer/util.py 0.00% 51 Missing ⚠️
...a/features/tabular/receptor_density_fingerprint.py 4.54% 42 Missing ⚠️
...a/features/tabular/regional_timeseries_activity.py 39.13% 42 Missing ⚠️
... and 36 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #547       +/-   ##
===========================================
+ Coverage   36.81%   53.40%   +16.58%     
===========================================
  Files          61       69        +8     
  Lines        5421     6631     +1210     
===========================================
+ Hits         1996     3541     +1545     
+ Misses       3425     3090      -335     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek merged commit c8a354b into main Jan 25, 2024
27 checks passed
@AhmetNSimsek AhmetNSimsek deleted the fix_cacheFeatDsName branch January 25, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants