Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image query #538

Merged
merged 7 commits into from
Jan 18, 2024
Merged

Fix image query #538

merged 7 commits into from
Jan 18, 2024

Conversation

AhmetNSimsek
Copy link
Collaborator

import siibra
fts = siibra.features.get(siibra.get_template('mni152').get_boundingbox(), siibra.features.cellular.CellbodyStainedSection)
assert len(fts) == 47

But as of d390948 siibra cannot find any.

@codecov-commenter
Copy link

codecov-commenter commented Jan 18, 2024

Codecov Report

Attention: 1263 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (87c4b8b) 53.34%.
Report is 352 commits behind head on main.

Files Patch % Lines
siibra/features/feature.py 48.33% 124 Missing ⚠️
siibra/volumes/volume.py 44.33% 118 Missing ⚠️
siibra/core/region.py 57.19% 110 Missing ⚠️
siibra/volumes/parcellationmap.py 19.70% 110 Missing ⚠️
siibra/explorer/url.py 0.00% 107 Missing ⚠️
...bra/features/connectivity/regional_connectivity.py 33.33% 56 Missing ⚠️
siibra/retrieval/datasets.py 49.53% 54 Missing ⚠️
siibra/explorer/util.py 0.00% 51 Missing ⚠️
...a/features/tabular/regional_timeseries_activity.py 39.13% 42 Missing ⚠️
...a/features/tabular/receptor_density_fingerprint.py 2.38% 41 Missing ⚠️
... and 35 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #538       +/-   ##
===========================================
+ Coverage   36.81%   53.34%   +16.52%     
===========================================
  Files          61       69        +8     
  Lines        5421     6600     +1179     
===========================================
+ Hits         1996     3521     +1525     
+ Misses       3425     3079      -346     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Fixes the bug of getting unrestricted results from restricted search following a unrestricted search
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants