Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: warm cache #537

Merged
merged 4 commits into from
Jan 18, 2024
Merged

refactor: warm cache #537

merged 4 commits into from
Jan 18, 2024

Conversation

xgui3783
Copy link
Member

No description provided.

@xgui3783 xgui3783 requested a review from AhmetNSimsek January 17, 2024 09:24
Copy link
Collaborator

@AhmetNSimsek AhmetNSimsek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few notes but otherwise LGTM

@xgui3783
Copy link
Member Author

@AhmetNSimsek can you take a look again when you get a chance?

I fixed the tests, and properly added flake

@codecov-commenter
Copy link

Codecov Report

Attention: 1234 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (d073c0c) 53.70%.
Report is 346 commits behind head on main.

Files Patch % Lines
siibra/features/feature.py 47.89% 124 Missing ⚠️
siibra/volumes/volume.py 44.33% 118 Missing ⚠️
siibra/volumes/parcellationmap.py 19.70% 110 Missing ⚠️
siibra/explorer/url.py 0.00% 107 Missing ⚠️
siibra/core/region.py 62.50% 90 Missing ⚠️
...bra/features/connectivity/regional_connectivity.py 33.33% 56 Missing ⚠️
siibra/retrieval/datasets.py 49.53% 54 Missing ⚠️
siibra/explorer/util.py 0.00% 51 Missing ⚠️
...a/features/tabular/receptor_density_fingerprint.py 4.54% 42 Missing ⚠️
...a/features/tabular/regional_timeseries_activity.py 39.13% 42 Missing ⚠️
... and 34 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #537       +/-   ##
===========================================
+ Coverage   36.81%   53.70%   +16.88%     
===========================================
  Files          61       69        +8     
  Lines        5421     6582     +1161     
===========================================
+ Hits         1996     3535     +1539     
+ Misses       3425     3047      -378     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek merged commit f8c5fe5 into main Jan 18, 2024
@AhmetNSimsek AhmetNSimsek deleted the rf_cacheWArming branch January 18, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants