Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provider.boundingbox -> provider.get_boundingbox() #515

Merged
merged 2 commits into from
Nov 21, 2023

Conversation

AhmetNSimsek
Copy link
Collaborator

Solves bounding box of region's possibly resulting to be the whole space

Solves bounding box of region's possibly resulting to be the whole space
@AhmetNSimsek AhmetNSimsek force-pushed the fix_region_get_boundingbox branch from 3db1bfe to ccd4547 Compare November 20, 2023 18:44
@AhmetNSimsek AhmetNSimsek force-pushed the fix_region_get_boundingbox branch from 3dc3583 to 72a3684 Compare November 21, 2023 11:48
@codecov-commenter
Copy link

Codecov Report

Attention: 1249 lines in your changes are missing coverage. Please review.

Comparison is base (5a0e6b3) 36.81% compared to head (72a3684) 50.72%.
Report is 282 commits behind head on main.

Files Patch % Lines
siibra/volumes/volume.py 43.92% 120 Missing ⚠️
siibra/features/feature.py 48.09% 109 Missing ⚠️
siibra/explorer/url.py 0.00% 107 Missing ⚠️
siibra/volumes/parcellationmap.py 18.25% 103 Missing ⚠️
siibra/core/region.py 62.34% 90 Missing ⚠️
...bra/features/connectivity/regional_connectivity.py 25.97% 57 Missing ⚠️
siibra/retrieval/datasets.py 51.81% 53 Missing ⚠️
siibra/explorer/util.py 0.00% 51 Missing ⚠️
...a/features/tabular/regional_timeseries_activity.py 25.00% 48 Missing ⚠️
siibra/configuration/factory.py 54.34% 42 Missing ⚠️
... and 37 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #515       +/-   ##
===========================================
+ Coverage   36.81%   50.72%   +13.90%     
===========================================
  Files          61       69        +8     
  Lines        5421     6462     +1041     
===========================================
+ Hits         1996     3278     +1282     
+ Misses       3425     3184      -241     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AhmetNSimsek AhmetNSimsek force-pushed the fix_region_get_boundingbox branch from 72a3684 to 2500bd7 Compare November 21, 2023 13:29
@AhmetNSimsek AhmetNSimsek merged commit 24fc86f into main Nov 21, 2023
@AhmetNSimsek AhmetNSimsek deleted the fix_region_get_boundingbox branch November 21, 2023 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants