Initial mypy support
#356
Open
Initial mypy support
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Mar 7, 2025
| @@ -340,7 +340,7 @@ def reconstruct(self, **kwargs: typing.Any) -> Cell: | |||
| return Cell(self._cellname) | |||
|
|
|||
|
|
|||
| class TensorProductCell(AbstractCell): | |||
| class TensorProductCell(Cell): | |||
There was a problem hiding this comment.
Was this change deliberate? I guess we should talk to our firedrake friends (@dham) if this is something they want.
There was a problem hiding this comment.
Yes, fixes
ufl/cell.py:441: error: Incompatible return value type (got "TensorProductCell", expected "Cell") [return-value]
Not entirely sure if it is the right fix to it though.
jorgensd
reviewed
Mar 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces a
mypylinting check to the CI, and introduces fixes for somemypychecks. The remaining, for now ignored checks require more extensive changes and are left out here.Work towards #211