Allow access to logged timer data #3487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not used and is only available for non logging timers whcih makes it inconsistent.
|
@garth-wells import dolfinx
import time
task = "test"
with dolfinx.common.Timer(task) as timer:
time.sleep(0.1)
print(dolfinx.common.timing(task))yielding Traceback (most recent call last):
File "/root/shared/debug.py", line 8, in <module>
print(dolfinx.common.timing(task))
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/local/dolfinx-real/lib/python3.12/dist-packages/dolfinx/common.py", line 48, in timing
return _cpp.common.timing(task)
^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: No timings registered for task "test".Not sure how the tests passed with this. |
See #3488. |
jhale
requested changes
Oct 29, 2024
|
Could we add docs to the timing routine regarding flush ? Currently the Python routine is undocumented. |
jhale
approved these changes
Oct 31, 2024
jorgensd
added a commit
to jorgensd/dolfinx_mpc
that referenced
this pull request
Nov 17, 2024
jorgensd
added a commit
to jorgensd/dolfinx_mpc
that referenced
this pull request
Nov 17, 2024
* Update CI versions and behavior * Refactor timings, due to: FEniCS/dolfinx#3487 FEniCS/dolfinx#3488 * API changes from: FEniCS/dolfinx#3500 * Fix demo * Install boost * Set tag * Only check docker on release branch * Fixes for refernece value size * More timing fixes * Another round of timing changes * Remove last old timing instance
schnellerhase
added a commit
to schnellerhase/fenics-dolfinx
that referenced
this pull request
Dec 28, 2024
* Remove resume functionality This is not used and is only available for non logging timers whcih makes it inconsistent. * Move to chrono timings * Return duration instead of scalar * Remove boost timer dependency * Switch to microseconds as default * Fix with cast * Addapt logging to new std::chrono clocks * Remove missed boost timer dependencies * Partially revert boost dependency removal * Remove list_timings from python wrapper * Readd elapsed for pyhton testing * Ruff * Ruff 2 * Doc * Some simplifications * Try removing cast * Simplification * Doc improvement * Fixes for timer * Dox updates * Updates * Various fixes * Doc improvements * Remove debug * Return raw timer data * Return timer data * Merge fix * Type fixes * Doc improvements and add test * Store time delta * Test updates --------- Co-authored-by: schnellerhase <56360279+schnellerhase@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.