Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename create_adjacencylist to adjacency_list #2760

Closed
mscroggs opened this issue Sep 6, 2023 · 2 comments · Fixed by #2763
Closed

Rename create_adjacencylist to adjacency_list #2760

mscroggs opened this issue Sep 6, 2023 · 2 comments · Fixed by #2763
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mscroggs
Copy link
Member

mscroggs commented Sep 6, 2023

No description provided.

@mscroggs mscroggs added enhancement New feature or request good first issue Good for newcomers labels Sep 6, 2023
@IgorBaratta
Copy link
Member

or to adjacency_list?

@mscroggs mscroggs changed the title Rename create_adjacencylist to adjacencylist Rename create_adjacencylist to adjacency_list Sep 7, 2023
garth-wells added a commit that referenced this issue Sep 7, 2023
@garth-wells
Remove "create" prefix from some functions.
312caf6 
Fixes #2760.
@garth-wells garth-wells mentioned this issue Sep 7, 2023
Merged
@garth-wells
Copy link
Member

or to adjacency_list?

I think without underscore is better - otherwise we would need function_space rather than functionspace, sparsity_pattern, etc, throughout. For me, the underscore doesn't make anything clearer but does add more visual noise.

github-merge-queue bot pushed a commit that referenced this issue Sep 11, 2023
@garth-wells
Remove "create" prefix from some functions (#2763)
e4439cc 
* Remove "create" prefix from some functions.

Fixes #2760.

* Rename function

* Fix import

* Type name fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove "create" prefix from some functions FEniCS/dolfinx
3 participants
@garth-wells @mscroggs @IgorBaratta