Implement SIDT/LSL #4377
Merged
Implement SIDT/LSL #4377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emulate by always returning failure, this deviates from both Linux and Windows but shouldn't be depended on by anything.
Sonicadvance1
approved these changes
Feb 27, 2025
|
Looks like some unit tests are failing. Probably describing instructions too broadly or something. |
|
Don't entirely trust the decoder changes but test pasts so I think good? |
Sonicadvance1
approved these changes
Mar 5, 2025
There was a problem hiding this comment.
Okay, yea. Looked over how these tables are encoded again and I see that group 7 is a little weird which you uncovered. So yes, for group 7 decoding specifically, when modrm.mod = 11b it chooses the SecondaryModRMExtensionOpTable table, when it is anything else it'll choose the SecondaryExtensionOpTable table.
We could probably encode the tables slightly differently but that's a fairly significant refactor. This works just as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are used by recent Denuvo. LSL behaviour doesn't match Windows or Linux exactly but I don't see this mattering, and the Windows behaviour is to encode the cpu index in the segment size anyway so exposing e.g. a way for the frontend to set sizes wouldn't cut it.
Unsure what to do about tests for these since they're not deterministic across different OSs.