FEXCore/vl64: Fixes int16 encoding #4338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason when I was writing the tests I got the byte order incorrect. The type header needs to be in the first byte, not the second byte.
So when encoding we also test the decode path.
lioncash
approved these changes
Feb 8, 2025
bylaws
approved these changes
Feb 8, 2025
The main optimization here is keeping as many values as 8-bit as possible since ~97% fit within the signed 7-bit range that fits within that encoding. The remaining 3% fitting within the 16-bit encoding (14-bit signed value encoded) seems reasonable enough, which is why the 32-bit and 64-bit encoding doesn't try to be any smarter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason when I was writing the tests I got the byte order
incorrect. The type header needs to be in the first byte, not the second
byte.