Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config: Enable multiblock by default #4327

Merged
merged 1 commit into from
Feb 8, 2025
Merged

Conversation

bylaws
Copy link
Collaborator

@bylaws bylaws commented Feb 4, 2025

Dep #4325 #4326

Before these:
MB on: 3790969649ns
MB off: 3169002331ns
After:
MB on: 2594371996ns
MB off: 2386604655ns

Seems reasonable to take the 10% hit here

@Sonicadvance1
Copy link
Member

Supposedly Factorio breaks under Multiblock. I haven't tried to reproduce yet, but might not be safe to enable by default yet.

@bylaws
Copy link
Collaborator Author

bylaws commented Feb 7, 2025

Supposedly Factorio breaks under Multiblock. I haven't tried to reproduce yet, but might not be safe to enable by default yet.

Quite likely this was tested with fex before my fixes

Copy link
Member

@Sonicadvance1 Sonicadvance1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, let's get this in for a month of dogfooding.

@Sonicadvance1 Sonicadvance1 merged commit a49d30f into FEX-Emu:main Feb 8, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants