Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat: fallback to NoopProvider if we run into OOM [2/3]" #494

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

tgolen
Copy link
Collaborator

@tgolen tgolen commented Mar 5, 2024

Reverts #483

The 1/3 PR ended up causing a regression in Expensify/App#37752 and needs to be reverted. Since the 2/3 PR was based off of the 1/3 PR, this one needs to be reverted as well.

@tgolen tgolen self-assigned this Mar 5, 2024
@tgolen tgolen requested a review from a team as a code owner March 5, 2024 22:20
@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team March 5, 2024 22:20
@roryabraham roryabraham merged commit f7d0c0b into main Mar 5, 2024
4 checks passed
@tgolen tgolen deleted the revert-483-feat/split-up-in-memory-pr-part-2 branch March 5, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants