fix: crash on storage synchronization attempt

lib/storage/InstanceSync/index.web.ts

@@ -1,10 +1,11 @@
-/* eslint-disable no-invalid-this */
 /**
  * The InstancesSync object provides data-changed events like the ones that exist
  * when using LocalStorage APIs in the browser. These events are great because multiple tabs can listen for when
  * data changes and then stay up-to-date with everything happening in Onyx.
  */
-import type {KeyList, Key, OnStorageKeyChanged, Value} from '../providers/types';
+import NoopProvider from '../providers/NoopProvider';
+import type {KeyList, Key, OnStorageKeyChanged} from '../providers/types';
+import StorageProvider from '../providers/types';
 
 const SYNC_ONYX = 'SYNC_ONYX';
 
@@ -23,11 +24,15 @@ function raiseStorageSyncManyKeysEvent(onyxKeys: KeyList) {
     });
 }
 
+let storage = NoopProvider;
+
 const InstanceSync = {
     /**
      * @param {Function} onStorageKeyChanged Storage synchronization mechanism keeping all opened tabs in sync
      */
-    init: (onStorageKeyChanged: OnStorageKeyChanged) => {
+    init: (onStorageKeyChanged: OnStorageKeyChanged, store: StorageProvider) => {
+        storage = store;
+
         // This listener will only be triggered by events coming from other tabs
         global.addEventListener('storage', (event) => {
             // Ignore events that don't originate from the SYNC_ONYX logic
@@ -36,8 +41,8 @@ const InstanceSync = {
             }
 
             const onyxKey = event.newValue;
-            // @ts-expect-error `this` will be substituted later in actual function call
-            this.getItem(onyxKey).then((value: Value) => onStorageKeyChanged(onyxKey, value));
+
+            storage.getItem(onyxKey).then((value) => onStorageKeyChanged(onyxKey, value));
         });
     },
     setItem: raiseStorageSyncEvent,
@@ -48,8 +53,8 @@ const InstanceSync = {
         let allKeys: KeyList;
 
         // The keys must be retrieved before storage is cleared or else the list of keys would be empty
-        // @ts-expect-error `this` will be substituted later in actual function call
-        return this.getAllKeys()
+        return storage
+            .getAllKeys()
             .then((keys: KeyList) => {
                 allKeys = keys;
             })

lib/storage/index.ts

@@ -176,7 +176,7 @@ const Storage: Storage = {
         if (InstanceSync === null) return;
 
         shouldKeepInstancesSync = true;
-        InstanceSync.init(onStorageKeyChanged);
+        InstanceSync.init(onStorageKeyChanged, this);
     },
 };