Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Create callable worklow for createNewVersion #9812

Merged
merged 20 commits into from
Jul 12, 2022

Conversation

roryabraham
Copy link
Contributor

Details

This change is part of a larger undertaking to clean up our GitHub Actions to make them faster, simpler, and more approachable.

Fixed Issues

$ (partial) https://github.com/Expensify/Expensify/issues/195693

Tests

  1. Merge PR A with the checklist unlocked.
  2. A staging deploy should occur and when it completes PR A should get a deploy comment and should be added to the checklist.
  3. Merge PR B with the checklist locked.
  4. PR B should get a comment saying it's not being immediately deployed.
  5. Merge PR C with the checklist locked and with a CP Staging label.
  6. PR C should be CP'd to staging. It should be added to the checklist and when the deploy completes it should get a deploy comment.
  7. Close the checklist.
  8. A production deploy should occur, and PRs A and C should receive a deploy comment.
  9. PR B should be deployed to staging and receive a deploy comment.

@roryabraham roryabraham requested a review from a team as a code owner July 9, 2022 05:49
@roryabraham roryabraham self-assigned this Jul 9, 2022
@melvin-bot melvin-bot bot requested review from Gonals and removed request for a team July 9, 2022 05:50
@roryabraham roryabraham requested a review from AndrewGable July 9, 2022 05:50
@roryabraham
Copy link
Contributor Author

We also might be able to simplify this callable workflow by using secrets: inherit:

If the secrets are inherited using secrets: inherit, you can reference them even if they are not defined in the on key.

This sounds convenient, we just have to decide if it's safe practice. I actually think it will be safe for any callable workflow that we own and which comes from the same repo

@roryabraham
Copy link
Contributor Author

Created an issue for the last actionlint failure: rhysd/actionlint#174

AndrewGable
AndrewGable previously approved these changes Jul 12, 2022
Copy link
Contributor

@AndrewGable AndrewGable left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

# Conflicts:
#	.github/scripts/validateActionsAndWorkflows.sh
@roryabraham roryabraham merged commit 7c4b815 into main Jul 12, 2022
@roryabraham roryabraham deleted the Rory-CreateNewVersionCallableWorkflow branch July 12, 2022 21:53
@roryabraham
Copy link
Contributor Author

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @chiragsalian in version: 1.1.84-13 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants