Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Setup modular sass config and add color file to help site #9760

Merged
merged 3 commits into from
Jul 7, 2022

Conversation

roryabraham
Copy link
Contributor

Details

  • Sets up modular sass partials
  • Creates a color module so all colors reference variables
  • Removes the styles for the code tag because AFAICT we have no code tags currently.

Fixed Issues

$ (partial) https://github.com/Expensify/Expensify/issues/216729

Tests

  1. (you need ruby and bundler installed to do this)

  2. Run:

    cd help
    bundle install
    bundle exec jekyll serve
  3. Make sure the site's styles load and that all the colors look correct.

  4. To convince yourself that it's working, go into the colors file and change $color-blue to #f00 and refresh the page – all the links should turn red.

@roryabraham roryabraham requested a review from a team as a code owner July 7, 2022 17:38
@roryabraham roryabraham self-assigned this Jul 7, 2022
@melvin-bot melvin-bot bot requested review from youssef-lr and removed request for a team July 7, 2022 17:38
@roryabraham roryabraham requested a review from marcochavezf July 7, 2022 17:41
@roryabraham
Copy link
Contributor Author

This is a duplicate of #9687. Resolving conflicts was too crazy so I created a new PR

Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @roryabraham! I'm going to merge it since I require these changes to fix the remaining styles (article TOC, hub pages, etc.)

@youssef-lr feel free to review it, we can address changes in a follow-up PR if needed

@marcochavezf marcochavezf merged commit bc279d9 into main Jul 7, 2022
@marcochavezf marcochavezf deleted the Rory-improveHelpDotStyles branch July 7, 2022 18:09
@OSBotify
Copy link
Contributor

OSBotify commented Jul 7, 2022

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Jul 8, 2022

🚀 Deployed to staging by @marcochavezf in version: 1.1.81-0 🚀

platform result
🤖 android 🤖 failure ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants