Refactor the API for saving the report notification preferences #9501
Conversation
|
Looks like you modified Instead, all new API commands should use API.js, and follow our guidelines for writing new API commands. Unsure if your change is okay? Drop a note in #expensify-open-source! |
|
Updated with failure data. Still waiting to make the CONST change |
|
Update with CONST update |
tgolen
changed the title
|
I made an update to web-e so that the pusher response would be sent out to all clients. It didn't result in any updates to this branch though. |
tgolen
changed the title
|
Hold is removed and this is ready to be merged now. |
| function updateNotificationPreference(reportID, notificationPreference) { | ||
| Onyx.merge(`${ONYXKEYS.COLLECTION.REPORT}${reportID}`, {notificationPreference}); | ||
| DeprecatedAPI.Report_UpdateNotificationPreference({reportID, notificationPreference}); | ||
| function updateNotificationPreference(reportID, previousValue, newValue) { |
There was a problem hiding this comment.
we are missing JSDocs for this.
…o tgolen-report-notifications
|
Added JS docs 👍 |
Co-authored-by: Rory Abraham <47436092+roryabraham@users.noreply.github.com>
|
updated @roryabraham |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by @marcaaron in version: 1.1.81-0 🚀
|
|
Hi guys, QA reported this issue related to the notification preferences #9805, it can't be reproduced consistently but happens when I change the notification preferences and refresh the browser quickly. Thoughts about this issue? @tgolen @marcaaron @roryabraham |
|
Explained in this comment -> #9805 (comment) |
|
🚀 Deployed to production by @roryabraham in version: 1.1.82-5 🚀
|
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/211600
Tests
QA Steps
Same as above
Screenshots
Web
2022-06-20_15-34-43.mp4
Adding in a video to show pusher working to update multiple connected clients
2022-06-22_10-31-22.mp4
Mobile Web
2022-06-20_15-35-09.mp4
Desktop
2022-06-20_15-37-10.mp4
iOS
2022-06-20_15-45-14.mp4
Android
2022-06-20_15-40-35.mp4