🍒 Cherry pick PR #56698 to staging 🍒 #57934

os-botify · 2025-03-06T14:49:20Z

🍒 Cherry pick #56382 to staging 🍒

This PR had conflicts when we tried to cherry-pick it to staging. You'll need to manually perform the cherry-pick, using the following steps:

git fetch
git checkout roryabraham-cherry-pick-staging-56382-1
git cherry-pick -S -x --mainline 1 6486b1d1961d4c6de85154905d57af5118b33ff9

Then manually resolve conflicts, and commit the change with git cherry-pick --continue. Lastly, please run:

git commit --amend -m "$(git log -1 --pretty=%B)" -m "(CP triggered by roryabraham)"

That will help us keep track of who triggered this CP. Once all that's done, push your changes with git push origin roryabraham-cherry-pick-staging-6486b1d1961d4c6de85154905d57af5118b33ff9-1, and then open this PR for review.

Note that you must test this PR, and both the author and reviewer checklist should be completed, just as if you were merging the PR to main.

Pro-tip: If this PR appears to have conflicts against the staging base, it means that the version on staging has been updated. The easiest thing to do if you see this is to close the PR and re-run the CP.

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

(cherry picked from commit 698f602)

melvin-bot · 2025-03-06T14:49:50Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

…-props-as-object-v2 [HybridApp] Receive structured initialProperties (not as url) and improve url handling (cherry picked from commit e040f59) (CP triggered by puneetlath)

github-actions · 2025-03-06T15:42:23Z

🚧 @Julesssss has triggered a test hybrid app build. You can view the workflow run here.

src/libs/actions/Session/index.ts

hungvu193 · 2025-03-06T15:54:50Z

I'm running the hybrid app, it's taking more time than I expected 👀

war-in

Looks good 👍

github-actions · 2025-03-06T16:24:00Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/57934/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/57934/index.html

Android Hybrid 🤖🔄	iOS Hybrid 🍎🔄
N/A	N/A
N/A	N/A
Desktop 💻	Web 🕸️
N/A	N/A
N/A	N/A

👀 View the workflow run that generated this build 👀

Julesssss

Auth and app switching is working perfectly for me, new and existing accounts on Android

github-actions · 2025-03-06T17:35:27Z

🚧 @puneetlath has triggered a test app build. You can view the workflow run here.

hungvu193 · 2025-03-06T17:51:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-03-07.at.01.09.51.mov

Android: mWeb Chrome

Screen.Recording.2025-03-07.at.00.54.45.mov

iOS: Native

Screen.Recording.2025-03-07.at.00.48.04.mov

iOS: mWeb Safari

Screen.Recording.2025-03-07.at.00.52.02.mov

MacOS: Chrome / Safari

Screen.Recording.2025-03-07.at.00.51.02.mov

MacOS: Desktop

Screen.Recording.2025-03-07.at.00.51.24.mov

hungvu193

Test well!

melvin-bot · 2025-03-06T17:53:11Z

🎯 @hungvu193, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #57946.

Update version to 9.1.9-7

a8e0cde

(cherry picked from commit 698f602)

os-botify bot requested a review from a team as a code owner March 6, 2025 14:49

os-botify bot added Engineering Hourly KSv2 labels Mar 6, 2025

os-botify bot assigned puneetlath and war-in Mar 6, 2025

melvin-bot bot requested review from arosiclair and removed request for a team March 6, 2025 14:49

Merge pull request #56698 from software-mansion-labs/war-in/send-init…

688703d

…-props-as-object-v2 [HybridApp] Receive structured initialProperties (not as url) and improve url handling (cherry picked from commit e040f59) (CP triggered by puneetlath)

Julesssss added the Ready To Build label Mar 6, 2025

puneetlath requested a review from hungvu193 March 6, 2025 15:46

war-in reviewed Mar 6, 2025

View reviewed changes

src/libs/actions/Session/index.ts Outdated Show resolved Hide resolved

src/libs/actions/Session/index.ts Outdated Show resolved Hide resolved

Fix merge changes

a8a08a5

war-in approved these changes Mar 6, 2025

View reviewed changes

Julesssss approved these changes Mar 6, 2025

View reviewed changes

hungvu193 approved these changes Mar 6, 2025

View reviewed changes

melvin-bot bot mentioned this pull request Mar 6, 2025

Payment issue for E/App PR#57934 #57946

Closed

puneetlath merged commit 2ce24f4 into staging Mar 6, 2025
6 of 9 checks passed

puneetlath deleted the puneetlath-cherry-pick-staging-56698-1 branch March 6, 2025 17:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🍒 Cherry pick PR #56698 to staging 🍒 #57934

🍒 Cherry pick PR #56698 to staging 🍒 #57934

os-botify bot commented Mar 6, 2025 •

edited by puneetlath

Loading

melvin-bot bot commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

hungvu193 commented Mar 6, 2025

war-in left a comment

github-actions bot commented Mar 6, 2025

Julesssss left a comment

github-actions bot commented Mar 6, 2025

hungvu193 commented Mar 6, 2025 •

edited

Loading

hungvu193 left a comment

melvin-bot bot commented Mar 6, 2025

🍒 Cherry pick PR #56698 to staging 🍒 #57934

🍒 Cherry pick PR #56698 to staging 🍒 #57934

Conversation

os-botify bot commented Mar 6, 2025 • edited by puneetlath Loading

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

hungvu193 commented Mar 6, 2025

war-in left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 6, 2025

Julesssss left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 6, 2025

hungvu193 commented Mar 6, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

hungvu193 left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 6, 2025

os-botify bot commented Mar 6, 2025 •

edited by puneetlath

Loading

hungvu193 commented Mar 6, 2025 •

edited

Loading