Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] Revert "fix: Message Previews Always Include Sender Name" #57894

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

mountiny
Copy link
Contributor

@mountiny mountiny commented Mar 5, 2025

Reverts #57371

Straight revert for the unit tests failing in main

@mountiny mountiny self-assigned this Mar 5, 2025
@mountiny mountiny requested a review from a team as a code owner March 5, 2025 23:51
@mountiny mountiny changed the title Revert "fix: Message Previews Always Include Sender Name" [NoQA] Revert "fix: Message Previews Always Include Sender Name" Mar 5, 2025
@melvin-bot melvin-bot bot requested review from dangrous and removed request for a team March 5, 2025 23:52
Copy link

melvin-bot bot commented Mar 5, 2025

@dangrous Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@mountiny mountiny merged commit d04c6c1 into main Mar 5, 2025
14 of 17 checks passed
@mountiny mountiny deleted the revert-57371-fix/57038 branch March 5, 2025 23:56
@melvin-bot melvin-bot bot added the Emergency label Mar 5, 2025
Copy link

melvin-bot bot commented Mar 5, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny mountiny removed the Emergency label Mar 5, 2025
@mountiny
Copy link
Contributor Author

mountiny commented Mar 5, 2025

Straight revert

@OSBotify
Copy link
Contributor

OSBotify commented Mar 6, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Copy link
Contributor

github-actions bot commented Mar 6, 2025

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.10-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants