Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Revert pull request 56316 #56757

Merged
merged 39 commits into from
Feb 13, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
93260a6
tests branch
huult Dec 28, 2024
5d16ded
Merge remote-tracking branch 'upstream/main'
huult Dec 29, 2024
ef03e3d
Merge remote-tracking branch 'upstream/main'
huult Dec 30, 2024
6c803a5
Merge remote-tracking branch 'upstream/main'
huult Dec 30, 2024
a12d114
Merge remote-tracking branch 'upstream/main'
huult Jan 1, 2025
3e34abc
Merge remote-tracking branch 'upstream/main'
huult Jan 2, 2025
01d6b19
Merge remote-tracking branch 'upstream/main'
huult Jan 3, 2025
fca1e18
Merge remote-tracking branch 'upstream/main'
huult Jan 6, 2025
13f1d6a
Merge remote-tracking branch 'upstream/main'
huult Jan 7, 2025
9cf867a
Merge remote-tracking branch 'upstream/main'
huult Jan 7, 2025
e584261
Merge remote-tracking branch 'upstream/main'
huult Jan 8, 2025
209b15f
Merge remote-tracking branch 'upstream/main'
huult Jan 8, 2025
43c71b7
Merge remote-tracking branch 'upstream/main'
huult Jan 8, 2025
7142017
Merge remote-tracking branch 'upstream/main'
huult Jan 8, 2025
adb6426
Merge remote-tracking branch 'upstream/main'
huult Jan 8, 2025
0c58082
Merge remote-tracking branch 'upstream/main'
huult Jan 9, 2025
620d8ad
Merge remote-tracking branch 'upstream/main'
huult Jan 9, 2025
27674d2
Merge remote-tracking branch 'upstream/main'
huult Jan 13, 2025
1980ed5
:erge remote-tracking branch 'upstream/main'
huult Jan 14, 2025
4d75a0a
Merge remote-tracking branch 'upstream/main'
huult Jan 14, 2025
1b6864c
Merge remote-tracking branch 'upstream/main'
huult Jan 15, 2025
921c44e
Merge remote-tracking branch 'upstream/main'
huult Jan 15, 2025
691365c
Merge remote-tracking branch 'upstream/main'
huult Jan 16, 2025
8dd640d
Merge remote-tracking branch 'upstream/main'
huult Jan 16, 2025
695941c
Merge remote-tracking branch 'upstream/main'
huult Jan 20, 2025
f9bb038
Merge remote-tracking branch 'upstream/main'
huult Jan 22, 2025
efc527c
Merge remote-tracking branch 'upstream/main'
huult Jan 23, 2025
f46e797
Merge remote-tracking branch 'upstream/main'
huult Jan 26, 2025
0ddd6b4
Merge remote-tracking branch 'upstream/main'
huult Feb 4, 2025
2211aff
Merge remote-tracking branch 'upstream/main'
huult Feb 5, 2025
1eae07d
Merge remote-tracking branch 'upstream/main'
huult Feb 5, 2025
51f70c9
Merge remote-tracking branch 'upstream/main'
huult Feb 7, 2025
44572e5
Merge remote-tracking branch 'upstream/main'
huult Feb 10, 2025
b40fee9
Merge remote-tracking branch 'upstream/main'
huult Feb 11, 2025
2c71551
Merge remote-tracking branch 'upstream/main'
huult Feb 11, 2025
24226f8
Merge remote-tracking branch 'upstream/main'
huult Feb 12, 2025
d4fe2b5
Merge remote-tracking branch 'upstream/main'
huult Feb 12, 2025
39eb9c1
Revert PR #56316
huult Feb 12, 2025
e754b44
Revert PR #56316
huult Feb 12, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/languages/en.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2720,7 +2720,6 @@ const translations = {
submitExpense: 'Submit your expenses below:',
defaultCategory: 'Default category',
viewTransactions: 'View transactions',
leaveConfirmation: "Are you sure you want to leave this workspace? Once you leave, you'll lose access to all data and settings associated with this workspace.",
},
perDiem: {
subtitle: 'Set per diem rates to control daily employee spend. ',
Expand Down
2 changes: 0 additions & 2 deletions src/languages/es.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2745,8 +2745,6 @@ const translations = {
submitExpense: 'Envía tus gastos a continuación:',
defaultCategory: 'Categoría predeterminada',
viewTransactions: 'Ver transacciones',
leaveConfirmation:
'¿Estás seguro de que quieres salir de este espacio de trabajo? Una vez que salgas, perderás el acceso a todos los datos y configuraciones asociadas con este espacio de trabajo.',
},
perDiem: {
subtitle: 'Establece las tasas per diem para controlar los gastos diarios de los empleados. ',
Expand Down
55 changes: 13 additions & 42 deletions src/pages/workspace/WorkspaceProfilePage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ import useResponsiveLayout from '@hooks/useResponsiveLayout';
import useThemeIllustrations from '@hooks/useThemeIllustrations';
import useThemeStyles from '@hooks/useThemeStyles';
import {clearInviteDraft} from '@libs/actions/Policy/Member';
import {clearAvatarErrors, clearPolicyErrorField, deleteWorkspace, deleteWorkspaceAvatar, leaveWorkspace, openPolicyProfilePage, updateWorkspaceAvatar} from '@libs/actions/Policy/Policy';
import {clearAvatarErrors, clearPolicyErrorField, deleteWorkspace, deleteWorkspaceAvatar, openPolicyProfilePage, updateWorkspaceAvatar} from '@libs/actions/Policy/Policy';
import {getLatestErrorField} from '@libs/ErrorUtils';
import resetPolicyIDInNavigationState from '@libs/Navigation/helpers/resetPolicyIDInNavigationState';
import Navigation from '@libs/Navigation/Navigation';
Expand Down Expand Up @@ -49,7 +49,6 @@ function WorkspaceProfilePage({policyDraft, policy: policyProp, route}: Workspac
const illustrations = useThemeIllustrations();
const {canUseSpotnanaTravel} = usePermissions();
const {activeWorkspaceID, setActiveWorkspaceID} = useActiveWorkspace();
const [isLeaveModalOpen, setIsLeaveModalOpen] = useState(false);

const [currencyList = {}] = useOnyx(ONYXKEYS.CURRENCY_LIST);
const [currentUserAccountID = -1] = useOnyx(ONYXKEYS.SESSION, {selector: (session) => session?.accountID});
Expand Down Expand Up @@ -157,28 +156,20 @@ function WorkspaceProfilePage({policyDraft, policy: policyProp, route}: Workspac

const [isDeleteModalOpen, setIsDeleteModalOpen] = useState(false);

const handleWorkspaceAction = useCallback(
(action: 'delete' | 'leave') => {
if (!policy?.id || !policyName) {
return;
}

if (action === 'delete') {
deleteWorkspace(policy.id, policyName);
setIsDeleteModalOpen(false);
} else {
leaveWorkspace(policy.id);
}
const confirmDeleteAndHideModal = useCallback(() => {
if (!policy?.id || !policyName) {
return;
}

if (activeWorkspaceID !== policy?.id) {
return;
}
deleteWorkspace(policy.id, policyName);
setIsDeleteModalOpen(false);

// If the workspace being deleted is the active workspace, switch to the "All Workspaces" view
if (activeWorkspaceID === policy.id) {
setActiveWorkspaceID(undefined);
resetPolicyIDInNavigationState();
},
[policy?.id, policyName, activeWorkspaceID, setActiveWorkspaceID],
);
}
}, [policy?.id, policyName, activeWorkspaceID, setActiveWorkspaceID]);

return (
<WorkspacePageWithSections
Expand Down Expand Up @@ -226,7 +217,7 @@ function WorkspaceProfilePage({policyDraft, policy: policyProp, route}: Workspac
styles.sectionMenuItemTopDescription,
]}
editIconStyle={styles.smallEditIconWorkspace}
isUsingDefaultAvatar={!policy?.avatarURL}
isUsingDefaultAvatar={!policy?.avatarURL ?? false}
onImageSelected={(file) => {
if (!policy?.id) {
return;
Expand Down Expand Up @@ -370,37 +361,17 @@ function WorkspaceProfilePage({policyDraft, policy: policyProp, route}: Workspac
)}
</View>
)}
{!(isPolicyAdmin || isOwner) && (
<View style={[styles.flexRow, styles.mt6, styles.mnw120]}>
<Button
accessibilityLabel={translate('common.leave')}
text={translate('common.leave')}
onPress={() => setIsLeaveModalOpen(true)}
icon={Expensicons.Exit}
/>
</View>
)}
</Section>
<ConfirmModal
title={translate('workspace.common.delete')}
isVisible={isDeleteModalOpen}
onConfirm={() => handleWorkspaceAction('delete')}
onConfirm={confirmDeleteAndHideModal}
onCancel={() => setIsDeleteModalOpen(false)}
prompt={hasCardFeedOrExpensifyCard ? translate('workspace.common.deleteWithCardsConfirmation') : translate('workspace.common.deleteConfirmation')}
confirmText={translate('common.delete')}
cancelText={translate('common.cancel')}
danger
/>
<ConfirmModal
title={translate('common.leave')}
isVisible={isLeaveModalOpen}
onConfirm={() => handleWorkspaceAction('leave')}
onCancel={() => setIsLeaveModalOpen(false)}
prompt={translate('workspace.common.leaveConfirmation')}
confirmText={translate('common.leave')}
cancelText={translate('common.cancel')}
danger
/>
</View>
)}
</WorkspacePageWithSections>
Expand Down