Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NO QA] Revert "Remove hybrid app check from getEnvironment" #56744

Merged
merged 1 commit into from
Feb 12, 2025
Merged

[NO QA] Revert "Remove hybrid app check from getEnvironment" #56744

merged 1 commit into from
Feb 12, 2025

Conversation

mountiny
Copy link
Contributor

Reverts #56401

Might fix #56719

@github-actions GitHub Actions
Copy link
Contributor

🚧 @mountiny has triggered a test hybrid app build. You can view the workflow run here.

@mountiny mountiny mentioned this pull request Feb 12, 2025
Closed
8 tasks
@github-actions GitHub Actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/56744/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/56744/index.html
Android iOS
Desktop 💻 Web 🕸️
N/A N/A
N/A N/A

👀 View the workflow run that generated this build 👀

@m-natarajan m-natarajan mentioned this pull request Feb 12, 2025
Closed
33 tasks
Julesssss
Julesssss approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Julesssss Julesssss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are stuck with this blocker. I think it's worthwhile merging and CPing this change in an attempt to resolve.

@Julesssss Julesssss marked this pull request as ready for review February 12, 2025 18:42
@Julesssss Julesssss requested a review from a team as a code owner February 12, 2025 18:42
@melvin-bot melvin-bot bot requested review from carlosmiceli and removed request for a team February 12, 2025 18:42
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 12, 2025

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@carlosmiceli
Copy link
Contributor

Approved because it seemed urgent?

@Julesssss
Copy link
Contributor

We believe this revert resolves a few other iOS issues.

@Julesssss Julesssss added the CP Staging marks PRs that have been CP'd to staging label Feb 12, 2025
@Julesssss
Copy link
Contributor

Ignoring checklists for revert

@Julesssss Julesssss changed the title Revert "Remove hybrid app check from getEnvironment" [NO QA] Revert "Remove hybrid app check from getEnvironment" Feb 12, 2025
@Julesssss Julesssss merged commit 86f94ba into main Feb 12, 2025
14 of 17 checks passed
@Julesssss Julesssss deleted the revert-56401-jnowakow/remove-hybrid-app-check-for-enviroment branch February 12, 2025 19:22
@melvin-bot melvin-bot bot added the Emergency label Feb 12, 2025
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Feb 12, 2025

@Julesssss looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify pushed a commit that referenced this pull request Feb 12, 2025
@Julesssss @OSBotify
Merge pull request #56744 from Expensify/revert-56401-jnowakow/remove…
7fc4962 
…-hybrid-app-check-for-enviroment

Revert "Remove hybrid app check from getEnvironment"

(cherry picked from commit 86f94ba)

(CP triggered by Julesssss)
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions GitHub Actions
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/Julesssss in version: 9.0.97-1 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 success ✅
🍎🔄 iOS HybridApp 🍎🔄 success ✅

@github-actions GitHub Actions
Copy link
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.0.97-1 🚀

platform result
🤖 android 🤖 true ❌
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅
🤖🔄 android HybridApp 🤖🔄 failure ❌
🍎🔄 iOS HybridApp 🍎🔄 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosmiceli carlosmiceli carlosmiceli approved these changes

@Julesssss Julesssss Julesssss approved these changes

Assignees
No one assigned
Labels
CP Staging marks PRs that have been CP'd to staging Ready To Build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Android hybrid - After completing the Plaid flow, standalone ND opens on Google Play store
4 participants
@mountiny @carlosmiceli @Julesssss @OSBotify