Removed limit in number of characters that can be typed in a form #56588

shubham1206agra · 2025-02-09T12:37:35Z

Explanation of Change

Fixed Issues

$ #56003

Tests

Precondition: workspace with Company cards enabled. Some card assigned to user.

Go to WS > Company cards
Click on Settings
Click on 'Card feed name' field
Enter more than 50 characters
Verify that error appears on submit.

Offline tests

Same as Tests

QA Steps

Same as Tests

Additional Note: Please test similar issues too.

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-02-09T12:37:51Z

@paultsimura Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

paultsimura

Overall looks good - just a couple of clarifications.

contributingGuides/FORMS.md

src/components/AddressForm.tsx

src/components/RoomNameInput/index.native.tsx

src/components/RoomNameInput/index.tsx

src/components/TextPicker/TextSelectorModal.tsx

src/pages/PrivateNotes/PrivateNotesEditPage.tsx

src/pages/workspace/perDiem/EditPerDiemDestinationPage.tsx

src/pages/workspace/perDiem/EditPerDiemSubratePage.tsx

src/pages/workspace/reportFields/ReportFieldsInitialValuePage.tsx

src/pages/workspace/categories/EditCategoryPage.tsx

shubham1206agra · 2025-03-03T17:11:42Z

@paultsimura Ready for another round of review.

paultsimura · 2025-03-04T09:31:19Z

Bug:
Try creating a room with a name of a valid format, but too long.

You'll get this error:

The format is correct, so we should show the character limit error instead.

shubham1206agra · 2025-03-04T09:43:36Z

Bug: Try creating a room with a name of a valid format, but too long.

You'll get this error:

The format is correct, so we should show the character limit error instead.

@paultsimura Fixed

paultsimura · 2025-03-04T09:51:01Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

paultsimura · 2025-03-04T09:57:13Z

Inconsistency: characterLimit vs characterLimitExceedCounter.

When creating a group chat with a long name, we show this error instead of the now-standard (with actual length):

paultsimura

LGTM ✔️

paultsimura · 2025-03-04T11:10:55Z

@mobilify I'm curious if you think any of these is a blocker:

Removed limit in number of characters that can be typed in a form #56588 (comment)
Removed limit in number of characters that can be typed in a form #56588 (comment)

mountiny · 2025-03-05T23:42:18Z

@shubham1206agra I agree with @paultsimura on both of the points. Can you please update the Group chat flow to use the same form of validation and to add section to the doc?

shubham1206agra · 2025-03-06T04:45:10Z

@mountiny Both points are addressed now.

mountiny

@shubham1206agra appreciate all the useOnyx and lint migrations ❤️ please can you be on a look out for any regressions as this is a lot of files changed and its easy to miss something. Thank you!

mountiny · 2025-03-06T20:04:15Z

src/components/TextPicker/TextSelectorModal.tsx

-                    {!!rest.inputID && (
-                        <InputWrapper
-                            ref={inputCallbackRef}
-                            InputComponent={TextInput}
-                            maxLength={CONST.CATEGORY_NAME_LIMIT}
-                            value={currentValue}
-                            onValueChange={(changedValue) => setValue(changedValue.toString())}
-                            // eslint-disable-next-line react/jsx-props-no-spreading
-                            {...rest}
-                            inputID={rest.inputID}
-                        />
-                    )}
+                    <InputWrapper
+                        ref={inputCallbackRef}
+                        InputComponent={TextInput}
+                        value={currentValue}
+                        onValueChange={(changedValue) => setValue(changedValue.toString())}
+                        // eslint-disable-next-line react/jsx-props-no-spreading
+                        {...rest}
+                        inputID={rest.inputID}
+                    />


Lets keep an eye out on this one

OSBotify · 2025-03-06T20:48:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-03-06T23:14:26Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.1.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-10T21:09:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

Removed limit in number of characters that can be typed in a form

696c26a

shubham1206agra marked this pull request as ready for review February 9, 2025 12:37

shubham1206agra requested a review from a team as a code owner February 9, 2025 12:37

melvin-bot bot requested review from paultsimura and removed request for a team February 9, 2025 12:37

shubham1206agra marked this pull request as draft February 9, 2025 12:37

shubham1206agra and others added 3 commits February 14, 2025 22:25

Merge branch 'main' into remove-maxLength-form

c2db35a

Fixed lint

b590910

Merge branch 'Expensify:main' into remove-maxLength-form

551adc6

shubham1206agra marked this pull request as ready for review February 20, 2025 17:12

Merge main

05e20a9

paultsimura reviewed Mar 2, 2025

View reviewed changes

Code changes acc to suggestions

a3220eb

Merge branch 'Expensify:main' into remove-maxLength-form

3e312fa

Fix validation in room name

c8e804a

paultsimura approved these changes Mar 4, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny March 4, 2025 11:09

mountiny assigned shubham1206agra Mar 5, 2025

shubham1206agra and others added 3 commits March 6, 2025 09:51

Fix validation in workspace room name

b78cbd3

Merge branch 'Expensify:main' into remove-maxLength-form

dcd1503

Add validation doc

e0b59db

mountiny approved these changes Mar 6, 2025

View reviewed changes

mountiny merged commit f49f6c4 into Expensify:main Mar 6, 2025
18 checks passed

github-actions bot mentioned this pull request Mar 6, 2025

Investigate workflow job failing on main: test / test (job 3) #57955

Closed

github-actions bot mentioned this pull request Mar 6, 2025

Deploy Checklist: New Expensify 2025-03-06 #57963

Closed

93 tasks

melvin-bot bot mentioned this pull request Mar 10, 2025

[Due for payment 2025-03-17] [$250] Company cards - No field level error for card feed name #56003

Open

8 tasks

layacat mentioned this pull request Mar 11, 2025

Report fields - App crashes when field type “Text” is selected #58135

Open

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Removed limit in number of characters that can be typed in a form #56588

Removed limit in number of characters that can be typed in a form #56588

shubham1206agra commented Feb 9, 2025 •

edited

Loading

melvin-bot bot commented Feb 9, 2025

paultsimura left a comment

shubham1206agra commented Mar 3, 2025

paultsimura commented Mar 4, 2025

shubham1206agra commented Mar 4, 2025

paultsimura commented Mar 4, 2025 •

edited

Loading

paultsimura commented Mar 4, 2025 •

edited

Loading

paultsimura left a comment

paultsimura commented Mar 4, 2025

mountiny commented Mar 5, 2025

shubham1206agra commented Mar 6, 2025

mountiny left a comment

mountiny Mar 6, 2025

OSBotify commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

github-actions bot commented Mar 10, 2025

Removed limit in number of characters that can be typed in a form #56588

Removed limit in number of characters that can be typed in a form #56588

Conversation

shubham1206agra commented Feb 9, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Feb 9, 2025

paultsimura left a comment

Choose a reason for hiding this comment

shubham1206agra commented Mar 3, 2025

paultsimura commented Mar 4, 2025

shubham1206agra commented Mar 4, 2025

paultsimura commented Mar 4, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

paultsimura commented Mar 4, 2025 • edited Loading

paultsimura left a comment

Choose a reason for hiding this comment

paultsimura commented Mar 4, 2025

mountiny commented Mar 5, 2025

shubham1206agra commented Mar 6, 2025

mountiny left a comment

Choose a reason for hiding this comment

mountiny Mar 6, 2025

Choose a reason for hiding this comment

OSBotify commented Mar 6, 2025

github-actions bot commented Mar 6, 2025

github-actions bot commented Mar 10, 2025

shubham1206agra commented Feb 9, 2025 •

edited

Loading

paultsimura commented Mar 4, 2025 •

edited

Loading

paultsimura commented Mar 4, 2025 •

edited

Loading