Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooltip appears below the composer when going back from another page #56513

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Fix tooltip appears below the composer when going back from another page #56513

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d643df
fix tooltip appears below the composer when going back from another page
bernhardoj Feb 7, 2025
56002f4
fix test
bernhardoj Feb 7, 2025
7ca86a1
lint
bernhardoj Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 17 additions & 4 deletions src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
import {useIsFocused} from '@react-navigation/native';
import {useFocusEffect} from '@react-navigation/native';
import lodashDebounce from 'lodash/debounce';
import noop from 'lodash/noop';
import React, {memo, useCallback, useEffect, useMemo, useRef, useState} from 'react';
import type {MeasureInWindowOnSuccessCallback, NativeSyntheticEvent, TextInputFocusEventData, TextInputSelectionChangeEventData} from 'react-native';
import {View} from 'react-native';
import {InteractionManager, View} from 'react-native';
import type {OnyxEntry} from 'react-native-onyx';
import {useOnyx} from 'react-native-onyx';
import {runOnUI, useSharedValue} from 'react-native-reanimated';
Expand Down Expand Up @@ -136,11 +136,24 @@ function ReportActionCompose({
const personalDetails = usePersonalDetails();
const [blockedFromConcierge] = useOnyx(ONYXKEYS.NVP_BLOCKED_FROM_CONCIERGE);
const [shouldShowComposeInput = true] = useOnyx(ONYXKEYS.SHOULD_SHOW_COMPOSE_INPUT);
const isScreenFocused = useIsFocused();
const [isScreenTransitionEnded, setIsScreenTransitionEnded] = useState(false);

useFocusEffect(
React.useCallback(() => {
const task = InteractionManager.runAfterInteractions(() => {
setIsScreenTransitionEnded(true);
});

return () => {
task.cancel();
setIsScreenTransitionEnded(false);
};
}, []),
);

const {renderProductTrainingTooltip, hideProductTrainingTooltip, shouldShowProductTrainingTooltip} = useProductTrainingContext(
CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.WORKSAPCE_CHAT_CREATE,
shouldShowEducationalTooltip && isScreenFocused,
shouldShowEducationalTooltip && isScreenTransitionEnded,
);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need isScreenFocused anymore because isScreenTransitionEnded will only be true if the screen is focused.


/**
Expand Down
Loading