-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add Explanation for Locked Category Toggle When Importing from QuickBooks. #56312
fix: Add Explanation for Locked Category Toggle When Importing from QuickBooks. #56312
Conversation
…uickBooks. Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Signed-off-by: krishna2323 <belivethatkg@gmail.com>
Reviewer Checklist
Screenshots/Videos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/Beamanator in version: 9.1.0-0 🚀
|
🚀 Deployed to production by https://github.com/francoisl in version: 9.1.0-2 🚀
|
Explanation of Change
Fixed Issues
$ #56181
PROPOSAL: #56181 (comment)
Tests
Categories
Settings
on the topMembers must categorize all expenses
.All expenses must be categorized in order to export to ${connectionName}.
Todos los gastos deben estar categorizados para poder exportar a ${connectionName}.
Verify that no errors appear in the JS console
Offline tests
Categories
Settings
on the topMembers must categorize all expenses
.All expenses must be categorized in order to export to ${connectionName}.
Todos los gastos deben estar categorizados para poder exportar a ${connectionName}.
QA Steps
Categories
Settings
on the topMembers must categorize all expenses
.All expenses must be categorized in order to export to ${connectionName}.
Todos los gastos deben estar categorizados para poder exportar a ${connectionName}.
Verify that no errors appear in the JS console
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop