Add animation for switch children #55478
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,81 @@ | ||
| import type {ReactNode} from 'react'; | ||
| import React from 'react'; | ||
| import type {StyleProp, ViewStyle} from 'react-native'; | ||
| import {View} from 'react-native'; | ||
| import type {SharedValue} from 'react-native-reanimated'; | ||
| import Animated, {Easing, useAnimatedStyle, useDerivedValue, useSharedValue, withTiming} from 'react-native-reanimated'; | ||
| import useThemeStyles from '@hooks/useThemeStyles'; | ||
|
|
||
| type AccordionProps = { | ||
| /** Giving information whether the component is open */ | ||
| isExpanded: SharedValue<boolean>; | ||
|
|
||
| /** Element that is inside Accordion */ | ||
| children: ReactNode; | ||
|
|
||
| /** Duration of expansion animation */ | ||
| duration?: number; | ||
|
|
||
| /** Additional external style */ | ||
| style?: StyleProp<ViewStyle>; | ||
|
|
||
| /** Was toggle triggered */ | ||
| isToggleTriggered: SharedValue<boolean>; | ||
| }; | ||
|
|
||
| function Accordion({isExpanded, children, duration = 300, isToggleTriggered, style}: AccordionProps) { | ||
| const height = useSharedValue(0); | ||
| const styles = useThemeStyles(); | ||
|
|
||
| const derivedHeight = useDerivedValue(() => { | ||
| if (!isToggleTriggered.get()) { | ||
| return isExpanded.get() ? height.get() : 0; | ||
| } | ||
|
|
||
| return withTiming(height.get() * Number(isExpanded.get()), { | ||
| duration, | ||
| easing: Easing.inOut(Easing.quad), | ||
| }); | ||
| }); | ||
|
|
||
| const derivedOpacity = useDerivedValue(() => { | ||
| if (!isToggleTriggered.get()) { | ||
| return isExpanded.get() ? 1 : 0; | ||
| } | ||
|
|
||
| return withTiming(isExpanded.get() ? 1 : 0, { | ||
| duration, | ||
| easing: Easing.inOut(Easing.quad), | ||
| }); | ||
| }); | ||
|
|
||
| const animatedStyle = useAnimatedStyle(() => { | ||
| if (!isToggleTriggered.get() && !isExpanded.get()) { | ||
| return { | ||
| height: 0, | ||
| opacity: 0, | ||
| }; | ||
| } | ||
| return { | ||
| height: !isToggleTriggered.get() ? height.get() : derivedHeight.get(), | ||
| opacity: derivedOpacity.get(), | ||
| }; | ||
| }); | ||
|
|
||
| return ( | ||
| <Animated.View style={[animatedStyle, style]}> | ||
| <View | ||
| onLayout={(e) => { | ||
| height.set(e.nativeEvent.layout.height); | ||
| }} | ||
| style={[styles.pAbsolute, styles.l0, styles.r0, styles.t0]} | ||
| > | ||
| {children} | ||
| </View> | ||
| </Animated.View> | ||
| ); | ||
| } | ||
|
|
||
| Accordion.displayName = 'Accordion'; | ||
|
|
||
| export default Accordion; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,78 @@ | ||
| import type {ReactNode} from 'react'; | ||
| import React from 'react'; | ||
| import type {StyleProp, ViewStyle} from 'react-native'; | ||
| import {View} from 'react-native'; | ||
| import type {SharedValue} from 'react-native-reanimated'; | ||
| import Animated, {Easing, useAnimatedStyle, useDerivedValue, useSharedValue, withTiming} from 'react-native-reanimated'; | ||
|
|
||
| type AccordionProps = { | ||
| /** Giving information whether the component is open */ | ||
| isExpanded: SharedValue<boolean>; | ||
|
|
||
| /** Element that is inside Accordion */ | ||
| children: ReactNode; | ||
|
|
||
| /** Duration of expansion animation */ | ||
| duration?: number; | ||
|
|
||
| /** Additional external style */ | ||
| style?: StyleProp<ViewStyle>; | ||
|
|
||
| /** Was toggle triggered */ | ||
| isToggleTriggered: SharedValue<boolean>; | ||
| }; | ||
|
|
||
| function Accordion({isExpanded, children, duration = 300, isToggleTriggered, style}: AccordionProps) { | ||
| const height = useSharedValue(0); | ||
|
|
||
| const derivedHeight = useDerivedValue(() => { | ||
| if (!isToggleTriggered.get()) { | ||
| return isExpanded.get() ? height.get() : 0; | ||
| } | ||
|
|
||
| return withTiming(height.get() * Number(isExpanded.get()), { | ||
| duration, | ||
| easing: Easing.inOut(Easing.quad), | ||
| }); | ||
| }); | ||
|
|
||
| const derivedOpacity = useDerivedValue(() => { | ||
| if (!isToggleTriggered.get()) { | ||
| return isExpanded.get() ? 1 : 0; | ||
| } | ||
|
|
||
| return withTiming(isExpanded.get() ? 1 : 0, { | ||
| duration, | ||
| easing: Easing.inOut(Easing.quad), | ||
| }); | ||
| }); | ||
|
|
||
| const animatedStyle = useAnimatedStyle(() => { | ||
| if (!isToggleTriggered.get() && !isExpanded.get()) { | ||
| return { | ||
| height: 0, | ||
| opacity: 0, | ||
| }; | ||
| } | ||
|
|
||
| return { | ||
| height: !isToggleTriggered.get() ? undefined : derivedHeight.get(), | ||
| opacity: derivedOpacity.get(), | ||
| }; | ||
| }); | ||
|
|
||
| return ( | ||
| <Animated.View style={[animatedStyle, style]}> | ||
| <View | ||
| onLayout={(e) => { | ||
| height.set(e.nativeEvent.layout.height); | ||
| }} | ||
| > | ||
| {children} | ||
| </View> | ||
| </Animated.View> | ||
| ); | ||
| } | ||
| Accordion.displayName = 'Accordion'; | ||
|
|
||
| export default Accordion; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1063,9 +1063,9 @@ function removePendingFieldsFromCustomUnit(customUnit: CustomUnit): CustomUnit { | |
| return cleanedCustomUnit; | ||
| } | ||
|
|
||
| function goBackWhenEnableFeature(policyID: string) { | ||
| setTimeout(() => { | ||
|
There was a problem hiding this comment. I'm a bit concerned about using setTimeout, we try to avoid it unless absolutely necessary. cc: @mountiny There was a problem hiding this comment. is exactly the same solution as it was before in the navigate function: which we replacing here There was a problem hiding this comment. Ah, my bad. Let's not make any changes here then. |
||
| Navigation.goBack(ROUTES.WORKSPACE_INITIAL.getRoute(policyID)); | ||
| }, CONST.WORKSPACE_ENABLE_FEATURE_REDIRECT_DELAY); | ||
| } | ||
|
|
||
|
|
@@ -1355,7 +1355,7 @@ export { | |
| getDistanceRateCustomUnitRate, | ||
| sortWorkspacesBySelected, | ||
| removePendingFieldsFromCustomUnit, | ||
| goBackWhenEnableFeature, | ||
| getIntegrationLastSuccessfulDate, | ||
| getCurrentConnectionName, | ||
| getCustomersOrJobsLabelNetSuite, | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like this line was missing 1 extra check which led to the causation of this issue:
which was addressed in PR: