Add onTooltipPress callback to various tooltip components #55454

ishpaul777 · 2025-01-18T23:00:11Z

Explanation of Change

Fixed Issues

$ #55371
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Sign up with new account, verify you see tooltip on FAB, click on tooltip Verify you FAB menu opens, close it
Verify you see a tooltip on concierge, click on tooltip Verify you concierge chat opens, close it
Create a workspace go to inbox, Verify you see a tooltip on workspace chat, click on tooltip Verify you workspace chat opens, close it
Open FAB, verify you see tooltip on QAB click on it and veriy you got redirected Submit expense flow
Open Search page and verify you see tooltip on filter button click on tooltip veify filter page opens.

Offline tests

QA Steps

Verify that no errors appear in the JS console
same as test steps

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-22.at.2.56.19.AM.mov

Screen.Recording.2025-01-22.at.2.58.00.AM.mov

Screen.Recording.2025-01-22.at.2.59.42.AM.mov

Screen.Recording.2025-01-22.at.3.01.53.AM.mov

Screen.Recording.2025-01-22.at.3.05.21.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-22.at.3.10.40.AM.mov

iOS: Native

Screen.Recording.2025-01-22.at.2.31.38.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-01-22.at.2.33.56.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-01-22.at.2.13.08.AM.mov

MacOS: Desktop

Screen.Recording.2025-01-22.at.3.18.30.AM.mov

src/components/Tooltip/BaseGenericTooltip/index.tsx

rayane-d

The latest merge main commit introduced unrelated changes, can you please revert the latest commit and merge main again?

rayane-d

Code looks good

ishpaul777 · 2025-01-21T18:54:55Z

thanks! I am working on checklist now

melvin-bot · 2025-01-21T21:52:02Z

@rayane-djouah Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shawnborton · 2025-01-22T06:39:16Z

Videos look pretty good to me 👍

ishpaul777 · 2025-01-22T17:55:40Z

@rayane-djouah friendly bump for final review 🙏

rayane-d · 2025-01-22T18:17:42Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-23.at.4.00.55.PM.mov

Android: mWeb Chrome

Screen.Recording.2025-01-23.at.3.57.52.PM.mov

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-23.at.16.05.24.mp4

iOS: mWeb Safari

Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2025-01-23.at.15.53.17.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-01-23.at.3.50.56.PM.mov

MacOS: Desktop

Screen.Recording.2025-01-23.at.3.49.07.PM.mov

src/components/Tooltip/BaseGenericTooltip/index.tsx

rayane-d

LGTM and tests well

puneetlath

Small comment. Tests well when I try it. Good job!

src/components/PopoverProvider/index.tsx

puneetlath · 2025-01-23T15:13:53Z

src/components/MenuItem.tsx

            >
                <View>
                    <Hoverable>
                        {(isHovered) => (
                            <PressableWithSecondaryInteraction
-                                onPress={shouldCheckActionAllowedOnPress ? Session.checkIfActionIsAllowed(onPressAction, isAnonymousAction) : onPressAction}
-                                onPressIn={() => shouldBlockSelection && shouldUseNarrowLayout && DeviceCapabilities.canUseTouchScreen() && ControlSelection.block()}
+                                onPress={shouldCheckActionAllowedOnPress ? checkIfActionIsAllowed(onPressAction, isAnonymousAction) : onPressAction}


NAB but checkIfActionIsAllowed is a confusing function name. It sounds like it will return a boolean.

It is confusing 💯 agree, should I change it to callFnIfActionIsAllowed? I see function is used widely across the codebase happy to raise a follow-up PR just so we keep this PR clean

Let's do it as a follow up, thanks!

Here it is #55663

…xtProvider

OSBotify · 2025-01-23T19:28:47Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-23T20:04:36Z

🚀 Deployed to staging by https://github.com/puneetlath in version: 9.0.89-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-28T01:52:41Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.89-8 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

ishpaul777 added 6 commits January 19, 2025 04:25

Add onTooltipPress callback to various tooltip components

0dfd994

Update educational tooltip style to conditionally apply pointer events

2d27d4c

move educational tooltip to save search three dot menu

f869bd4

fix typing

b4ec870

fix eslint

77ac032

Merge branch 'main' into make-tooltips-pressable

f0217bb

ishpaul777 mentioned this pull request Jan 20, 2025

[$500] [HOLD for payment 2025-02-04] Make clicking an onboarding tooltip do the action that the tooltip is pointing to #55371

Closed

rayane-d suggested changes Jan 20, 2025

View reviewed changes

src/components/Tooltip/BaseGenericTooltip/index.tsx Outdated Show resolved Hide resolved

make suggested change

1bf9857

rayane-d suggested changes Jan 20, 2025

View reviewed changes

ishpaul777 force-pushed the make-tooltips-pressable branch from 80743ea to 1bf9857 Compare January 21, 2025 08:29

Merge branch 'Expensify:main' into make-tooltips-pressable

b0cb26d

rayane-d reviewed Jan 21, 2025

View reviewed changes

ishpaul777 marked this pull request as ready for review January 21, 2025 21:51

ishpaul777 requested review from a team as code owners January 21, 2025 21:51

melvin-bot bot requested review from rayane-d and removed request for a team January 21, 2025 21:52

shawnborton previously approved these changes Jan 22, 2025

View reviewed changes

lint fix

d9d6b2a

ishpaul777 dismissed shawnborton’s stale review via d9d6b2a January 22, 2025 17:52

Merge branch 'main' into make-tooltips-pressable

dfd8604

rayane-d suggested changes Jan 22, 2025

View reviewed changes

src/components/Tooltip/BaseGenericTooltip/index.tsx Show resolved Hide resolved

ishpaul777 added 2 commits January 23, 2025 14:28

fix as per review

085e6b7

declare animated pressable as seperate component

572a438

rename Wrapper to AnimatedWrapper

d4bfec3

rayane-d approved these changes Jan 23, 2025

View reviewed changes

melvin-bot bot requested a review from puneetlath January 23, 2025 15:02

puneetlath requested changes Jan 23, 2025

View reviewed changes

ishpaul777 added 2 commits January 23, 2025 23:44

add comments to clarify handling of extra anchor refs in PopoverConte…

c181839

…xtProvider

add comments to clarify handling of extra anchor refs

fdd058a

ishpaul777 requested a review from puneetlath January 23, 2025 18:40

puneetlath approved these changes Jan 23, 2025

View reviewed changes

puneetlath merged commit 726c3e8 into Expensify:main Jan 23, 2025
18 checks passed

ishpaul777 mentioned this pull request Jan 23, 2025

[NO QA] change checkIfActionIsAllowed function name and other lint fixes #55663

Merged

50 tasks

github-actions bot mentioned this pull request Jan 23, 2025

Deploy Checklist: New Expensify 2025-01-23 #55657

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add onTooltipPress callback to various tooltip components #55454

Add onTooltipPress callback to various tooltip components #55454

ishpaul777 commented Jan 18, 2025 •

edited

Loading

rayane-d left a comment

rayane-d left a comment

ishpaul777 commented Jan 21, 2025

melvin-bot bot commented Jan 21, 2025

shawnborton commented Jan 22, 2025

ishpaul777 commented Jan 22, 2025

rayane-d commented Jan 22, 2025 •

edited

Loading

rayane-d left a comment

puneetlath left a comment

puneetlath Jan 23, 2025

ishpaul777 Jan 23, 2025 •

edited

Loading

puneetlath Jan 23, 2025

ishpaul777 Jan 23, 2025

OSBotify commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

Add onTooltipPress callback to various tooltip components #55454

Add onTooltipPress callback to various tooltip components #55454

Conversation

ishpaul777 commented Jan 18, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

rayane-d left a comment

Choose a reason for hiding this comment

rayane-d left a comment

Choose a reason for hiding this comment

ishpaul777 commented Jan 21, 2025

melvin-bot bot commented Jan 21, 2025

shawnborton commented Jan 22, 2025

ishpaul777 commented Jan 22, 2025

rayane-d commented Jan 22, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

rayane-d left a comment

Choose a reason for hiding this comment

puneetlath left a comment

Choose a reason for hiding this comment

puneetlath Jan 23, 2025

Choose a reason for hiding this comment

ishpaul777 Jan 23, 2025 • edited Loading

Choose a reason for hiding this comment

puneetlath Jan 23, 2025

Choose a reason for hiding this comment

ishpaul777 Jan 23, 2025

Choose a reason for hiding this comment

OSBotify commented Jan 23, 2025

github-actions bot commented Jan 23, 2025

github-actions bot commented Jan 28, 2025

ishpaul777 commented Jan 18, 2025 •

edited

Loading

rayane-d commented Jan 22, 2025 •

edited

Loading

ishpaul777 Jan 23, 2025 •

edited

Loading