Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix distance amount changes after submitting track distance expense with description #55063

Closed
Closed
4 changes: 2 additions & 2 deletions src/libs/API/parameters/CategorizeTrackedExpenseParams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ type CategorizeTrackedExpenseParams = {
taxCode: string;
taxAmount: number;
billable?: boolean;
waypoints?: string;
customUnitRateID?: string;
policyExpenseChatReportID?: string;
policyExpenseCreatedReportActionID?: string;
adminsChatReportID?: string;
adminsCreatedReportActionID?: string;
waypoints?: string;
customUnitRateID?: string;
};

export default CategorizeTrackedExpenseParams;
4 changes: 2 additions & 2 deletions src/libs/API/parameters/ShareTrackedExpenseParams.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,12 @@ type ShareTrackedExpenseParams = {
taxCode: string;
taxAmount: number;
billable?: boolean;
waypoints?: string;
customUnitRateID?: string;
policyExpenseChatReportID?: string;
policyExpenseCreatedReportActionID?: string;
adminsChatReportID?: string;
adminsCreatedReportActionID?: string;
customUnitRateID?: string;
waypoints?: string;
};

export default ShareTrackedExpenseParams;
8 changes: 7 additions & 1 deletion src/libs/actions/IOU.ts
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ import {
getTransaction,
getUpdatedTransaction,
hasReceipt as hasReceiptTransactionUtils,
isCustomUnitRateIDForP2P,
isDistanceRequest as isDistanceRequestTransactionUtils,
isFetchingWaypointsFromServer,
isOnHold,
Expand Down Expand Up @@ -4622,6 +4623,9 @@ function trackExpense(
value: recentServerValidatedWaypoints,
});

const waypoints = validWaypoints ? JSON.stringify(sanitizeRecentWaypoints(validWaypoints)) : undefined;
const mileageRate = isCustomUnitRateIDForP2P(transaction) ? undefined : customUnitRateID;

switch (action) {
case CONST.IOU.ACTION.CATEGORIZE: {
if (!linkedTrackedExpenseReportAction || !actionableWhisperReportActionID || !linkedTrackedExpenseReportID) {
Expand All @@ -4640,6 +4644,8 @@ function trackExpense(
tag,
billable,
receipt: trackedReceipt instanceof Blob ? trackedReceipt : undefined,
waypoints,
customUnitRateID: mileageRate,
};
const policyParams: TrackedExpensePolicyParams = {
policyID: chatReport?.policyID,
Expand Down Expand Up @@ -4684,7 +4690,7 @@ function trackExpense(
billable,
receipt: trackedReceipt instanceof Blob ? trackedReceipt : undefined,
waypoints: sanitizedWaypoints,
customUnitRateID,
customUnitRateID: mileageRate,
};
const policyParams: TrackedExpensePolicyParams = {
policyID: chatReport?.policyID,
Expand Down
Loading