Add feature to delete unverified contact methods #54784

Shahidullah-Muffakir · 2025-01-03T20:29:34Z

Explanation of Change

Fixed Issues

$ #54626
PROPOSAL: #54626 (comment)

Tests

Click on Settings.
Click on Profile.
Click on Contact Methods.
Click on New Contact Method.
Enter a valid email and click Add.
Paste the verification code from the email and click Verify.
On the Contact Methods screen, click the recently added unverified contact method.
Click the three-dot menu in the header.
Click Remove.
Verify the Delete Confirmation modal appears.
Click Cancel and verify the page remains on the same Validate Code screen.
Repeat Step 8 (click the three-dot menu again).
Verify the Delete Confirmation modal appears again.
This time, click Yes, Continue.
Verify you are redirected to the Contact Methods page, and the unverified contact method is no longer listed.

Verify that no errors appear in the JS console

Offline tests

This feature requires internet connection

QA Steps

Click on Settings.
Click on Profile.
Click on Contact Methods.
Click on New Contact Method.
Enter a valid email and click Add.
Paste the verification code from the email and click Verify.
On the Contact Methods screen, click the recently added unverified contact method.
Click the three-dot menu in the header.
Click Remove.
Verify the Delete Confirmation modal appears.
Click Cancel and verify the page remains on the same Validate Code screen.
Repeat Step 8 (click the three-dot menu again).
Verify the Delete Confirmation modal appears again.
This time, click Yes, Continue.
Verify you are redirected to the Contact Methods page, and the unverified contact method is no longer listed.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.native.mov

Android: mWeb Chrome

android.web.mov

iOS: Native

ios.native.mov

iOS: mWeb Safari

ios.safari.mov

MacOS: Chrome / Safari

macos.chrome.mov

MacOS: Desktop

desktop.mov

melvin-bot · 2025-01-03T20:29:39Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

…Modal

parasharrajat · 2025-01-08T12:58:56Z

@Shahidullah-Muffakir Let's fix the keyboard showing up when the remove modal is open.

08.01.2025_18.27.31_REC.mp4

Shahidullah-Muffakir · 2025-01-08T15:46:55Z

@parasharrajat, Added the changes.

parasharrajat · 2025-01-09T08:06:56Z

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

@@ -273,6 +277,16 @@ function ContactMethodDetailsPage({route}: ContactMethodDetailsPageProps) {
                    }}
                    sendValidateCode={() => User.requestContactMethodValidateCode(contactMethod)}
                    descriptionPrimary={translate('contacts.enterMagicCode', {contactMethod: formattedContactMethod})}
+                    shouldShowThreeDotsButton={isValidateCodeActionModalVisible}
+                    onThreeDotsButtonPress={() => blurActiveElement()}


Did you test it? There is no logic on native for this method.

Yes, I tested it. The keyboard hides automatically on native when the user clicks the three-dot menu, so there's no need to use Keyboard.dismiss

Sorry, I overlooked that after clicking the remove button. I applied blurActiveElement() for web and Keyboard.dismiss() for native. Retested on all platforms and added new screen recordings.

parasharrajat · 2025-01-10T10:40:45Z

@Shahidullah-Muffakir There is app freezing issue on iOS. When I click the remove button, the second modal does not show but the app freezes.

Shahidullah-Muffakir · 2025-01-10T11:40:28Z

@Shahidullah-Muffakir There is app freezing issue on iOS. When I click the remove button, the second modal does not show but the app freezes.

Oh, okay. Looking into it now.

Shahidullah-Muffakir · 2025-01-10T14:12:56Z

@parasharrajat Weird issue, keyboard is not showing at all in the Android emulator, not just in the Expensify app. Do you have any idea how to fix this? I've tried Cmd+Shift+K and Cmd+K, but nothing happens.

Shahidullah-Muffakir · 2025-01-10T14:24:21Z

Never mind, I found it.

parasharrajat · 2025-01-10T18:32:49Z

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx

+                    onThreeDotsButtonPress={() => {
+                        if (Platform.OS === 'web') {
+                            blurActiveElement();
+                        } else {
+                            Keyboard.dismiss();
+                        }
+                    }}


Can you please explain this change?

This change hides the keyboard when the user clicks the three-dot menu:

blurActiveElement() is used to hide the keyboard for mobile web.

Keyboard.dismiss() is used to hide the keyboard for native apps.

Oh, did you mean I should add this as a comment in the code?

No, I wanted to understand the change. I noticed that there is a Keyboard lib in our codebase. It was created to handle Keyboard Avoidance view behavior. we should use that instead. There is a web implementation but I am not sure how that is working as keyboard.dismiss is a mock function on the web.

blurActiveElement() was created to blur the UI elements and remove focus from them so that also not very best suited for this keyboard dismissal. We should add a comment to this lib to clarify the purpose otherwise, incorrect use can cause issues.

Remove the Platform === web check. We don't need it. we can call both methods together but add a comment explaining why both are used.

Here Keyboard will be from our lib to support native. I think it will not cause any issue for web. Correct?

You mean

import { Keyboard} from 'react-native'; Keyboard.dismiss()

right?
Because using this works well in native, and not causing any issue in web.

Nope,

import {Keyboard} from '@lib/util/Keyboard';

Oh, is there any specific reason for using that? It returns a promise, which we don't need it in this scenario.
Also, we're using {Keyboard} from 'react-native' across the app, and it works well in this case too

Anyway, I've used the local lib 😄.

Oh, is there any specific reason for using that?

As I mentioned, due the keyboard avoiding behaviour functionality.

…ent for web and KeyboardUtils.dismiss for native

parasharrajat · 2025-01-12T11:55:26Z

Ok so the freezing issue is still not solved on iOS. Can you please check that again?

Shahidullah-Muffakir · 2025-01-12T12:32:24Z

Ok so the freezing issue is still not solved on iOS. Can you please check that again?

Weird, I just retested it, and it's working well for me.

Screen.Recording.2025-01-12.at.6.00.08.PM.mov

Shahidullah-Muffakir · 2025-01-12T13:30:25Z

Maybe merging main will help

parasharrajat · 2025-01-12T14:18:52Z

@Shahidullah-Muffakir Nope, I removed the node_modules, cleared react-native cache and fresh build the app. I still see free issue and remove modal does not show to me.

Try to clean the cache and do a fresh build.

Shahidullah-Muffakir · 2025-01-12T14:30:29Z

Try to clean the cache and do a fresh build.

Ok, let me try this

Shahidullah-Muffakir · 2025-01-12T16:49:48Z

Try to clean the cache and do a fresh build.

Okay, Now I am also facing this issue after the rebuild, Any idea what might be causing this? I’m looking into it.

…onfirmation modal

Shahidullah-Muffakir · 2025-01-12T17:58:22Z

@parasharrajat, It works now, I used Modal.close before opening the delete confirmation modal, and that fixed the issue.

parasharrajat · 2025-01-12T18:07:09Z

@Shahidullah-Muffakir Can you please share the vid?

Shahidullah-Muffakir · 2025-01-12T18:15:56Z

@Shahidullah-Muffakir Can you please share the vid?

Sure

Screen.Recording.2025-01-12.at.11.44.57.PM.mov

Shahidullah-Muffakir · 2025-01-12T18:23:47Z

Here is the iOS video:

Screen.Recording.2025-01-12.at.11.51.15.PM.mov

parasharrajat · 2025-01-12T20:10:31Z

Screenshots

🔲 iOS / native

13.01.2025_01.41.27_REC.mp4

🔲 iOS / Safari

08.01.2025_17.45.32_REC.mp4

🔲 MacOS / Desktop

08.01.2025_17.35.37_REC.mp4

🔲 MacOS / Chrome

08.01.2025_17.27.56_REC.mp4

🔲 Android / Chrome

13.01.2025_01.50.02_REC.mp4

🔲 Android / native

13.01.2025_02.26.31_REC.mp4

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

tgolen · 2025-01-13T15:51:52Z

src/components/ValidateCodeActionModal/index.tsx

@@ -29,10 +30,15 @@ function ValidateCodeActionModal({
    hasMagicCodeBeenSent,
    isLoading,
    shouldHandleNavigationBack,
+    shouldShowThreeDotsButton = false,


Can the value of this prop be determined by the length of threeDotsMenuItems? ie. it should be TRUE when there are items in the array and FALSE when there are no items in the array? It seems unnecessary to have the shouldShowThreeDotsButton prop.

Got it, I’ll update it based on threeDotsMenuItems.length as
shouldShowThreeDotsButton={threeDotsMenuItems.length>0}

@tgolen , after looking at it again, I realized that the three-dot menu only shows when the contact is not primary and not verified. If I use the threeDotsMenuItems.length>0, it would always show the button, so I guess we need this prop.

OK. If I follow that logic though, if the menu is not shown, why would it need to have any menu items at all? I would say, remove the menu items based on the contact is not primary and not verified and it should still work the same. Right?

Right, we can do that as well.
I added the shouldShowThreeDotsButton prop because it was already available in the props for the ThreeDotsMenu and HeaderWithBackButton
It seems we could use the same logic there as well, but that would need to update the threeDotsMenuItems in different pages

tgolen

Thank you!

OSBotify · 2025-01-13T17:47:22Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2025-01-14T13:59:56Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T14:15:57Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T14:41:19Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T15:25:00Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-01-14T15:49:11Z

🚀 Deployed to staging by https://github.com/tgolen in version: 9.0.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	cancelled 🔪

github-actions · 2025-01-15T13:48:03Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-15T15:48:59Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.85-4 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Add feature to delete unverified contact methods

0a78fbe

Shahidullah-Muffakir requested a review from a team as a code owner January 3, 2025 20:29

melvin-bot bot requested review from parasharrajat and removed request for a team January 3, 2025 20:29

Shahidullah-Muffakir commented Jan 3, 2025

View reviewed changes

src/pages/settings/Profile/Contacts/ContactMethodDetailsPage.tsx Outdated Show resolved Hide resolved

Shahidullah-Muffakir mentioned this pull request Jan 3, 2025

[HOLD for payment 2025-01-22] [$250] Contact method - There is no feature to delete unverified contact methods. #54626

Closed

8 tasks

Shahidullah-Muffakir added 2 commits January 8, 2025 04:03

Fix iOS modal issue by nesting ConfirmModal inside ValidateCodeAction…

a88ac96

…Modal

Merge branch 'main' of github.com:Expensify/App into fix/54626

c50cfc5

Dismiss keyboard when user clicks three-dot menu

715d047

parasharrajat reviewed Jan 9, 2025

View reviewed changes

apply blurActiveElement() for web, Keyboard.dismiss() for native apps

874605e

parasharrajat suggested changes Jan 10, 2025

View reviewed changes

Shahidullah-Muffakir added 2 commits January 11, 2025 06:44

Hide keyboard when user clicks on three-dot menue, use blurActiveElem…

9ccb8bf

…ent for web and KeyboardUtils.dismiss for native

Merge branch 'main' of github.com:Expensify/App into fix/54626

dedbbfd

Fix modal stacking issue by using Modal.close before opening delete c…

32da5c6

…onfirmation modal

parasharrajat approved these changes Jan 12, 2025

View reviewed changes

melvin-bot bot requested a review from tgolen January 12, 2025 20:57

tgolen requested changes Jan 13, 2025

View reviewed changes

use threeDotsMenuItems.length for showing the threeDotMenu

5413f30

tgolen approved these changes Jan 13, 2025

View reviewed changes

tgolen merged commit b04982c into Expensify:main Jan 13, 2025
16 checks passed

github-actions bot mentioned this pull request Jan 14, 2025

Deploy Checklist: New Expensify 2025-01-14 #55208

Closed

38 tasks

IuliiaHerets mentioned this pull request Jan 14, 2025

Contact methods - Remove contact method modal appears slower than other confirmation modals #55213

Closed

8 tasks

Add feature to delete unverified contact methods #54784

Add feature to delete unverified contact methods #54784

Conversation

Shahidullah-Muffakir commented Jan 3, 2025 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 3, 2025

parasharrajat commented Jan 8, 2025

Shahidullah-Muffakir commented Jan 8, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parasharrajat commented Jan 10, 2025

Shahidullah-Muffakir commented Jan 10, 2025

Shahidullah-Muffakir commented Jan 10, 2025

Shahidullah-Muffakir commented Jan 10, 2025

Choose a reason for hiding this comment

Shahidullah-Muffakir Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Shahidullah-Muffakir Jan 10, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Shahidullah-Muffakir Jan 11, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

parasharrajat commented Jan 12, 2025

Shahidullah-Muffakir commented Jan 12, 2025

Shahidullah-Muffakir commented Jan 12, 2025

parasharrajat commented Jan 12, 2025 • edited Loading

Shahidullah-Muffakir commented Jan 12, 2025

Shahidullah-Muffakir commented Jan 12, 2025

Shahidullah-Muffakir commented Jan 12, 2025

parasharrajat commented Jan 12, 2025

Shahidullah-Muffakir commented Jan 12, 2025

Shahidullah-Muffakir commented Jan 12, 2025

parasharrajat commented Jan 12, 2025 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

tgolen left a comment

Choose a reason for hiding this comment

OSBotify commented Jan 13, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 14, 2025

github-actions bot commented Jan 15, 2025

github-actions bot commented Jan 15, 2025

Shahidullah-Muffakir commented Jan 3, 2025 •

edited

Loading

Shahidullah-Muffakir Jan 10, 2025 •

edited

Loading

Shahidullah-Muffakir Jan 10, 2025 •

edited

Loading

Shahidullah-Muffakir Jan 11, 2025 •

edited

Loading

parasharrajat commented Jan 12, 2025 •

edited

Loading

parasharrajat commented Jan 12, 2025 •

edited

Loading