-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the images in the Create an Expense help article #54544
Conversation
Adding new images to the help article based on this suggestion- Expensify/Expensify#438175 (comment)
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? |
@neil-marcellini @bfitzexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
A preview of your ExpensifyHelp changes have been deployed to https://00502d2e.helpdot.pages.dev ⚡️ |
HI @bfitzexpensify - thanks for the review. I know we're busy so I don't expect this to be done asap, just keeping it moving. Here's the help article and revised images for your review - https://00502d2e.helpdot.pages.dev/articles/new-expensify/expenses-&-payments/Create-an-expense |
🚀 Deployed to staging by https://github.com/bfitzexpensify in version: 9.0.79-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.79-5 🚀
|
Explanation of Change
Fixed Issues
The Submit Expense image in the help article is outdated - so this PR is to update it and the other images to the latest versions of the app
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.