Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix: clicking submit button makes flicking on a workspace with delay …" #54395

Merged
merged 1 commit into from
Dec 19, 2024
Merged

Revert "fix: clicking submit button makes flicking on a workspace with delay …" #54395

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/libs/Middleware/SaveResponseInOnyx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
SIDE_EFFECT_REQUEST_COMMANDS.RECONNECT_APP,
WRITE_COMMANDS.CLOSE_ACCOUNT,
WRITE_COMMANDS.DELETE_MONEY_REQUEST,
WRITE_COMMANDS.SUBMIT_REPORT,
SIDE_EFFECT_REQUEST_COMMANDS.GET_MISSING_ONYX_MESSAGES,
];

Expand All @@ -26,13 +25,13 @@

const responseToApply = {
type: CONST.ONYX_UPDATE_TYPES.HTTPS,
lastUpdateID: Number(response?.lastUpdateID ?? 0),

Check failure on line 28 in src/libs/Middleware/SaveResponseInOnyx.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

previousUpdateID: Number(response?.previousUpdateID ?? 0),

Check failure on line 29 in src/libs/Middleware/SaveResponseInOnyx.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

request,
response: response ?? {},
};

if (requestsToIgnoreLastUpdateID.includes(request.command) || !OnyxUpdates.doesClientNeedToBeUpdated(Number(response?.previousUpdateID ?? 0))) {

Check failure on line 34 in src/libs/Middleware/SaveResponseInOnyx.ts

View workflow job for this annotation

GitHub Actions / Changed files ESLint check

return OnyxUpdates.apply(responseToApply);
}

Expand Down
Loading