Update manage-travel-member-roles.md #54308

CortneyOfstad · 2024-12-18T16:54:31Z

Explanation of Change

Edits to this page were originally done in August, however, they did not post to production. I've made some slight edits to act as a "refresh" on the page to get a new PR into the world, so it can be launched into production on the help site page. More context here.

Fixed Issues

#46202

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-12-18T16:55:08Z

melvin-bot · 2024-12-18T16:55:11Z

@dangrous @kadiealexander One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2024-12-18T16:57:15Z

A preview of your ExpensifyHelp changes have been deployed to https://d33ccca1.helpdot.pages.dev ⚡️

CortneyOfstad · 2024-12-18T16:58:11Z

Hey @kadiealexander and @dangrous — this is coming from #46202. For some reason, the changes I implemented back in Aug/September did not go into production. If something needs to be changes or tweaked in terms of my PR, please let me know and I can get that wrapped up ASAP.

I am OoO next week for the holidays, so hoping to have this done before EOW. Thank you!

Also, the dev link above, flashes with the information and then it disappears. Not sure what is going on, but I got a video for context:

kadiealexander · 2024-12-19T05:08:03Z

Hey @CortneyOfstad I don't think this looks quite right? It looks like maybe the article is split in two, with half on Expensify Classic and half on New Expensify. Also I think the header should be capitalised.

It also isn't showing up in the Expensify Classic section of the help site, I think maybe we need a separate file in docs/articles/expensify-classic/ to do that but maybe @dangrous can confirm.

dangrous · 2024-12-19T17:52:44Z

Yep, you're spot on (see convo here).

We need an additional file if we want it to show up on the classic side.
Capitalizing the file name should capitalize the title
The content does seem split between new/old expensify incorrectly, I'll suggest changes that will fix that

dangrous · 2024-12-19T17:55:46Z

oh annoyingly I can't suggest changes in places that weren't edited. Well, the top should look like this:

 title: Manage Travel Member Roles
 description: Modify member roles within Expensify Travel
 ---
-<div id="expensify-classic" markdown="1">
+<div id="new-expensify" markdown="1">

 Admins can assign roles to different travel members to determine who they can book travel for (whether for themselves and/or for others) and whether they can adjust administrative settings.
-
-</div>
-
-<div id="new-expensify" markdown="1">

 To assign a role to a travel member,

And then for the new file in the classic one, just swap out new-expensify for expensify-classic in that section

kadiealexander · 2024-12-20T01:17:04Z

Noting that I'm heading OOO for two weeks today, so you may need to grab a US coach to do the final review tomorrow @CortneyOfstad.

CortneyOfstad · 2024-12-20T17:30:44Z

Thanks @dangrous! I've gone ahead and updated the top as you clarified. It created a new patch, which is found here — #54429.

I've assigned you since you have context. Can you take a look?

This is just for NewExpensify as the steps need to be tweaked for classic. Working on that separately now 👍

dangrous

Do we need this additional update? Bolding the Users? If so we might as well merge this one!

dangrous · 2024-12-20T20:50:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

kadiealexander · 2025-01-06T06:21:33Z

@CortneyOfstad what's the plan with this PR, are we closing it in favour of the new PR here?

dangrous · 2025-01-08T15:55:35Z

We should probably either push this one or add the change to the new one, right? seems like a good change to make for consistency

CortneyOfstad · 2025-01-08T16:57:31Z

@dangrous Does it make more sense to just push through the new patch and close this one? The new one has the updated title, but wasn't sure if there is preference in these situations

dangrous · 2025-01-08T19:50:46Z

So we should definitely push the other one through, but if we want this change (bolding that word) we might as well do this one too. (Rather than recreating the same change on the new PR).

kadiealexander · 2025-01-09T02:21:16Z

I'm happy to push this one through, knowing the rest of the changes will be made elsewhere 👍

CortneyOfstad · 2025-01-09T13:19:07Z

Thanks guys!!!

github-actions · 2025-01-10T03:57:22Z

🚀 Deployed to staging by https://github.com/dangrous in version: 9.0.83-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-11T03:25:08Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.83-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-01-13T13:58:29Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.83-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

Update manage-travel-member-roles.md

a526e41

CortneyOfstad self-assigned this Dec 18, 2024

CortneyOfstad requested a review from a team as a code owner December 18, 2024 16:54

melvin-bot bot requested review from dangrous and kadiealexander and removed request for a team December 18, 2024 16:55

CortneyOfstad added Daily KSv2 HelpDot Apply this label if the issue relates to ExpensifyHelp Reviewing Has a PR in review labels Dec 18, 2024

CortneyOfstad mentioned this pull request Dec 20, 2024

Update manage-travel-member-roles.md #54429

Merged

50 tasks

dangrous approved these changes Dec 20, 2024

View reviewed changes

kadiealexander approved these changes Jan 9, 2025

View reviewed changes

dangrous merged commit df73b07 into main Jan 9, 2025
11 of 60 checks passed

dangrous deleted the CortneyOfstad-patch-1 branch January 9, 2025 15:17

github-actions bot mentioned this pull request Jan 10, 2025

Deploy Checklist: New Expensify 2025-01-10 #55051

Closed

54 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update manage-travel-member-roles.md #54308

Update manage-travel-member-roles.md #54308

CortneyOfstad commented Dec 18, 2024 •

edited

Loading

melvin-bot bot commented Dec 18, 2024 •

edited by kadiealexander

Loading

melvin-bot bot commented Dec 18, 2024

OSBotify commented Dec 18, 2024

CortneyOfstad commented Dec 18, 2024 •

edited

Loading

kadiealexander commented Dec 19, 2024

dangrous commented Dec 19, 2024

dangrous commented Dec 19, 2024

kadiealexander commented Dec 20, 2024

CortneyOfstad commented Dec 20, 2024

dangrous left a comment

dangrous commented Dec 20, 2024 •

edited

Loading

kadiealexander commented Jan 6, 2025

dangrous commented Jan 8, 2025

CortneyOfstad commented Jan 8, 2025

dangrous commented Jan 8, 2025

kadiealexander commented Jan 9, 2025

CortneyOfstad commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 11, 2025

github-actions bot commented Jan 13, 2025

Update manage-travel-member-roles.md #54308

Update manage-travel-member-roles.md #54308

Conversation

CortneyOfstad commented Dec 18, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 18, 2024 • edited by kadiealexander Loading

Concierge reviewer checklist:

melvin-bot bot commented Dec 18, 2024

OSBotify commented Dec 18, 2024

CortneyOfstad commented Dec 18, 2024 • edited Loading

kadiealexander commented Dec 19, 2024

dangrous commented Dec 19, 2024

dangrous commented Dec 19, 2024

kadiealexander commented Dec 20, 2024

CortneyOfstad commented Dec 20, 2024

dangrous left a comment

Choose a reason for hiding this comment

dangrous commented Dec 20, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

kadiealexander commented Jan 6, 2025

dangrous commented Jan 8, 2025

CortneyOfstad commented Jan 8, 2025

dangrous commented Jan 8, 2025

kadiealexander commented Jan 9, 2025

CortneyOfstad commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 11, 2025

github-actions bot commented Jan 13, 2025

CortneyOfstad commented Dec 18, 2024 •

edited

Loading

melvin-bot bot commented Dec 18, 2024 •

edited by kadiealexander

Loading

CortneyOfstad commented Dec 18, 2024 •

edited

Loading

dangrous commented Dec 20, 2024 •

edited

Loading