feat: Add an "Invite" button to the workspace profile page #53719

Krishna2323 · 2024-12-06T19:31:20Z

Explanation of Change

Adds an invite button beside share button on workspace profile page.

Fixed Issues

$ #53716
PROPOSAL: #53716 (comment)

Tests

Go settings > workspaces > select a workspace where you are admin
On profile page verify there is a invite button beside share button
Click on the invite button > verify you are taken to invite members page and members page is loaded in the background

Verify that no errors appear in the JS console

Offline tests

Go settings > workspaces > select a workspace where you are admin
On profile page verify there is a invite button beside share button
Click on the invite button > verify you are taken to invite members page and members page is loaded in the background

QA Steps

Go settings > workspaces > select a workspace where you are admin
On profile page verify there is a invite button beside share button
Click on the invite button > verify you are taken to invite members page and members page is loaded in the background

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android_native.mp4

Android: mWeb Chrome

android_chrome.mp4

iOS: Native

ios_native.mp4

iOS: mWeb Safari

ios_safari.mp4

MacOS: Chrome / Safari

web_chrome.mp4

MacOS: Desktop

desktop_app.mp4

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

melvin-bot · 2024-12-06T19:31:26Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Krishna2323 · 2024-12-06T20:12:32Z

@allgandalf @neil-marcellini, while recoding the platform videos I found 2 issues that we might want to solve:

On small-width devices, when navigating to the invite page from the profile page, there is a flash that appears to be from the members page.
When going back twice from the invite page, the initial settings page is shown instead of the profile page.

Possible solution: We can add a param ?invite=true in workspace members page and instead of directly navigating to invite page, we can navigate to members page and on initial render we can check the param and it is true we will instantly navigate to invite page.

ios_native.mp4

android_native.mp4

neil-marcellini · 2024-12-09T20:07:43Z

@Krishna2323 I don't really see any problems in those two videos that seem worth fixing. I think the navigation makes sense.

neil-marcellini

Looks great, assuming C+ testing passes

allgandalf · 2024-12-11T12:18:57Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-12-15.at.8.51.01.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-12-15.at.8.52.48.PM.mov

iOS: Native

Screen.Recording.2024-12-15.at.8.40.45.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-12-15.at.8.41.17.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-12-15.at.8.37.34.PM.mov

MacOS: Desktop

Screen.Recording.2024-12-15.at.8.38.26.PM.mov

allgandalf · 2024-12-12T09:01:05Z

c.c. @Expensify/design as this is a new feature, can you take a look at the videos and give 👍 from design perspective , thanks

dannymcclain · 2024-12-12T14:23:53Z

Videos are looking good to me.

Regarding this:

On small-width devices, when navigating to the invite page from the profile page, there is a flash that appears to be from the members page.

I actually think this might be a good thing because it might be easy to feel "lost" once you click the invite button, so showing a snippet of where the invite page is coming from is potentially a good thing. 🤷‍♂️

shawnborton · 2024-12-12T15:18:53Z

Yup, agree with those comments from Danny above, looking good!

allgandalf · 2024-12-13T12:13:14Z

Thanks, completing the checklist now

allgandalf

LGTM!

dubielzyk-expensify · 2024-12-16T01:15:05Z

Happy to merge this, but seeing this now I actually think the RHP should fly out with the current page (Workspace profile) still underneath and only if you successfully add someone, land on members page highlighting the newly invited people.

The jump from Invite button press to Members page feels a bit disorienting to me.

Keen to hear @Expensify/design thoughts on that, but happy to move on still

shawnborton · 2024-12-16T14:16:00Z

I can totally see that Jon, happy to go with your recommendation as I can see where it might make things feel a bit more clear.

The original intention was to "teach someone how to fish" by taking them first to the Members page but after seeing it in action I think I agree, the quick jump to a different page feels unexpected for a button like this.

dannymcclain · 2024-12-16T14:21:04Z

Yep, I originally proposed exactly the flow you laid out for all the reasons that you mentioned, but others in the thread wanted to go the Members page route because of the "teach you to fish" idea that Shawn mentioned and because it was deemed as easier/faster to implement since the invite flow on the members page already exists.

TLDR: I'm very much for making the invite RHP open over the profile. We might want to check and see if the rest of the team is down with that change though.

neil-marcellini

Good to go. If we decide to change the UX later we can do that in a follow up.

shawnborton · 2024-12-16T20:04:51Z

Hmm why a follow up? This feature doesn't exist yet so if we're going to change it, I feel like it makes sense to do so before merging this.

neil-marcellini · 2024-12-16T20:20:40Z

Ok that's fine too. It wasn't clear to me that the comments from the design team were blocking. Heads up, I'm going to be OOO for the rest of the week. I'm sure if you post in engineering chat someone can help review after the fix.

dubielzyk-expensify · 2024-12-17T04:17:48Z

If all of @Expensify/design is aligned, I recon we go with the change then:

Click Invite button
Invite member panel opens in RHP with Workspace Profile underneath
If dismissed, RHP goes away
If successfully invited someone, auto-navigate/land on Members screen with the newly added member highlighted

allgandalf · 2024-12-17T06:23:29Z

Let us know if we decide on these changes, then @Krishna2323 can work on those accordingly

shawnborton · 2024-12-17T14:06:16Z

I say let's consider it decided - Jon has spoken - let's move forward with the changes 👍

dannymcclain · 2024-12-17T14:10:06Z

Agree. I think it's a much better experience that way.

allgandalf · 2024-12-18T06:28:11Z

all good!, @Krishna2323 do you have any doubts for this implementation ?

Krishna2323 · 2024-12-18T07:09:56Z

No doubts about the expected result, will work on that today.

Krishna2323 · 2024-12-18T09:03:13Z

@allgandalf, implementing the new behaviour will have the issue as this one, we would need to remove the mapping from SCREENS.WORKSPACE.MEMBERS and it will work as expected, the only issue we will face is that on refresh the central pane will be changed to default and copy pasting the link will also open the invite page with default central pane.

One solution can be: we can create separate screens for that and use the same components.

App/src/libs/Navigation/linkingConfig/FULL_SCREEN_TO_RHP_MAPPING.ts

Lines 13 to 15 in b6ebedb

    
           [SCREENS.WORKSPACE.MEMBERS]: [ 
        
               SCREENS.WORKSPACE.INVITE, 
        
               SCREENS.WORKSPACE.INVITE_MESSAGE,

allgandalf · 2024-12-19T05:24:02Z

One solution can be: we can create separate screens for that and use the same components.

Not sure if I am onboard with this one, give me a day i will ask on #quality and get back

allgandalf · 2024-12-19T05:30:12Z

Asked here

adamgrzybowski · 2024-12-19T11:25:11Z

@allgandalf If you want to have different screens under the overlay depending on context (e.g. the way the user gets there) you should use the backTo param. It has higher priority than the values hardcoded in mappings for filling the missing screen under RHP.

allgandalf · 2024-12-19T16:28:10Z

@Krishna2323 please update the PR accordingly

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

allgandalf · 2024-12-23T05:29:23Z

@Krishna2323 please fix the failing tests

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 · 2024-12-23T10:28:03Z

@Expensify/design, does this look correct?

Monosnap.screencast.2024-12-23.15-55-53.mp4

allgandalf · 2024-12-24T06:40:44Z

I assume most of the team is out 📆

shawnborton · 2024-12-24T15:23:57Z

That looks pretty good to me!

neil-marcellini

Looks good to me

OSBotify · 2024-12-24T21:21:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-12-26T20:54:43Z

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.0.79-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

izarutskaya · 2024-12-27T10:05:16Z

@Krishna2323 QA found issue when validation this PR - issue #54489

https://platform.applause.com/services/links/v1/external/af81e41beab72cb3ac2216bd2ea47a01f439ae0abd4dd7e1415dff60653f72f9

github-actions · 2024-12-31T21:52:02Z

🚀 Deployed to production by https://github.com/puneetlath in version: 9.0.79-5 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	success ✅

parasharrajat · 2025-01-19T11:48:17Z

src/pages/workspace/WorkspaceProfilePage.tsx

+                                    <Button
+                                        accessibilityLabel={translate('common.invite')}
+                                        text={translate('common.invite')}
+                                        onPress={() => Navigation.navigate(ROUTES.WORKSPACE_INVITE.getRoute(route.params.policyID, Navigation.getActiveRouteWithoutParams()))}


We didn't clear the draft while reopening the page which caused the previous selection to stay. #54604

Krishna2323 added 3 commits December 7, 2024 00:53

fix: Add an Invite button to the workspace profile page.

e418c04

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Merge branch 'Expensify:main' into krishna2323/issue/53716

9d9025d

remove redundant spacing.

deae955

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 requested a review from a team as a code owner December 6, 2024 19:31

melvin-bot bot requested review from allgandalf and removed request for a team December 6, 2024 19:31

Krishna2323 changed the title ~~Krishna2323/issue/53716~~ feat: Add an "Invite" button to the workspace profile page Dec 6, 2024

neil-marcellini approved these changes Dec 9, 2024

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/53716

ee4deae

allgandalf approved these changes Dec 15, 2024

View reviewed changes

melvin-bot bot requested a review from neil-marcellini December 15, 2024 15:24

allgandalf approved these changes Dec 15, 2024

View reviewed changes

neil-marcellini previously approved these changes Dec 16, 2024

View reviewed changes

Merge branch 'Expensify:main' into krishna2323/issue/53716

dac01c7

Krishna2323 added 2 commits December 21, 2024 16:01

Merge branch 'Expensify:main' into krishna2323/issue/53716

4f487ef

add backTo param in WorkspaceInvitePage & WorkspaceInviteMessagePage.

b072946

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

Krishna2323 dismissed neil-marcellini’s stale review via b072946 December 21, 2024 10:53

fix animation and eslint.

1a7a15a

Signed-off-by: krishna2323 <belivethatkg@gmail.com>

neil-marcellini approved these changes Dec 24, 2024

View reviewed changes

neil-marcellini merged commit 5c750c5 into Expensify:main Dec 24, 2024
16 checks passed

github-actions bot mentioned this pull request Dec 26, 2024

Deploy Checklist: New Expensify 2024-12-26 #54591

Closed

42 tasks

melvin-bot bot mentioned this pull request Dec 31, 2024

[HOLD for payment 2025-01-07] [$250] Add an "Invite" button to the workspace profile page #53716

Closed

parasharrajat reviewed Jan 19, 2025

View reviewed changes

feat: Add an "Invite" button to the workspace profile page #53719

feat: Add an "Invite" button to the workspace profile page #53719

Conversation

Krishna2323 commented Dec 6, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Dec 6, 2024

Krishna2323 commented Dec 6, 2024

neil-marcellini commented Dec 9, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

allgandalf commented Dec 11, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf commented Dec 12, 2024

dannymcclain commented Dec 12, 2024

shawnborton commented Dec 12, 2024

allgandalf commented Dec 13, 2024

allgandalf left a comment

Choose a reason for hiding this comment

dubielzyk-expensify commented Dec 16, 2024

shawnborton commented Dec 16, 2024

dannymcclain commented Dec 16, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

shawnborton commented Dec 16, 2024

neil-marcellini commented Dec 16, 2024

dubielzyk-expensify commented Dec 17, 2024

allgandalf commented Dec 17, 2024

shawnborton commented Dec 17, 2024

dannymcclain commented Dec 17, 2024

allgandalf commented Dec 18, 2024

Krishna2323 commented Dec 18, 2024

Krishna2323 commented Dec 18, 2024

allgandalf commented Dec 19, 2024

allgandalf commented Dec 19, 2024

adamgrzybowski commented Dec 19, 2024

allgandalf commented Dec 19, 2024

allgandalf commented Dec 23, 2024

Krishna2323 commented Dec 23, 2024

allgandalf commented Dec 24, 2024 • edited Loading

shawnborton commented Dec 24, 2024

neil-marcellini left a comment

Choose a reason for hiding this comment

OSBotify commented Dec 24, 2024

github-actions bot commented Dec 26, 2024

izarutskaya commented Dec 27, 2024

github-actions bot commented Dec 31, 2024

parasharrajat Jan 19, 2025

Choose a reason for hiding this comment

Krishna2323 commented Dec 6, 2024 •

edited

Loading

allgandalf commented Dec 11, 2024 •

edited

Loading

allgandalf commented Dec 24, 2024 •

edited

Loading