fix: no jumpy input in amount filter #53695

kirillzyusko · 2024-12-06T10:52:42Z

Explanation of Change

Added react-native-advanced-input-mask that based on "mask" concept (instead of imperative formatting) and performs formatting in a native thread, so as a result it's flicker/jumpy-free, brings native performance, doesn't produce delays and other unpleasant UI issues 😊

Staring from now TextInput can be implemented via 3 implementations:

default from react-native;
markdown from react-native-live-markdown;
mask from react-native-advanced-input-mask

So to manage which implementation from listed above should be used I added a new property type that switches between implementations.

Fixed Issues

$ #47875
PROPOSAL: #47875 (comment)

Tests

go to Reports
press "criteria" button;
go to Total;
enter Greater than/Less than fields;
after entering two digits after comma/dot try to continue to enter symbols
make sure subsequently entered characters (after two symbols after comma) do not get entered and instantly removed after that

Offline tests

N/A

QA Steps

go to Reports
press "criteria" button;
go to Total;
enter Greater than/Less than fields;
after entering two digits after comma/dot try to continue to enter symbols
make sure subsequently entered characters (after two symbols after comma) do not get entered and instantly removed after that

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-01-20.at.14.52.55.mov

Android: mWeb Chrome

iOS: Native

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-01-20.at.14.54.38.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-01-20.at.15.32.07.mov

MacOS: Desktop

melvin-bot · 2025-01-20T13:54:19Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-01-20T14:26:40Z

@brunovjk Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

kirillzyusko · 2025-01-20T14:31:44Z

All yours @brunovjk 🙌

brunovjk · 2025-01-20T18:04:23Z

BUG: When we type a letter, a dot . appears instead of nothing happening.

Screen.Recording.2025-01-20.at.15.01.03.mov

Can you reproduce @kirillzyusko? Thanks.

kirillzyusko · 2025-01-20T18:12:27Z

When we type a letter, a dot . appears instead of nothing happening.

It happens because all symbols (except numeric values) are considered as a float separator (and thus they are replaced with .). Using phone keyboard I highly doubt it will be possible to enter anything else except 01234567890.,symbols. Am I right? If yes, then should we really focus on solving this problem?..

brunovjk · 2025-01-21T14:55:19Z

Good question, thanks @kirillzyusko. I believe that in general it would be interesting to explore solutions to this issue, but I say this without knowing how complex it might be. What do you think @luacmartins?

luacmartins · 2025-01-21T16:48:22Z

Can we just skip adding anything when we type letters? I think we should only allow 0-9., as input

kirillzyusko · 2025-01-22T11:25:09Z

Can we just skip adding anything when we type letters? I think we should only allow 0-9., as input

@brunovjk @luacmartins Fixed in f888cd9

Would you mind to do another round of review?

brunovjk · 2025-01-22T11:49:20Z

Sure :D Thanks for the update, I'll review it later today.

brunovjk · 2025-01-22T16:24:25Z

@kirillzyusko, I can still reproduce it:

Screen.Recording.2025-01-22.at.13.20.15.mov

What about you? After your changes it shouldn't be possible to use letters, strange.

kirillzyusko · 2025-01-22T16:38:24Z

@brunovjk did you reinstall deps? I updated a library, so you have to re-install node_modules/pods

brunovjk · 2025-01-22T16:51:59Z

@brunovjk did you reinstall deps? I updated a library, so you have to re-install node_modules/pods

Yes, I did. I will do it again. :D

kirillzyusko · 2025-01-22T17:07:32Z

Yes, I did. I will do it again. :D

Very strange 😬 Did you re-assemble app after that? I was definitely testing all three platforms and everything was working fine - alphabetical input was simply ignored 🤔

brunovjk · 2025-01-22T21:44:54Z

Yes, I did. I will do it again. :D

Very strange 😬 Did you re-assemble app after that? I was definitely testing all three platforms and everything was working fine - alphabetical input was simply ignored 🤔

I was probably doing something wrong, I cleaned everything again and it worked like a charm.

brunovjk · 2025-01-22T21:45:14Z

It’s looking good!! Great work, @kirillzyusko! 🎉 I’ll need a bit more time to review the changes in-depth and test other areas of the app that might be impacted. Would it be possible to add some unit tests?

@luacmartins, do you think we should assign QA to test this later? Thanks in advance! 🙌

Screenshots/Videos

Android: Native

53695_android_native.mov

Android: mWeb Chrome

53695_android_web.mov

iOS: Native

53695_ios_native.mov

iOS: mWeb Safari

53695_ios_web.mov

MacOS: Chrome / Safari

53695_web_chrome.mov

MacOS: Desktop

53695_web_desktop.mov

kirillzyusko · 2025-01-23T11:57:13Z

src/pages/tasks/NewTaskDetailsPage.tsx

-                task.assigneeAccountID,
-                task.assigneeChatReport,
-            );
+            createTaskAndNavigate(task?.parentReportID ?? '-1', values.taskTitle, values.taskDescription ?? '', task?.assignee ?? '', task.assigneeAccountID, task.assigneeChatReport);


One thing that I can not resolve without breaking changes 😔 Any help is appreciated 🙏

I believe we can just remove the fallbacks here since they are all strings. Have you tried that?

@brunovjk We can't, because createTaskAndNavigate expects parentReportID as string. And we can not make it optional, because subsequent arguments are mandatory. We also can't specify default it, because it's number and we expect a string 🤔

kirillzyusko · 2025-01-23T12:02:36Z

Would it be possible to add some unit tests?

Yeah, I would love to add them. But the problem here is that we moved all logic from JS to a native component. So js unit-tests can be only snapshot tests (and I don't know whether it makes sense to have such tests)?

brunovjk · 2025-01-23T12:08:29Z

@kirillzyusko, I found a bug, I think, I haven't gone deep into the changes yet. But it's not "saving":

Android: Native - main

main.mov

Android: Native - our PR

PR_53695.mov

kirillzyusko · 2025-01-23T12:31:24Z

I found a bug, I think, I haven't gone deep into the changes yet. But it's not "saving":

@brunovjk Fixed in 81edc2c 🙈

brunovjk · 2025-01-23T12:33:53Z

Thank you @kirillzyusko. I'm working on another PR now, I will get back here later today 🚀

kirillzyusko · 2025-01-31T15:34:24Z

What do you think? It makes sense ? I didn't have time to look where else we needed to, @kirillzyusko can you do that for us? Thanks a lot!!!

I would love to do that, but in a different PR. My main concern is that if the PR will be reverted, then only a small part of changes will be reverted. If I implement all changes in a single PR which will be reverted/added again it'll be slightly a nightmare to manage all that things 🤔

Does it make sense to merge this PR and handle other input in a different PR?

brunovjk · 2025-01-31T15:37:13Z

I see your point, it makes sense, thanks. What do you think @luacmartins?

luacmartins · 2025-01-31T17:47:28Z

Agreed! Let's keep the changes self-contained for now and if no regressions are detected we move on to updating the other amount inputs

brunovjk · 2025-01-31T17:58:52Z

Great! @kirillzyusko can you resolve the conflicts? I'll do a quick review and let you know luacmartins

kirillzyusko · 2025-01-31T19:21:54Z

can you resolve the conflicts

Resolved! 😎

brunovjk · 2025-01-31T19:54:26Z

Can we fix these errors @kirillzyusko? Let me know of anything.

kirillzyusko · 2025-02-03T10:18:16Z

@brunovjk it fails because of this:

/home/runner/work/App/App/src/pages/tasks/NewTaskDetailsPage.tsx
Error: 79:55 error Do not default string IDs to any value. See: https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#default-value-for-inexistent-IDs rulesdir/no-default-id-values

And honestly I don't have any ideas how to fix this problem (without breaking changes or re-working a lot of code) 🤷‍♂️ Can we skip this error?

brunovjk · 2025-02-03T10:37:07Z

@brunovjk it fails because of this:

/home/runner/work/App/App/src/pages/tasks/NewTaskDetailsPage.tsx
Error: 79:55 error Do not default string IDs to any value. See: https://github.com/Expensify/App/blob/main/contributingGuides/STYLE.md#default-value-for-inexistent-IDs rulesdir/no-default-id-values

And honestly I don't have any ideas how to fix this problem (without breaking changes or re-working a lot of code) 🤷‍♂️ Can we skip this error?

Very good, let me do some tests here and let you know in a moment.

brunovjk · 2025-02-03T12:31:00Z

@luacmartins I tested everything again and it looks good. Can you help us with these errors? Thank you very much.

luacmartins · 2025-02-03T18:15:34Z

@brunovjk I think we can ignore the ESLint checks since they are unrelated to this PR. Same for the HybridApp build, because it fails with Input required and not supplied: token.

Could you complete the reviewer checklist though?

luacmartins

LGTM

brunovjk · 2025-02-03T18:24:13Z

oops, my bad, I thought I had already done it. I'll do it now.

brunovjk · 2025-02-03T18:40:36Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

53695_android_native.mov

Android: mWeb Chrome

53695_android_web.mov

iOS: Native

53695_ios_native.mov

iOS: mWeb Safari

53695_ios_web.mov

MacOS: Chrome / Safari

53695_web_chrome.mov

MacOS: Desktop

53695_web_desktop.mov

brunovjk · 2025-02-03T18:41:45Z

Could you complete the reviewer checklist though?

Done @luacmartins :D sorry about that.

luacmartins · 2025-02-03T19:11:28Z

Gonna merge with the failing ESLint and HybridApp build failing. See comment here

melvin-bot · 2025-02-03T19:11:37Z

@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

github-actions · 2025-02-03T23:33:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.0.94-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-02-06T21:56:09Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

github-actions · 2025-02-06T22:38:00Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.0.94-25 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

kirillzyusko mentioned this pull request Dec 6, 2024

[$500] [POLISH][Search v2.1] Amount filter - Native - The digit exceeding the max allowed decimal places is briefly inserted into the input #47875

Closed

kirillzyusko force-pushed the feat/masked-input branch from dbe6e87 to 0f475b6 Compare January 15, 2025 19:04

kirillzyusko changed the title ~~poc: masked input~~ fix: no jumpy input in amount filter Jan 20, 2025

kirillzyusko marked this pull request as ready for review January 20, 2025 14:26

kirillzyusko requested a review from a team as a code owner January 20, 2025 14:26

melvin-bot bot requested a review from brunovjk January 20, 2025 14:26

melvin-bot bot removed the request for review from a team January 20, 2025 14:26

kirillzyusko force-pushed the feat/masked-input branch from c9a2ae6 to 7049525 Compare January 20, 2025 14:30

luacmartins self-requested a review January 20, 2025 16:40

kirillzyusko force-pushed the feat/masked-input branch from 39ad7e7 to f888cd9 Compare January 22, 2025 11:23

kirillzyusko commented Jan 23, 2025

View reviewed changes

Merge branch 'main' into feat/masked-input

588d110

fix: ts

e935679

Merge branch 'main' into feat/masked-input

b2a30b8

brunovjk approved these changes Feb 3, 2025

View reviewed changes

luacmartins approved these changes Feb 3, 2025

View reviewed changes

luacmartins merged commit d31566b into Expensify:main Feb 3, 2025
16 of 21 checks passed

melvin-bot bot added the Emergency label Feb 3, 2025

luacmartins removed the Emergency label Feb 3, 2025

luacmartins assigned kirillzyusko Feb 3, 2025

github-actions bot mentioned this pull request Feb 3, 2025

Deploy Checklist: New Expensify 2025-02-03 #56280

Closed

95 tasks

fix: no jumpy input in amount filter #53695

fix: no jumpy input in amount filter #53695

Conversation

kirillzyusko commented Dec 6, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jan 20, 2025

melvin-bot bot commented Jan 20, 2025

kirillzyusko commented Jan 20, 2025

brunovjk commented Jan 20, 2025

kirillzyusko commented Jan 20, 2025

brunovjk commented Jan 21, 2025

luacmartins commented Jan 21, 2025

kirillzyusko commented Jan 22, 2025

brunovjk commented Jan 22, 2025

brunovjk commented Jan 22, 2025

kirillzyusko commented Jan 22, 2025

brunovjk commented Jan 22, 2025

kirillzyusko commented Jan 22, 2025

brunovjk commented Jan 22, 2025

brunovjk commented Jan 22, 2025 • edited Loading

Screenshots/Videos

kirillzyusko Jan 23, 2025

Choose a reason for hiding this comment

brunovjk Jan 24, 2025

Choose a reason for hiding this comment

kirillzyusko Jan 24, 2025

Choose a reason for hiding this comment

kirillzyusko commented Jan 23, 2025

brunovjk commented Jan 23, 2025

kirillzyusko commented Jan 23, 2025

brunovjk commented Jan 23, 2025

kirillzyusko commented Jan 31, 2025

brunovjk commented Jan 31, 2025

luacmartins commented Jan 31, 2025

brunovjk commented Jan 31, 2025

kirillzyusko commented Jan 31, 2025

brunovjk commented Jan 31, 2025

kirillzyusko commented Feb 3, 2025

brunovjk commented Feb 3, 2025

brunovjk commented Feb 3, 2025

luacmartins commented Feb 3, 2025

luacmartins left a comment

Choose a reason for hiding this comment

brunovjk commented Feb 3, 2025

brunovjk commented Feb 3, 2025

Reviewer Checklist

Screenshots/Videos

brunovjk commented Feb 3, 2025

luacmartins commented Feb 3, 2025

melvin-bot bot commented Feb 3, 2025

github-actions bot commented Feb 3, 2025

github-actions bot commented Feb 6, 2025

github-actions bot commented Feb 6, 2025

kirillzyusko commented Dec 6, 2024 •

edited

Loading

brunovjk commented Jan 22, 2025 •

edited

Loading