[CP Staging] fix learn more link if no workspace #53255

nkdengineer · 2024-11-28T16:07:15Z

Explanation of Change

fix learn more link if no workspace

Fixed Issues

$ #53247
PROPOSAL:

Tests

Sign in as a new account
Complete onboarding without any new workspace and don't create any new workspace
Create a track expense
Categorize it
On the upgrade page, click on Learn more link
Verify that a help page is opened in a new tag

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Sign in as a new account
Complete onboarding without any new workspace and don't create any new workspace
Create a track expense
Categorize it
On the upgrade page, click on Learn more link
Verify that a help page is opened in a new tag

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-11-28.at.23.33.08.mov

Android: mWeb Chrome

Screen.Recording.2024-11-28.at.23.29.05.mov

iOS: Native

Screen.Recording.2024-11-28.at.23.35.25.mov

iOS: mWeb Safari

Screen.Recording.2024-11-28.at.22.57.08.mov

MacOS: Chrome / Safari

Screen.Recording.2024-11-28.at.22.55.42.mov

MacOS: Desktop

Screen.Recording.2024-11-28.at.23.37.36.mov

melvin-bot · 2024-11-28T16:47:55Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2024-11-28T17:27:43Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

LGTM.

fix learn more link if no workspace (cherry picked from commit 41f9122) (CP triggered by mountiny)

github-actions · 2024-11-28T20:14:23Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.68-2 🚀

platform	result
🤖 android 🤖	false ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

izarutskaya · 2024-11-29T10:24:29Z

Failing on all platforms with #53247

https://platform.applause.com/services/links/v1/external/8f5afd44abfd6bc3edbb3159cffd58d2577e9b4a3e39a0490099a234b547f3c8

mjasikowski · 2024-11-29T11:00:45Z

@izarutskaya we need to CP #53280 to make this work again, I'll tag you in the issue when that's done

mjasikowski · 2024-11-29T11:18:27Z

@izarutskaya the fix is now on staging, could you please re-test?

izarutskaya · 2024-11-29T13:28:18Z

@mjasikowski PR is passed. Works good now.

github-actions · 2024-11-30T13:53:50Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.0.68-7 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

nkdengineer added 2 commits November 28, 2024 23:03

fix learn more link if no workspace

efea5b6

return early

6ada95b

nkdengineer marked this pull request as ready for review November 28, 2024 16:47

nkdengineer requested a review from a team as a code owner November 28, 2024 16:47

melvin-bot bot requested review from Ollyws and removed request for a team November 28, 2024 16:47

Ollyws approved these changes Nov 28, 2024

View reviewed changes

melvin-bot bot requested a review from mjasikowski November 28, 2024 17:30

mjasikowski approved these changes Nov 28, 2024

View reviewed changes

mjasikowski merged commit 41f9122 into Expensify:main Nov 28, 2024
18 checks passed

mjasikowski changed the title ~~fix learn more link if no workspace~~ [CP Staging] fix learn more link if no workspace Nov 28, 2024

This was referenced Nov 28, 2024

Investigate workflow job failing on main: typecheck / typecheck #53269

Closed

Investigate workflow job failing on main: lint / ESLint check #53270

Closed

Investigate workflow job failing on main: confirmPassingBuild #53271

Closed

OSBotify pushed a commit that referenced this pull request Nov 28, 2024

Merge pull request #53255 from nkdengineer/fix/53247

18ad3d4

fix learn more link if no workspace (cherry picked from commit 41f9122) (CP triggered by mountiny)

github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Nov 28, 2024

github-actions bot mentioned this pull request Nov 28, 2024

Deploy Checklist: New Expensify 2024-11-28 #53245

Closed

72 tasks

melvin-bot bot mentioned this pull request Nov 30, 2024

[HOLD for payment 2024-12-09] [HOLD for payment 2024-12-07] Track expense - App opens not here page from Learn more link in upgrade modal #53247

Closed

8 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CP Staging] fix learn more link if no workspace #53255

[CP Staging] fix learn more link if no workspace #53255

nkdengineer commented Nov 28, 2024 •

edited

Loading

melvin-bot bot commented Nov 28, 2024

Ollyws commented Nov 28, 2024

Ollyws left a comment

github-actions bot commented Nov 28, 2024

izarutskaya commented Nov 29, 2024

mjasikowski commented Nov 29, 2024 •

edited

Loading

mjasikowski commented Nov 29, 2024

izarutskaya commented Nov 29, 2024

github-actions bot commented Nov 30, 2024

[CP Staging] fix learn more link if no workspace #53255

[CP Staging] fix learn more link if no workspace #53255

Conversation

nkdengineer commented Nov 28, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Nov 28, 2024

Ollyws commented Nov 28, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

github-actions bot commented Nov 28, 2024

izarutskaya commented Nov 29, 2024

mjasikowski commented Nov 29, 2024 • edited Loading

mjasikowski commented Nov 29, 2024

izarutskaya commented Nov 29, 2024

github-actions bot commented Nov 30, 2024

nkdengineer commented Nov 28, 2024 •

edited

Loading

mjasikowski commented Nov 29, 2024 •

edited

Loading