Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging] Fix not found view when linking to a message #53064

Merged
merged 3 commits into from
Nov 25, 2024
Merged

[CP Staging] Fix not found view when linking to a message #53064

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
389f3a6
fix not found view when linking to message
bernhardoj Nov 25, 2024
dde388b
clear isOptimisticReport when created successfully
bernhardoj Nov 25, 2024
095deaf
set isOptimisticReport to false when success in more palces
bernhardoj Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libs/actions/Policy/Policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2311,6 +2311,7 @@ function createWorkspaceFromIOUPayment(iouReport: OnyxEntry<Report>): WorkspaceF
addWorkspaceRoom: null,
},
pendingAction: null,
isOptimisticReport: false,
},
},
{
Expand All @@ -2330,6 +2331,7 @@ function createWorkspaceFromIOUPayment(iouReport: OnyxEntry<Report>): WorkspaceF
addWorkspaceRoom: null,
},
pendingAction: null,
isOptimisticReport: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another place where we don't set the isOptimisticReport to false.

},
},
{
Expand Down
2 changes: 1 addition & 1 deletion src/pages/home/ReportScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ function ReportScreen({route, currentReportID = '', navigation}: ReportScreenPro
// This function is triggered when a user clicks on a link to navigate to a report.
// For each link click, we retrieve the report data again, even though it may already be cached.
// There should be only one openReport execution per page start or navigating
fetchReportIfNeeded();
fetchReport();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernhardoj @hoangzinh why this change?

// eslint-disable-next-line react-compiler/react-compiler, react-hooks/exhaustive-deps
}, [route, isLinkedMessagePageReady, isLoadingReportOnyx, reportActionIDFromRoute]);

Expand Down
Loading