[NO QA] New article: Create Connect-to-QuickBooks-Desktop.md #52986

sakluger · 2024-11-22T22:14:57Z

This is the new Connect to QuickBooks Desktop article for NewDot.

Removing the hold so we can get this live, but there's still one image missing from each of the two articles:

Connect to QuickBooks Desktop: We need an image of the codat link in Expensify for step 8. Here is the screen from figma: https://www.figma.com/design/E2lt5o4nXHjlDcepaOjg2D/QuickBooks-Desktop?node-id=9675-22706&t=6tNcRJrQoav8Xyan-4
QuickBooks Desktop Troubleshooting: We need an image of a successful export at the bottom of the doc. Here is the screen in figma: https://www.figma.com/design/E2lt5o4nXHjlDcepaOjg2D/QuickBooks-Desktop?node-id=9341-13915&t=6tNcRJrQoav8Xyan-4

Explanation of Change

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/409956

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

This is the new Connect to QuickBooks Desktop article for NewDot. It's missing one image, so we can't merge it yet.

OSBotify · 2024-11-22T22:17:34Z

A preview of your ExpensifyHelp changes have been deployed to https://8d550754.helpdot.pages.dev ⚡️

melvin-bot · 2025-02-20T20:12:58Z

melvin-bot · 2025-02-20T20:13:00Z

@rushatgabhane @joekaufmanexpensify One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sakluger · 2025-02-20T20:16:06Z

Weird, the new articles aren't showing up on the preview (#52986 (comment)) 🤔

joekaufmanexpensify · 2025-02-21T15:12:57Z

Interesting. Yeah, I don't see them either. Maybe re-running the checks suite (which I think includes deploying the preview) might help? Anyways, let me know once this is ready for concierge review and happy to do that!

sakluger · 2025-02-25T18:15:24Z

@maddylewis noticed that the issue was in draft status. I pressed "Ready to review", we'll see if that helps!

rushatgabhane · 2025-02-25T20:34:02Z

we need to create a new quickbooks-desktop.html file inside docs/new-expensify/hubs/connections/.

you can copy the contents from quickbooks-online.html

maddylewis · 2025-02-25T21:01:49Z

ok so @joekaufmanexpensify needs to fill out the Concierge Review checklist here - #52986 (comment) (once its ready for review).

this shouldn't be assigned to a C+ but looks like @rushatgabhane is helping out here so we'll keep his assignment.

this will need to be merged by an internal engineer for it to be published live.

joekaufmanexpensify · 2025-02-25T21:13:40Z

ok so @joekaufmanexpensify needs to fill out the Concierge Review checklist here - #52986 (comment) (once its ready for review).

Yep, I am waiting for the preview. Right now it doesn't work to view the new article. I see we need to create the new article file for this to work. I will monitor the progress here and review the article once the preview is up.

2025-02-25_16-11-11.mp4

sakluger · 2025-03-01T00:29:39Z

I created the new /quickbooks-desktop.html hub page. Waiting for the new dev preview to generate.

rushatgabhane · 2025-03-01T00:33:23Z

https://8d550754.helpdot.pages.dev/

sakluger · 2025-03-01T00:33:39Z

It's working! 🎉

@joekaufmanexpensify please take a look at https://8d550754.helpdot.pages.dev/ for the preview.

sakluger · 2025-03-01T00:34:16Z

@rushatgabhane is too fast for me 😂

joekaufmanexpensify

Reviewed the previews, and looks great!

melvin-bot · 2025-03-04T21:45:56Z

melvin-bot · 2025-03-04T21:45:57Z

@ntdiary @ @CortneyOfstad One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sakluger · 2025-03-04T21:46:09Z

Added pullerbear to get an internal engineer who can merge this.

sakluger · 2025-03-04T22:34:08Z

Okay weird, it added Cortney and another C+, but no internal engineer.

rushatgabhane

to assign internal

melvin-bot · 2025-03-04T23:53:56Z

melvin-bot · 2025-03-04T23:53:58Z

@cristipaval @stephanieelliott One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-03-04T23:54:01Z

🎯 @rushatgabhane, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #57804.

cristipaval · 2025-03-05T11:42:16Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

github-actions · 2025-03-06T23:14:16Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.1.10-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	success ✅
🍎🔄 iOS HybridApp 🍎🔄	success ✅

github-actions · 2025-03-10T21:09:49Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.1.10-6 🚀

platform	result
🤖 android 🤖	true ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅
🤖🔄 android HybridApp 🤖🔄	failure ❌
🍎🔄 iOS HybridApp 🍎🔄	failure ❌

New article: Create Connect-to-QuickBooks-Desktop.md

38a15dd

This is the new Connect to QuickBooks Desktop article for NewDot. It's missing one image, so we can't merge it yet.

sakluger self-assigned this Nov 22, 2024

Create new QuickBooks-Desktop-Troubleshooting article

a3b427e

sakluger changed the title ~~[HOLD] New article: Create Connect-to-QuickBooks-Desktop.md~~ New article: Create Connect-to-QuickBooks-Desktop.md Feb 20, 2025

sakluger changed the title ~~New article: Create Connect-to-QuickBooks-Desktop.md~~ [HOLD] New article: Create Connect-to-QuickBooks-Desktop.md Feb 20, 2025

sakluger added 2 commits February 20, 2025 11:57

Update Connect-to-QuickBooks-Desktop.md

1137f0e

Update QuickBooks-Desktop-Troubleshooting.md

b7952b1

sakluger requested a review from a team February 20, 2025 20:12

melvin-bot bot requested review from joekaufmanexpensify and rushatgabhane February 20, 2025 20:12

melvin-bot bot removed the request for review from a team February 20, 2025 20:13

sakluger changed the title ~~[HOLD] New article: Create Connect-to-QuickBooks-Desktop.md~~ [NO QA] New article: Create Connect-to-QuickBooks-Desktop.md Feb 20, 2025

sakluger marked this pull request as ready for review February 25, 2025 18:14

sakluger requested a review from a team as a code owner February 25, 2025 18:14

melvin-bot bot requested review from maddylewis and ZhenjaHorbach February 25, 2025 18:14

This comment was marked as off-topic.

Sign in to view

melvin-bot bot removed the request for review from a team February 25, 2025 18:14

maddylewis removed request for maddylewis and ZhenjaHorbach February 25, 2025 21:01

Expensify deleted a comment from melvin-bot bot Feb 25, 2025

joekaufmanexpensify approved these changes Mar 3, 2025

View reviewed changes

sakluger requested a review from a team March 4, 2025 21:45

melvin-bot bot requested review from CortneyOfstad and ntdiary March 4, 2025 21:45

melvin-bot bot removed the request for review from a team March 4, 2025 21:45

sakluger removed request for CortneyOfstad and ntdiary March 4, 2025 22:33

rushatgabhane approved these changes Mar 4, 2025

View reviewed changes

melvin-bot bot requested review from cristipaval and stephanieelliott March 4, 2025 23:53

melvin-bot bot mentioned this pull request Mar 4, 2025

Payment issue for E/App PR#52986 #57804

Closed

sakluger removed the request for review from stephanieelliott March 4, 2025 23:55

cristipaval approved these changes Mar 5, 2025

View reviewed changes

cristipaval merged commit 27fafd0 into main Mar 5, 2025
9 of 11 checks passed

cristipaval deleted the sakluger-patch-1 branch March 5, 2025 11:44

github-actions bot mentioned this pull request Mar 6, 2025

Deploy Checklist: New Expensify 2025-03-06 #57963

Closed

93 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NO QA] New article: Create Connect-to-QuickBooks-Desktop.md #52986

[NO QA] New article: Create Connect-to-QuickBooks-Desktop.md #52986

sakluger commented Nov 22, 2024 •

edited

Loading

OSBotify commented Nov 22, 2024 •

edited

Loading

melvin-bot bot commented Feb 20, 2025 •

edited by joekaufmanexpensify

Loading

melvin-bot bot commented Feb 20, 2025

sakluger commented Feb 20, 2025

joekaufmanexpensify commented Feb 21, 2025

This comment was marked as off-topic.

sakluger commented Feb 25, 2025

rushatgabhane commented Feb 25, 2025

maddylewis commented Feb 25, 2025 •

edited

Loading

joekaufmanexpensify commented Feb 25, 2025

sakluger commented Mar 1, 2025

rushatgabhane commented Mar 1, 2025

sakluger commented Mar 1, 2025

sakluger commented Mar 1, 2025

joekaufmanexpensify left a comment

melvin-bot bot commented Mar 4, 2025

melvin-bot bot commented Mar 4, 2025

sakluger commented Mar 4, 2025

sakluger commented Mar 4, 2025

rushatgabhane left a comment

melvin-bot bot commented Mar 4, 2025

melvin-bot bot commented Mar 4, 2025

melvin-bot bot commented Mar 4, 2025

cristipaval commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 6, 2025

github-actions bot commented Mar 10, 2025

[NO QA] New article: Create Connect-to-QuickBooks-Desktop.md #52986

[NO QA] New article: Create Connect-to-QuickBooks-Desktop.md #52986

Conversation

sakluger commented Nov 22, 2024 • edited Loading

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

OSBotify commented Nov 22, 2024 • edited Loading

melvin-bot bot commented Feb 20, 2025 • edited by joekaufmanexpensify Loading

Concierge reviewer checklist:

melvin-bot bot commented Feb 20, 2025

sakluger commented Feb 20, 2025

joekaufmanexpensify commented Feb 21, 2025

This comment was marked as off-topic.

sakluger commented Feb 25, 2025

rushatgabhane commented Feb 25, 2025

maddylewis commented Feb 25, 2025 • edited Loading

joekaufmanexpensify commented Feb 25, 2025

sakluger commented Mar 1, 2025

rushatgabhane commented Mar 1, 2025

sakluger commented Mar 1, 2025

sakluger commented Mar 1, 2025

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 4, 2025

Concierge reviewer checklist:

melvin-bot bot commented Mar 4, 2025

sakluger commented Mar 4, 2025

sakluger commented Mar 4, 2025

rushatgabhane left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 4, 2025

Concierge reviewer checklist:

melvin-bot bot commented Mar 4, 2025

melvin-bot bot commented Mar 4, 2025

cristipaval commented Mar 5, 2025 • edited Loading

Reviewer Checklist

Screenshots/Videos

github-actions bot commented Mar 6, 2025

github-actions bot commented Mar 10, 2025

sakluger commented Nov 22, 2024 •

edited

Loading

OSBotify commented Nov 22, 2024 •

edited

Loading

melvin-bot bot commented Feb 20, 2025 •

edited by joekaufmanexpensify

Loading

maddylewis commented Feb 25, 2025 •

edited

Loading

cristipaval commented Mar 5, 2025 •

edited

Loading