Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal QA]: Add amex custom feed new option #52890

Merged
merged 2 commits into from
Nov 21, 2024
Merged

[Internal QA]: Add amex custom feed new option #52890

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
546a4fb
Add amex custom feed new option
narefyev91 Nov 20, 2024
a5f1064
Update src/languages/es.ts
narefyev91 Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/CONST.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2815,6 +2815,7 @@ const CONST = {
AMEX_CUSTOM_FEED: {
CORPORATE: 'American Express Corporate Cards',
BUSINESS: 'American Express Business Cards',
PERSONAL: 'American Express Personal Cards',
},
DELETE_TRANSACTIONS: {
RESTRICT: 'corporate',
Expand Down
1 change: 1 addition & 0 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3227,6 +3227,7 @@ const translations = {
},
amexCorporate: 'Select this if the front of your cards say “Corporate”',
amexBusiness: 'Select this if the front of your cards say “Business”',
amexPersonal: 'Select this if your cards are personal',
error: {
pleaseSelectProvider: 'Please select a card provider before continuing.',
pleaseSelectBankAccount: 'Please select a bank account before continuing.',
Expand Down
1 change: 1 addition & 0 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3268,6 +3268,7 @@ const translations = {
},
amexCorporate: 'Seleccione esto si el frente de sus tarjetas dice “Corporativa”',
amexBusiness: 'Seleccione esta opción si el frente de sus tarjetas dice “Negocios”',
amexPersonal: 'Selecciona esta opción si tus tarjetas son personales',
error: {
pleaseSelectProvider: 'Seleccione un proveedor de tarjetas antes de continuar.',
pleaseSelectBankAccount: 'Seleccione una cuenta bancaria antes de continuar.',
Expand Down
7 changes: 7 additions & 0 deletions src/pages/workspace/companyCards/addNew/AmexCustomFeed.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,13 @@ function AmexCustomFeed() {
keyForList: CONST.COMPANY_CARDS.AMEX_CUSTOM_FEED.BUSINESS,
isSelected: typeSelected === CONST.COMPANY_CARDS.AMEX_CUSTOM_FEED.BUSINESS,
},
{
value: CONST.COMPANY_CARDS.AMEX_CUSTOM_FEED.PERSONAL,
text: CONST.COMPANY_CARDS.AMEX_CUSTOM_FEED.PERSONAL,
alternateText: translate('workspace.companyCards.addNewCard.amexPersonal'),
Comment on lines +62 to +65
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mountiny is PERSONAL card already supported with the API on the BE

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The personal should be the same as the business from BE perspective #52798

image

:nobodyreads:

Copy link
Contributor

@allgandalf allgandalf Nov 21, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

glad GH doesn't have the conversion for :nobodyreads: :trollface: , thanks for checking in though! 🫂

keyForList: CONST.COMPANY_CARDS.AMEX_CUSTOM_FEED.PERSONAL,
isSelected: typeSelected === CONST.COMPANY_CARDS.AMEX_CUSTOM_FEED.PERSONAL,
},
];

return (
Expand Down
Loading