-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cursor autofocus set after changing the currency on request/split money screen #5267
Conversation
Thanks for the quick work @PrashantMangukiya. Next step is to await @pecanoro's review of the PR, and address any comments for adjustments/changes. |
Hi @PrashantMangukiya, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting. |
@pecanoro We can merge this pr as N6 hold removed now. |
@PrashantMangukiya Could you please merge with main and retest it? It's been a while so in order to avoid regressions. |
Merged main with prashant-5102
@pecanoro After merging main with this branch E2E test fails in this pr. I tested it locally and functionality works as expected. Do you have any idea why E2E test fails after merge with main? I have no idea why E2E fails. If this pull request cant pass E2E test then I think we can close this pr, I will create another branch from main and submit new pull request. What you are suggesting? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. don't worry about That test it's failing for some other reason.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀
|
@michaelhaxhiu pr is ready for review.
Details
On Request / Split money screen cursor autofocus was not regained after changing the currency. Now updated code to set cursor autofocus after changing the currency.
Fixed Issues
$ #5102
Tests and QA Steps
Tested On
Screenshots
Web
Web.mov
Mobile Web
MobileWeb.mov
Desktop
Desktop.mov
iOS
iOS.mov
Android
Android.mov