Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor autofocus set after changing the currency on request/split money screen #5267

Merged
merged 2 commits into from
Oct 20, 2021

Conversation

PrashantMangukiya
Copy link
Contributor

@michaelhaxhiu pr is ready for review.

Details

On Request / Split money screen cursor autofocus was not regained after changing the currency. Now updated code to set cursor autofocus after changing the currency.

Fixed Issues

$ #5102

Tests and QA Steps

  1. Launch the desktop app and login
  2. Click the + icon in LHN and choose either request or split money
  3. Click the currency and choose any other currency
  4. After selecting new currency now it will regained focus to amount field.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Web.mov

Mobile Web

MobileWeb.mov

Desktop

Desktop.mov

iOS

iOS.mov

Android

Android.mov

@PrashantMangukiya PrashantMangukiya requested a review from a team as a code owner September 15, 2021 16:27
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team September 15, 2021 16:27
@michaelhaxhiu
Copy link
Contributor

Thanks for the quick work @PrashantMangukiya. Next step is to await @pecanoro's review of the PR, and address any comments for adjustments/changes.

@kadiealexander
Copy link
Contributor

Hi @PrashantMangukiya, I've placed this issue on hold as per this update, as we are prioritising issues related to a feature release scheduled for 9/24. As an apology for the delay, we will add a $100 bonus as a thank you for waiting.

@PrashantMangukiya
Copy link
Contributor Author

@pecanoro We can merge this pr as N6 hold removed now.

@pecanoro
Copy link
Contributor

@PrashantMangukiya Could you please merge with main and retest it? It's been a while so in order to avoid regressions.

Merged main with prashant-5102
@PrashantMangukiya
Copy link
Contributor Author

@pecanoro After merging main with this branch E2E test fails in this pr. I tested it locally and functionality works as expected. Do you have any idea why E2E test fails after merge with main? I have no idea why E2E fails.

If this pull request cant pass E2E test then I think we can close this pr, I will create another branch from main and submit new pull request. What you are suggesting?

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. don't worry about That test it's failing for some other reason.

@pecanoro pecanoro merged commit f387857 into Expensify:main Oct 20, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @pecanoro in version: 1.1.8-10 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.10-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants