Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CP Staging]: fix crash on staging due to null assertion of reports #52547

Merged
merged 5 commits into from
Nov 14, 2024
Merged

[CP Staging]: fix crash on staging due to null assertion of reports #52547

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
82bed36
fix crash on staging due to report
allgandalf Nov 14, 2024
ffe5959
Update ReportUtils.ts
allgandalf Nov 14, 2024
57ca874
remove extra space
allgandalf Nov 14, 2024
d2b78c5
Merge branch 'Expensify:main' into patch-12
allgandalf Nov 14, 2024
8a3352c
Merge branch 'main' into patch-12
iwiznia Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/ReportUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6351,7 +6351,7 @@ function shouldDisplayViolationsRBRInLHN(report: OnyxEntry<Report>, transactionV
// - Belong to the same workspace
// And if any have a violation, then it should have a RBR
const allReports = Object.values(ReportConnection.getAllReports() ?? {}) as Report[];
const potentialReports = allReports.filter((r) => r.ownerAccountID === currentUserAccountID && (r.stateNum ?? 0) <= 1 && r.policyID === report.policyID);
const potentialReports = allReports.filter((r) => r?.ownerAccountID === currentUserAccountID && (r?.stateNum ?? 0) <= 1 && r?.policyID === report.policyID);
return potentialReports.some(
(potentialReport) => hasViolations(potentialReport.reportID, transactionViolations) || hasWarningTypeViolations(potentialReport.reportID, transactionViolations),
);
Expand Down
Loading