Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update en.ts #52218

Merged
merged 11 commits into from
Nov 8, 2024
Merged

Update en.ts #52218

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
8362644
Update en.ts
jamesdeanexpensify Nov 7, 2024
668189f
Update es.ts
jamesdeanexpensify Nov 7, 2024
e706224
Update en.ts
jamesdeanexpensify Nov 7, 2024
2f83cd7
Update es.ts
jamesdeanexpensify Nov 7, 2024
225d66d
Update en.ts
jamesdeanexpensify Nov 7, 2024
f302f1b
Update es.ts
jamesdeanexpensify Nov 7, 2024
b4a5a52
prettier to fix style
NikkiWines Nov 8, 2024
49f5f2d
use currentRole and newRole where applicable
NikkiWines Nov 8, 2024
848d8cf
Update en.ts
jamesdeanexpensify Nov 8, 2024
af0170f
Update ReportTypingIndicator.tsx
jamesdeanexpensify Nov 8, 2024
5a008be
Update es.ts
jamesdeanexpensify Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/languages/en.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,7 +707,7 @@ const translations = {
reportTypingIndicator: {
isTyping: 'is typing...',
areTyping: 'are typing...',
multipleUsers: 'Multiple users',
multipleUsers: 'Multiple members',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the variable implies that the string will be "multiple users" and not "multiple members," could we update the variable as well? Looks like we only use it here:

App/src/pages/home/report/ReportTypingIndicator.tsx

Line 51 in 45a19bf

{translate('reportTypingIndicator.multipleUsers')}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did that work?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so, but we also need to update the spanish translation file I think with the new key. Do we need a new translation too?

https://github.com/Expensify/App/blob/main/src/languages/es.ts#L704

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I updated there, too. I'm not sure where else I'm needed, but please let me know!

},
reportArchiveReasons: {
[CONST.REPORT.ARCHIVE_REASON.DEFAULT]: 'This chat room has been archived.',
Expand Down Expand Up @@ -1210,7 +1210,7 @@ const translations = {
deviceCredentials: 'Device credentials',
invalidate: 'Invalidate',
destroy: 'Destroy',
maskExportOnyxStateData: 'Mask fragile user data while exporting Onyx state',
maskExportOnyxStateData: 'Mask fragile member data while exporting Onyx state',
exportOnyxState: 'Export Onyx state',
importOnyxState: 'Import Onyx state',
testCrash: 'Test crash',
Expand Down Expand Up @@ -1643,7 +1643,7 @@ const translations = {
},
groupChat: {
lastMemberTitle: 'Heads up!',
lastMemberWarning: "Since you're the last person here, leaving will make this chat inaccessible to all users. Are you sure you want to leave?",
lastMemberWarning: "Since you're the last person here, leaving will make this chat inaccessible to all members. Are you sure you want to leave?",
defaultReportName: ({displayName}: ReportArchiveReasonsClosedParams) => `${displayName}'s group chat`,
},
languagePage: {
Expand Down Expand Up @@ -3596,7 +3596,7 @@ const translations = {
getTheExpensifyCardAndMore: 'Get the Expensify Card and more',
},
people: {
genericFailureMessage: 'An error occurred removing a user from the workspace, please try again.',
genericFailureMessage: 'An error occurred removing a member from the workspace, please try again.',
removeMembersPrompt: ({memberName}: {memberName: string}) => ({
one: `Are you sure you want to remove ${memberName}?`,
other: 'Are you sure you want to remove these members?',
Expand Down Expand Up @@ -4564,11 +4564,11 @@ const translations = {
selectedForRandomAudit: `randomly selected for review`,
selectedForRandomAuditMarkdown: `[randomly selected](https://help.expensify.com/articles/expensify-classic/reports/Set-a-random-report-audit-schedule) for review`,
share: ({to}: ShareParams) => `invited member ${to}`,
unshare: ({to}: UnshareParams) => `removed user ${to}`,
unshare: ({to}: UnshareParams) => `removed member ${to}`,
stripePaid: ({amount, currency}: StripePaidParams) => `paid ${currency}${amount}`,
takeControl: `took control`,
integrationSyncFailed: ({label, errorMessage}: IntegrationSyncFailedParams) => `failed to sync with ${label}${errorMessage ? ` ("${errorMessage}")` : ''}`,
addEmployee: ({email, role}: AddEmployeeParams) => `added ${email} as ${role === 'user' ? 'member' : 'admin'}`,
addEmployee: ({email, role}: AddEmployeeParams) => `added ${email} as ${role === 'member' || role === 'user' ? 'member' : 'admin'}`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) => `updated the role of ${email} from ${currentRole} to ${newRole}`,
removeMember: ({email, role}: AddEmployeeParams) => `removed ${role} ${email}`,
removedConnection: ({connectionName}: ConnectionNameParams) => `removed connection to ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
Expand Down Expand Up @@ -4618,7 +4618,7 @@ const translations = {
chatMessage: 'Chat message',
lastChatMessagePreview: 'Last chat message preview',
workspaceName: 'Workspace name',
chatUserDisplayNames: 'Chat user display names',
chatUserDisplayNames: 'Chat member display names',
scrollToNewestMessages: 'Scroll to newest messages',
prestyledText: 'Prestyled text',
viewAttachment: 'View attachment',
Expand Down Expand Up @@ -5217,7 +5217,7 @@ const translations = {
hasDraftComment: 'Has draft comment',
hasGBR: 'Has GBR',
hasRBR: 'Has RBR',
pinnedByUser: 'Pinned by user',
pinnedByUser: 'Pinned by member',
hasIOUViolations: 'Has IOU violations',
hasAddWorkspaceRoomErrors: 'Has add workspace room errors',
isUnread: 'Is unread (focus mode)',
Expand Down
16 changes: 9 additions & 7 deletions src/languages/es.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1208,7 +1208,7 @@ const translations = {
deviceCredentials: 'Credenciales del dispositivo',
invalidate: 'Invalidar',
destroy: 'Destruir',
maskExportOnyxStateData: 'Enmascare los datos frágiles del usuario mientras exporta el estado Onyx',
maskExportOnyxStateData: 'Enmascare los datos frágiles del miembro mientras exporta el estado Onyx',
exportOnyxState: 'Exportar estado Onyx',
importOnyxState: 'Importar estado Onyx',
testCrash: 'Prueba de fallo',
Expand Down Expand Up @@ -4612,14 +4612,16 @@ const translations = {
selectedForRandomAudit: `seleccionado al azar para revisión`,
selectedForRandomAuditMarkdown: `[seleccionado al azar](https://help.expensify.com/articles/expensify-classic/reports/Set-a-random-report-audit-schedule) para revisión`,
share: ({to}: ShareParams) => `miembro invitado ${to}`,
unshare: ({to}: UnshareParams) => `usuario eliminado ${to}`,
unshare: ({to}: UnshareParams) => `miembro eliminado ${to}`,
stripePaid: ({amount, currency}: StripePaidParams) => `pagado ${currency}${amount}`,
takeControl: `tomó el control`,
integrationSyncFailed: ({label, errorMessage}: IntegrationSyncFailedParams) => `no se pudo sincronizar con ${label}${errorMessage ? ` ("${errorMessage}")` : ''}`,
addEmployee: ({email, role}: AddEmployeeParams) => `agregó a ${email} como ${role === 'user' ? 'miembro' : 'administrador'}`,
addEmployee: ({email, role}: AddEmployeeParams) => `agregó a ${email} como ${role === 'miembro' || role === 'user' ? 'miembro' : 'administrador'}`,
updateRole: ({email, currentRole, newRole}: UpdateRoleParams) =>
`actualicé el rol ${email} de ${currentRole === 'user' ? 'miembro' : 'administrador'} a ${newRole === 'user' ? 'miembro' : 'administrador'}`,
removeMember: ({email, role}: AddEmployeeParams) => `eliminado ${role === 'user' ? 'miembro' : 'administrador'} ${email}`,
`actualicé el rol ${email} de ${currentRole === 'miembro' || currentRole === 'user' ? 'miembro' : 'administrador'} a ${
newRole === 'miembro' || newRole === 'user' ? 'miembro' : 'administrador'
}`,
removeMember: ({email, role}: AddEmployeeParams) => `eliminado ${role === 'miembro' || role === 'user' ? 'miembro' : 'administrador'} ${email}`,
removedConnection: ({connectionName}: ConnectionNameParams) => `eliminó la conexión a ${CONST.POLICY.CONNECTIONS.NAME_USER_FRIENDLY[connectionName]}`,
},
},
Expand Down Expand Up @@ -5127,7 +5129,7 @@ const translations = {
chatMessage: 'mensaje de chat',
lastChatMessagePreview: 'Vista previa del último mensaje del chat',
workspaceName: 'Nombre del espacio de trabajo',
chatUserDisplayNames: 'Nombres de los usuarios del chat',
chatUserDisplayNames: 'Nombres de los miembros del chat',
scrollToNewestMessages: 'Desplázate a los mensajes más recientes',
prestyledText: 'texto preestilizado',
viewAttachment: 'Ver archivo adjunto',
Expand Down Expand Up @@ -5732,7 +5734,7 @@ const translations = {
hasDraftComment: 'Tiene comentario en borrador',
hasGBR: 'Tiene GBR',
hasRBR: 'Tiene RBR',
pinnedByUser: 'Fijado por el usuario',
pinnedByUser: 'Fijado por el miembro',
hasIOUViolations: 'Tiene violaciones de IOU',
hasAddWorkspaceRoomErrors: 'Tiene errores al agregar sala de espacio de trabajo',
isUnread: 'No leído (modo de enfoque)',
Expand Down
Loading