Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix empty categories from briefly displaying when search begins #52009

27 changes: 15 additions & 12 deletions src/components/EmojiPicker/EmojiPickerMenu/index.native.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,8 @@ import type {ListRenderItem} from '@shopify/flash-list';
import lodashDebounce from 'lodash/debounce';
import React, {useCallback} from 'react';
import type {ForwardedRef} from 'react';
import {View} from 'react-native';
import {InteractionManager, View} from 'react-native';
import type {Emoji} from '@assets/emojis/types';
import EmojiPickerMenuItem from '@components/EmojiPicker/EmojiPickerMenuItem';
import Text from '@components/Text';
import TextInput from '@components/TextInput';
Expand Down Expand Up @@ -43,25 +44,27 @@ function EmojiPickerMenu({onEmojiSelected, activeEmoji}: EmojiPickerMenuProps, r
} = useEmojiPickerMenu();
const StyleUtils = useStyleUtils();

const updateEmojiList = (emojiData: EmojiUtils.EmojiPickerList | Emoji[], headerData: number[] = []) => {
InteractionManager.runAfterInteractions(() => {
requestAnimationFrame(() => {
emojiListRef.current?.scrollToOffset({offset: 0, animated: false});
});
});
setFilteredEmojis(emojiData);
setHeaderIndices(headerData);
};

/**
* Filter the entire list of emojis to only emojis that have the search term in their keywords
*/
const filterEmojis = lodashDebounce((searchTerm: string) => {
const [normalizedSearchTerm, newFilteredEmojiList] = suggestEmojis(searchTerm);

if (emojiListRef.current) {
emojiListRef.current.scrollToOffset({offset: 0, animated: false});
}

if (normalizedSearchTerm === '') {
setFilteredEmojis(allEmojis);
setHeaderIndices(headerRowIndices);

return;
updateEmojiList(allEmojis, headerRowIndices);
} else {
updateEmojiList(newFilteredEmojiList ?? [], []);
}

setFilteredEmojis(newFilteredEmojiList ?? []);
setHeaderIndices([]);
}, 300);

const scrollToHeader = (headerIndex: number) => {
Expand Down
Loading