Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NoQA] Fix UI issue for Empty states for Company cards #51780

Merged
merged 1 commit into from
Oct 31, 2024
+7 −7
Merged

[NoQA] Fix UI issue for Empty states for Company cards #51780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/pages/workspace/companyCards/WorkspaceCompanyCardsFeedAddedEmptyPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import EmptyStateComponent from '@components/EmptyStateComponent';
import * as Illustrations from '@components/Icon/Illustrations';
import TableListItemSkeleton from '@components/Skeletons/TableRowSkeleton';
import CardRowSkeleton from '@components/Skeletons/CardRowSkeleton';
import useLocalize from '@hooks/useLocalize';
import useThemeStyles from '@hooks/useThemeStyles';
import colors from '@styles/theme/colors';
Expand All @@ -13,10 +13,10 @@ function WorkspaceCompanyCardsFeedAddedEmptyPage() {

return (
<EmptyStateComponent
SkeletonComponent={TableListItemSkeleton}
SkeletonComponent={CardRowSkeleton}
headerMediaType={CONST.EMPTY_STATE_MEDIA.ILLUSTRATION}
headerMedia={Illustrations.CompanyCardsEmptyState}
containerStyles={styles.mt4}
containerStyles={styles.mt5}
headerStyles={[styles.emptyStateCardIllustrationContainer, styles.justifyContentStart, {backgroundColor: colors.blue700}]}
headerContentStyles={styles.emptyStateCardIllustration}
title={translate('workspace.moreFeatures.companyCards.emptyAddedFeedTitle')}
Expand Down
6 changes: 3 additions & 3 deletions src/pages/workspace/companyCards/WorkspaceCompanyCardsFeedPendingPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import EmptyStateComponent from '@components/EmptyStateComponent';
import * as Illustrations from '@components/Icon/Illustrations';
import TableListItemSkeleton from '@components/Skeletons/TableRowSkeleton';
import CardRowSkeleton from '@components/Skeletons/CardRowSkeleton';
import Text from '@components/Text';
import TextLink from '@components/TextLink';
import useLocalize from '@hooks/useLocalize';
Expand All @@ -23,8 +23,8 @@ function WorkspaceCompanyCardsFeedPendingPage() {

return (
<EmptyStateComponent
SkeletonComponent={TableListItemSkeleton}
containerStyles={styles.mt4}
SkeletonComponent={CardRowSkeleton}
containerStyles={styles.mt5}
headerMediaType={CONST.EMPTY_STATE_MEDIA.ILLUSTRATION}
headerMedia={Illustrations.CompanyCardsPendingState}
headerStyles={[styles.emptyStateCardIllustrationContainer, {backgroundColor: colors.ice800}]}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/workspace/companyCards/WorkspaceCompanyCardsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ function WorkspaceCompanyCardPage({route}: WorkspaceCompanyCardPageProps) {
)}
{!isLoading && (
<WorkspacePageWithSections
shouldUseScrollView={!isFeedAdded}
shouldUseScrollView={isNoFeed}
icon={Illustrations.CompanyCard}
headerText={translate('workspace.common.companyCards')}
route={route}
Expand Down
Loading