Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editing a task, navigate app to other report #51381

Merged
merged 4 commits into from
Dec 4, 2024
Merged

Fix editing a task, navigate app to other report #51381

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08ff8aa
Fix editing a task, navigate app to other report
tsa321 Oct 24, 2024
5f4c4db
Merge branch 'main' into fixEditTaskNav
tsa321 Nov 5, 2024
35238fb
revert some changes
tsa321 Nov 21, 2024
7b3630a
remove comments
tsa321 Nov 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/libs/actions/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,7 +425,6 @@ function completeTask(taskReport: OnyxEntry<OnyxTypes.Report>) {

playSound(SOUNDS.SUCCESS);
API.write(WRITE_COMMANDS.COMPLETE_TASK, parameters, {optimisticData, successData, failureData});
Report.notifyNewAction(taskReportID, currentUserAccountID);
}

/**
Expand Down Expand Up @@ -509,7 +508,6 @@ function reopenTask(taskReport: OnyxEntry<OnyxTypes.Report>) {
};

API.write(WRITE_COMMANDS.REOPEN_TASK, parameters, {optimisticData, successData, failureData});
Report.notifyNewAction(taskReportID, currentUserAccountID);
}

function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task) {
Expand Down Expand Up @@ -586,7 +584,6 @@ function editTask(report: OnyxTypes.Report, {title, description}: OnyxTypes.Task
};

API.write(WRITE_COMMANDS.EDIT_TASK, parameters, {optimisticData, successData, failureData});
Report.notifyNewAction(report.reportID, currentUserAccountID);
}

function editTaskAssignee(report: OnyxTypes.Report, sessionAccountID: number, assigneeEmail: string, assigneeAccountID: number | null = 0, assigneeChatReport?: OnyxEntry<OnyxTypes.Report>) {
Expand Down Expand Up @@ -725,7 +722,6 @@ function editTaskAssignee(report: OnyxTypes.Report, sessionAccountID: number, as
};

API.write(WRITE_COMMANDS.EDIT_TASK_ASSIGNEE, parameters, {optimisticData, successData, failureData});
Report.notifyNewAction(report.reportID, currentUserAccountID);
}

/**
Expand Down
Loading