Use SetPersonalDetailsAndShipExpensifyCards #50660

mountiny · 2024-10-11T16:05:01Z

Details

Use a new command that can ship multiple cards at once.

Fixed Issues

$ #49388
PROPOSAL:

Tests

Create new collect workspace in NewDot
Enable Expensify cards on it
Add a testing VBBA so you can provision the policy for expensify cards
Invite new member Alice to the policy
Sign into account of Alice
As admin, issue Alice 3 physical cards
Verify Alice got 3 messages in their workspace chat
Click on the button to add personal details in order to ship the card
Submit
Verify that the API request has been successful
Go to Wallet
Verify the physical cards are there and in not activated state (by inspecting the cardList onyx key and state property to be 4

Screen.Recording.2024-10-15.at.13.06.50.mp4

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Tested on web and video is above, this is purely api change so only tested on one platform as it should be same on others too

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2024-10-11T16:05:06Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2024-10-21T07:38:27Z

This is still on hold as the web pr is only in staging, but I think @allgandalf or @DylanDylann can start the review with staging api

DylanDylann · 2024-10-21T08:06:14Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-10-21.at.18.05.25.mov

Android: mWeb Chrome

Screen.Recording.2024-10-21.at.17.57.34.mov

iOS: Native

Screen.Recording.2024-10-21.at.18.00.12.mov

iOS: mWeb Safari

Screen.Recording.2024-10-21.at.17.53.36.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

Screen.Recording.2024-10-21.at.17.49.37.mov

DylanDylann · 2024-10-21T09:41:32Z

@mountiny The BE doesn't return the phone number

newclip.mov

DylanDylann · 2024-10-21T10:18:09Z

@mountiny I just discovered a new bug, when admin assigns a physical card to a member who haven't added shipping details. On the member account the message require adding shipping detail

But on the admin account, It said that the member already added shipping detail

Video:

Screen.Recording.2024-10-21.at.17.08.54.mov

mountiny · 2024-10-21T10:23:57Z

But on the admin account, It said that the member already added shipping detail

Yeah that is a bug but that is not from this PR, I think we need to just raise it in Slack please

mountiny · 2024-10-21T10:25:31Z

The BE doesn't return the phone number

I see that might be generic issue with how the phone number is added to the details, is it needed for something specific in the response? I feel like its not a blocker but we need to look into it for sure

mountiny · 2024-10-21T10:35:44Z

Created a follow up for the phoneNumber not being returned #51170

DylanDylann · 2024-10-21T10:38:16Z

Completing the checklist

melvin-bot · 2024-10-21T11:08:30Z

@MarioExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2024-10-21T11:22:36Z

Discover two new bugs. The rest looks good
https://expensify.slack.com/archives/C049HHMV9SM/p1729509011578409
https://expensify.slack.com/archives/C049HHMV9SM/p1729509335851319

mountiny · 2024-10-22T02:51:02Z

@MariaHCD @madmax330 this is ready for your review, c+ approved

mountiny · 2024-10-22T09:49:10Z

Ship town

OSBotify · 2024-10-22T10:01:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-23T16:43:39Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-23T17:45:07Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-25T02:17:02Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-25T07:48:06Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny added 2 commits October 11, 2024 12:18

Use the new API command to ship all physical expensify cards

51f403c

Update the card shipment flow to not required cardID

d8bc9db

mountiny self-assigned this Oct 11, 2024

mountiny requested a review from a team as a code owner October 11, 2024 16:05

melvin-bot bot requested review from Pujan92 and removed request for a team October 11, 2024 16:05

Merge branch 'main' into vit-useNewCommandForShippingCards

9d97a89

mountiny requested review from madmax330, MariaHCD, allgandalf and DylanDylann and removed request for Pujan92 October 15, 2024 04:15

MariaHCD previously approved these changes Oct 15, 2024

View reviewed changes

Merge main to resolve merge conflicts

58702e7

mountiny dismissed MariaHCD’s stale review via 58702e7 October 21, 2024 07:36

mountiny mentioned this pull request Oct 21, 2024

Ensure phoneNumber is returned in the personalDetails #51170

Closed

DylanDylann approved these changes Oct 21, 2024

View reviewed changes

melvin-bot bot requested a review from MarioExpensify October 21, 2024 11:08

mountiny changed the title ~~[HOLD web PR] Use SetPersonalDetailsAndShipExpensifyCards~~ Use SetPersonalDetailsAndShipExpensifyCards Oct 22, 2024

MariaHCD approved these changes Oct 22, 2024

View reviewed changes

mountiny merged commit eba273e into main Oct 22, 2024
20 checks passed

mountiny deleted the vit-useNewCommandForShippingCards branch October 22, 2024 09:49

github-actions bot mentioned this pull request Oct 23, 2024

Deploy Checklist: New Expensify 2024-10-23 #51344

Closed

42 tasks

This was referenced Oct 24, 2024

[PAID] [$100] Expensify Card - "issued" starts with a lowercase i on shipping address message #51386

Closed

Expensify Card - Shipping details message on workspace chat doesn't appear dynamically #51387

Closed

IuliiaHerets mentioned this pull request Oct 24, 2024

[HOLD for payment 2024-12-16] [$250] Web - Expensify card - Error when wrong 4 digit is used persists for a few sec after a refresh #51396

Closed

8 tasks

lanitochka17 mentioned this pull request Oct 24, 2024

Expensify Card - RHP resets to previous steps and shows "Get physical card" after a refresh #51430

Closed

8 tasks

melvin-bot bot mentioned this pull request Oct 25, 2024

[HOLD for payment 2024-11-01] [Workspace Feeds] Create SetPersonalDetailsAndShipExpensifyCards command #49388

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use SetPersonalDetailsAndShipExpensifyCards #50660

Use SetPersonalDetailsAndShipExpensifyCards #50660

mountiny commented Oct 11, 2024 •

edited

Loading

melvin-bot bot commented Oct 11, 2024

mountiny commented Oct 21, 2024

DylanDylann commented Oct 21, 2024 •

edited

Loading

DylanDylann commented Oct 21, 2024 •

edited

Loading

DylanDylann commented Oct 21, 2024

mountiny commented Oct 21, 2024

mountiny commented Oct 21, 2024

mountiny commented Oct 21, 2024

DylanDylann commented Oct 21, 2024

melvin-bot bot commented Oct 21, 2024

DylanDylann commented Oct 21, 2024

mountiny commented Oct 22, 2024

mountiny commented Oct 22, 2024

OSBotify commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 25, 2024

github-actions bot commented Oct 25, 2024

Use SetPersonalDetailsAndShipExpensifyCards #50660

Use SetPersonalDetailsAndShipExpensifyCards #50660

Conversation

mountiny commented Oct 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 11, 2024

mountiny commented Oct 21, 2024

DylanDylann commented Oct 21, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

DylanDylann commented Oct 21, 2024 • edited Loading

DylanDylann commented Oct 21, 2024

mountiny commented Oct 21, 2024

mountiny commented Oct 21, 2024

mountiny commented Oct 21, 2024

DylanDylann commented Oct 21, 2024

melvin-bot bot commented Oct 21, 2024

DylanDylann commented Oct 21, 2024

mountiny commented Oct 22, 2024

mountiny commented Oct 22, 2024

OSBotify commented Oct 22, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 25, 2024

github-actions bot commented Oct 25, 2024

mountiny commented Oct 11, 2024 •

edited

Loading

DylanDylann commented Oct 21, 2024 •

edited

Loading

DylanDylann commented Oct 21, 2024 •

edited

Loading