fix: Amount shows 0.00 in invoice report and LHN #50620

nkdengineer · 2024-10-11T04:15:39Z

Details

Fixed Issues

$ #50236
PROPOSAL: #50236 (comment)

Tests

Go to FAB > Send invoices.
Send an invoice in currency that matches the workspace default currency.
Go to invoice report.
Click Amount.
Change the currency to another currency and save it.
Verify that: Invoice report will display the correct amount in workspace default currency.

Verify that no errors appear in the JS console

Offline tests

same as above

QA Steps

same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-resize.mp4

Android: mWeb Chrome

android-mweb-resize.mp4

iOS: Native

ios-resize.mp4

iOS: mWeb Safari

ios-mweb-resize.mp4

MacOS: Chrome / Safari

web-resize.mp4

MacOS: Desktop

desktop-resize.mp4

melvin-bot · 2024-10-11T09:40:34Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2024-10-13T15:08:14Z

The currency is being updated correctly in the header, €123 should be $134.60 but it's just updating to $123

Screen.Recording.2024-10-13.at.18.06.54.mov

nkdengineer · 2024-10-14T10:05:33Z

@Ollyws, we need to wait for BE to update the expense report's total.

Ollyws · 2024-10-15T06:45:22Z

For me the backend is returning the data but it's not updating, but perhaps this is out of scope for this issue let me investigate further.

Ollyws · 2024-10-16T09:48:51Z

@nkdengineer The value updates fine when we change the amount when it's the current workspace currency, but only updates after a page refresh if we change the currency or subsequently the amount:

Screen.Recording.2024-10-16.at.12.42.17.mov

nkdengineer · 2024-10-16T10:18:33Z

@Ollyws For me, the amount is updated after the update API is complete. When we update the amount with the WS currency, it's updated immediately because the total of the expense is updated in optimistic data. In our case, we need BE to return the convert amount.

Screen.Recording.2024-10-16.at.17.14.24.mov

Besides, did BE return the updated total for you like this video?

Screen.Recording.2024-10-16.at.17.17.46.mov

Ollyws · 2024-10-17T09:13:55Z

Besides, did BE return the updated total for you like this video?

@nkdengineer Yes but the BE seems to be returning the value in the chosen currency, not the workspace currency:

Screen.Recording.2024-10-17.at.12.08.02.mov

nkdengineer · 2024-10-17T09:34:51Z

did BE return the updated total for you like this video?

@Ollyws The total I mean here the total of the expense report which is the reportID you opened in the video above. Because the amount in header is based on the total of the expense report.

Also I don't see BE returns the update data of the expense report for you in this case.

Ollyws · 2024-10-17T17:25:35Z

@nkdengineer Ah yes sorry for the confusion, the backend doesn't seem to be returning the total for the report after changing the currency...but I wonder why it seems to be working for you.

nkdengineer · 2024-10-17T17:30:05Z

@Ollyws Sometimes I face the same problem, it may be a BE problem and we can ignore.

Ollyws · 2024-10-18T09:09:54Z

@nkdengineer Can you confirm that you actually get an updated total from the backend? I can't find any instance in which the backend returns a new total after changing the currency, on staging or prod.

nkdengineer · 2024-10-18T09:15:11Z

can't find any instance in which the backend returns a new total after changing the currency.

@Ollyws It's updated with the normal submit expense and for send invoice I also face the same problem.

Ollyws · 2024-10-18T09:21:50Z

Ah I see so what solution do you suggest here?

nkdengineer · 2024-10-18T09:25:17Z

Ah I see so what solution do you suggest here?

@Ollyws How can we suggestion the solution here since it's the BE bug? For this case the total will be updated after we refresh the page.

Ollyws · 2024-10-18T09:37:29Z

Ok I suppose we're good to proceed but this should really be fixed on the backend too.

Ollyws · 2024-10-21T07:58:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

@arosiclair
The backend is not returning the updated total and currency for the report in the response to the UpdateMoneyRequestAmountAndCurrency, it’s only updated in OpenApp when we refresh the page.
So currently this won’t actually update the total and we will need some changes on the backend to get it working.

arosiclair · 2024-10-21T13:47:34Z

@arosiclair The backend is not returning the updated total and currency for the report in the response to the UpdateMoneyRequestAmountAndCurrency, it’s only updated in OpenApp when we refresh the page. So currently this won’t actually update the total and we will need some changes on the backend to get it working.

Sounds like a legit bug. Can you report it in #expensify-bugs?

Ollyws · 2024-10-23T10:45:50Z

@arosiclair Sure, will do.

melvin-bot · 2024-10-23T13:13:56Z

@arosiclair looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

OSBotify · 2024-10-23T13:24:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2024-10-23T16:43:33Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-23T17:45:01Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 9.0.53-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-25T02:16:56Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

github-actions · 2024-10-25T07:48:00Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.0.53-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	failure ❌
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix: Amount shows 0.00 in invoice report and LHN

b73eafd

nkdengineer marked this pull request as ready for review October 11, 2024 09:40

nkdengineer requested a review from a team as a code owner October 11, 2024 09:40

melvin-bot bot requested review from Ollyws and removed request for a team October 11, 2024 09:40

Merge branch 'main' into fix/50236

90b6ac9

Merge branch 'main' into fix/50236

79b8b82

Ollyws approved these changes Oct 21, 2024

View reviewed changes

melvin-bot bot requested a review from arosiclair October 21, 2024 08:08

arosiclair approved these changes Oct 23, 2024

View reviewed changes

arosiclair merged commit d20c564 into Expensify:main Oct 23, 2024
17 checks passed

melvin-bot bot added the Emergency label Oct 23, 2024

arosiclair removed the Emergency label Oct 23, 2024

github-actions bot mentioned this pull request Oct 23, 2024

Deploy Checklist: New Expensify 2024-10-23 #51344

Closed

42 tasks

IuliiaHerets mentioned this pull request Oct 24, 2024

[Due for payment 2025-03-03] [$500] [Currency] Web - Invoice-Amount not updated in invoice details after changing currency until opening invoice again #51391

Open

8 tasks

melvin-bot bot mentioned this pull request Oct 25, 2024

[HOLD for payment 2024-11-01] [$250] Invoices - Amount shows 0.00 in invoice report and LHN after changing currency #50236

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Amount shows 0.00 in invoice report and LHN #50620

fix: Amount shows 0.00 in invoice report and LHN #50620

nkdengineer commented Oct 11, 2024 •

edited

Loading

melvin-bot bot commented Oct 11, 2024

Ollyws commented Oct 13, 2024

nkdengineer commented Oct 14, 2024

Ollyws commented Oct 15, 2024 •

edited

Loading

Ollyws commented Oct 16, 2024

nkdengineer commented Oct 16, 2024

Ollyws commented Oct 17, 2024 •

edited

Loading

nkdengineer commented Oct 17, 2024

Ollyws commented Oct 17, 2024

nkdengineer commented Oct 17, 2024

Ollyws commented Oct 18, 2024 •

edited

Loading

nkdengineer commented Oct 18, 2024 •

edited

Loading

Ollyws commented Oct 18, 2024

nkdengineer commented Oct 18, 2024

Ollyws commented Oct 18, 2024

Ollyws commented Oct 21, 2024

Ollyws left a comment

arosiclair commented Oct 21, 2024

Ollyws commented Oct 23, 2024

melvin-bot bot commented Oct 23, 2024

OSBotify commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 25, 2024

github-actions bot commented Oct 25, 2024

fix: Amount shows 0.00 in invoice report and LHN #50620

fix: Amount shows 0.00 in invoice report and LHN #50620

Conversation

nkdengineer commented Oct 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 11, 2024

Ollyws commented Oct 13, 2024

nkdengineer commented Oct 14, 2024

Ollyws commented Oct 15, 2024 • edited Loading

Ollyws commented Oct 16, 2024

nkdengineer commented Oct 16, 2024

Ollyws commented Oct 17, 2024 • edited Loading

nkdengineer commented Oct 17, 2024

Ollyws commented Oct 17, 2024

nkdengineer commented Oct 17, 2024

Ollyws commented Oct 18, 2024 • edited Loading

nkdengineer commented Oct 18, 2024 • edited Loading

Ollyws commented Oct 18, 2024

nkdengineer commented Oct 18, 2024

Ollyws commented Oct 18, 2024

Ollyws commented Oct 21, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment

Choose a reason for hiding this comment

arosiclair commented Oct 21, 2024

Ollyws commented Oct 23, 2024

melvin-bot bot commented Oct 23, 2024

OSBotify commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 23, 2024

github-actions bot commented Oct 25, 2024

github-actions bot commented Oct 25, 2024

nkdengineer commented Oct 11, 2024 •

edited

Loading

Ollyws commented Oct 15, 2024 •

edited

Loading

Ollyws commented Oct 17, 2024 •

edited

Loading

Ollyws commented Oct 18, 2024 •

edited

Loading

nkdengineer commented Oct 18, 2024 •

edited

Loading