Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Revert "Fix padding for edit composer suggestions" #50380

Merged
merged 1 commit into from
Oct 8, 2024
Merged

[CP Staging] Revert "Fix padding for edit composer suggestions" #50380

merged 1 commit into from
Oct 8, 2024

Conversation

lakchote
Copy link
Contributor

@lakchote lakchote commented Oct 8, 2024 •
edited
Loading

Reverts #41071 (see this discussion)

Will fix blocker #50373

@lakchote lakchote self-assigned this Oct 8, 2024
@lakchote lakchote requested a review from a team as a code owner October 8, 2024 09:08
@melvin-bot melvin-bot bot requested a review from stitesExpensify October 8, 2024 09:08
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 8, 2024

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team October 8, 2024 09:08
@lakchote lakchote merged commit ab2c314 into main Oct 8, 2024
14 of 17 checks passed
@lakchote lakchote deleted the revert-41071-fix/34442 branch October 8, 2024 09:43
@melvin-bot melvin-bot bot added the Emergency label Oct 8, 2024
@melvin-bot Melvin Bot
Copy link

melvin-bot bot commented Oct 8, 2024

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@lakchote
Copy link
Contributor Author

lakchote commented Oct 8, 2024

Since it's just a revert PR, no author nor reviewer checklists are needed. Removing the emergency label.

@lakchote lakchote removed the Emergency label Oct 8, 2024
OSBotify pushed a commit that referenced this pull request Oct 8, 2024
@lakchote @OSBotify
Merge pull request #50380 from Expensify/revert-41071-fix/34442
12babbe 
[CP Staging] Revert "Fix padding for edit composer suggestions"

(cherry picked from commit ab2c314)

(CP triggered by mountiny)
@github-actions github-actions bot added the CP Staging marks PRs that have been CP'd to staging label Oct 8, 2024
@OSBotify
Copy link
Contributor

OSBotify commented Oct 8, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Closed
50 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 8, 2024

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.0.46-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 9, 2024

🚀 Deployed to production by https://github.com/thienlnam in version: 9.0.46-5 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertjchen robertjchen robertjchen approved these changes

@stitesExpensify stitesExpensify Awaiting requested review from stitesExpensify

Assignees

@lakchote lakchote

Labels
CP Staging marks PRs that have been CP'd to staging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lakchote @OSBotify @robertjchen