Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating the NewHelp site with a default Jekyll installation #49628
Creating the NewHelp site with a default Jekyll installation #49628
Changes from 12 commits
f87cbac
bf2b7f9
288ccae
903aedf
2b4f0d2
808d5a9
a452a8e
304fdb5
c208034
216ded6
aeadd2a
0cfd840
ee36a05
d65098e
ce36bfb
6393350
29656b5
f71e207
d158e6d
843e099
689b355
a2598c4
93385fc
ec8e29e
99beb83
4c45ce3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove
fetch-depth: 0
. We really only need the snapshot of the repo with the latest commit to run a build, not the full history of all branches and tags. Removing this will save us more than a minute on each workflow run.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bump on this change. It makes the workflow much faster and is documented as a best practice here: https://github.com/Expensify/App/blob/44d09e58e73e937ad60e1c26107bfc022f5e4674/.github/workflows/README.md#fast-fetch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can simplify things and make them a bit more efficient by letting
ruby/setup-ruby
run the bundle install for us:Add a
.ruby-version
file tohelp/
(or symlink the one at the repo root tohelp/.ruby-version
, not 100% sure if this action will follow symlinks)Then adjust the
setup-ruby
step like so:Remove the
Install dependencies
stepThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAB but generally it's a best practice to just use the
github.token
unless you have a reason it needs to beOSBotify
. The built-in token has higher rate limitsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why so many platforms here ... none of our other
Gemfile.locks
have so many platforms. Not sure if it matters though 🤷🏼