Create Attendees item row for editing requests #48870

SzymczakJ · 2024-09-10T09:17:53Z

Details

This Pr adds option to edit attendees n a money request. Keep in mind that request for editing and requesting money with attendees is not working yet, but with onyx optimistic data everything should be easy to test.

Fixed Issues

$ #47173 (comment)
PROPOSAL:

Tests

Create workspace with control plan.
Submit expense to this workspace and try adding attendees.
On created request try modifying attendees, verify that proper report action message is added under the request.
Submit expense that exceeds amount limit by small factor(amount limit is typically $2000) and keep only one attendee.
Add one attendee to this request and check, if violation "over limit" disappears.

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

androidweb.mov

iOS: Native

ios.mov

iOS: mWeb Safari

iosweb.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

zfurtak

Great! Just fix this one typescript error and we're good to go with this PR 😃

zfurtak · 2024-09-12T08:50:30Z

src/pages/iou/request/step/IOURequestStepAttendees.tsx

-type IOURequestStepAttendeesProps = IOURequestStepAttendeesOnyxProps & WithWritableReportOrNotFoundProps<typeof SCREENS.MONEY_REQUEST.STEP_ATTENDEES>;
+type IOURequestStepAttendeesProps = IOURequestStepAttendeesOnyxProps &
+    WithWritableReportOrNotFoundProps<typeof SCREENS.MONEY_REQUEST.STEP_ATTENDEES> &
+    WithFullTransactionOrNotFoundProps<typeof SCREENS.MONEY_REQUEST.STEP_ATTENDEES>;


I think in the end this is not needed 😅

zfurtak · 2024-09-12T08:51:36Z

src/pages/iou/request/step/withFullTransactionOrNotFound.tsx

@@ -22,6 +22,7 @@ type MoneyRequestRouteName =
    | typeof SCREENS.MONEY_REQUEST.CREATE
    | typeof SCREENS.MONEY_REQUEST.STEP_DISTANCE
    | typeof SCREENS.MONEY_REQUEST.STEP_AMOUNT
+    | typeof SCREENS.MONEY_REQUEST.STEP_ATTENDEES


So here also, it's not needed

zfurtak

LGTM 🚀

melvin-bot · 2024-09-12T14:11:27Z

@allgandalf Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

SzymczakJ · 2024-09-13T12:25:47Z

@ZhenjaHorbach since you have full context in attendees feature and @allgandalf is probably not around, would you like to be C+ for this issue? 🙏

ZhenjaHorbach · 2024-09-13T12:26:44Z

@ZhenjaHorbach since you have full context in attendees feature and @allgandalf is probably not around, would you like to be C+ for this issue? 🙏

Sure !

ZhenjaHorbach · 2024-09-13T12:27:20Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

android-web.mov

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

allgandalf · 2024-09-13T12:27:23Z

Hey i am around, I will work on this PR today

allgandalf · 2024-09-13T12:28:48Z

@ZhenjaHorbach, It’s alright I can work on this PR today 😄

ZhenjaHorbach · 2024-09-13T12:31:22Z

I think its part of this discussion because it is the same project !
CC: Julesssss

https://expensify.slack.com/archives/C02NK2DQWUX/p1725534128533069

allgandalf · 2024-09-13T12:32:13Z

Ohh is it? can you please confirm about that

ZhenjaHorbach · 2024-09-13T12:46:21Z

Ohh is it? can you please confirm about that

This is just my opinion 😅
And I am not against any decision !
I am just not sure that this is such a big project that it needs several reviewers
But the decision in any case will depend on the internal engineer !

SzymczakJ · 2024-09-13T13:11:27Z

Whoops, sorry for the confusion 😅

Julesssss · 2024-09-16T08:51:57Z

@allgandalf ah yes, sorry I didn't notice the auto-assignment here.

Julesssss · 2024-09-16T08:52:37Z

@ZhenjaHorbach please continue and let me know when the checklist is looking good 👍

ZhenjaHorbach · 2024-09-16T08:55:11Z

@ZhenjaHorbach please continue and let me know when the checklist is looking good 👍

No problem
I'll start testing soon !

ZhenjaHorbach · 2024-09-16T09:21:04Z

src/libs/Violations/ViolationsUtils.ts

+
+    // We have to use regex, because Violation limit is given in a inconvenient form: "$2,000.00"
+    getViolationAmountLimit(violation: TransactionViolation): number {
+        return Number(violation.data?.formattedLimit?.replace(/[^0-9]+/g, ''));


/[^0-9]+/g
We use this regex in several places
Let's create constant for this !

src/libs/TransactionUtils/index.ts

ZhenjaHorbach · 2024-09-16T09:32:47Z

src/components/MoneyRequestConfirmationListFooter.tsx

@@ -233,7 +233,10 @@ function MoneyRequestConfirmationListFooter({

    const shouldShowTags = useMemo(() => isPolicyExpenseChat && OptionsListUtils.hasEnabledTags(policyTagLists), [isPolicyExpenseChat, policyTagLists]);
    const isMultilevelTags = useMemo(() => PolicyUtils.isMultiLevelTags(policyTags), [policyTags]);
-    const shouldShowAttendees = useMemo(() => !!policy?.id && (policy?.type === CONST.POLICY.TYPE.CORPORATE || policy?.type === CONST.POLICY.TYPE.TEAM), [policy?.id, policy?.type]);
+    const shouldShowAttendees = useMemo(
+        () => iouType === CONST.IOU.TYPE.SUBMIT && !!policy?.id && (policy?.type === CONST.POLICY.TYPE.CORPORATE || policy?.type === CONST.POLICY.TYPE.TEAM),


I think we can create a utility for shouldShowAttendees
Since this condition is used in several places

ZhenjaHorbach · 2024-09-16T09:33:59Z

But otherwise the changes look good !
And works well !
I found only a few issues, but they are related to the fact that we only use optimistic data !

ZhenjaHorbach · 2024-09-16T10:55:41Z

@SzymczakJ
Could you please check comments and update this branch to the last version of feature-attendeeTracking ?
And we will be ready to move on 😃

…o attendee-edit

zfurtak · 2024-09-16T12:25:28Z

@ZhenjaHorbach Kuba is a bit busy with other task so I updated the branch and adjusted to your comments 😉

ZhenjaHorbach · 2024-09-16T12:28:12Z

@ZhenjaHorbach Kuba is a bit busy with other task so I updated the branch and adjusted to your comments 😉

Thanks !
But I have one more small comment

src/libs/Violations/ViolationsUtils.ts

ZhenjaHorbach · 2024-09-16T13:04:19Z

LGTM !

zfurtak · 2024-09-16T13:06:50Z

@Julesssss could you take a look at this one?

github-actions · 2024-09-16T14:07:31Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/48870/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48870/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48870/NewExpensify.dmg	https://48870.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

zfurtak and others added 3 commits September 6, 2024 17:25

WIP

49456f0

Passed transaction to attendee edit screen

bb3a77c

add per attendee amount

430e8e5

SzymczakJ changed the base branch from main to feature-attendeeTracking September 10, 2024 09:24

SzymczakJ added 2 commits September 11, 2024 16:39

add reportAction message for change attendee

0e9ec1a

add violation recalculation

c1ea6c7

zfurtak reviewed Sep 12, 2024

View reviewed changes

SzymczakJ added 3 commits September 12, 2024 11:59

fix PR comments

91cbcb0

fix attendee edit bugs

1d8f66f

prettify code

38b0eca

zfurtak approved these changes Sep 12, 2024

View reviewed changes

delete console logs

23f6538

SzymczakJ marked this pull request as ready for review September 12, 2024 14:11

SzymczakJ requested a review from a team as a code owner September 12, 2024 14:11

melvin-bot bot requested a review from allgandalf September 12, 2024 14:11

melvin-bot bot removed the request for review from a team September 12, 2024 14:11

allgandalf mentioned this pull request Sep 13, 2024

[HOLD for payment 2024-11-05] [HIGH] [Attendee Tracking] Create Attendees item row for editing requests #47173

Closed

Julesssss added the Ready To Build label Sep 16, 2024

Julesssss requested review from ZhenjaHorbach and removed request for allgandalf September 16, 2024 08:53

This comment has been minimized.

Sign in to view

ZhenjaHorbach reviewed Sep 16, 2024

View reviewed changes

src/libs/TransactionUtils/index.ts Show resolved Hide resolved

ZhenjaHorbach reviewed Sep 16, 2024

View reviewed changes

zfurtak added 2 commits September 16, 2024 12:53

Merge remote-tracking branch 'expensify/feature-attendeeTracking' int…

0cde5dd

…o attendee-edit

Adjusted to review

2e4d632

ZhenjaHorbach reviewed Sep 16, 2024

View reviewed changes

src/libs/Violations/ViolationsUtils.ts Show resolved Hide resolved

Adjusted to comment

6bd365b

ZhenjaHorbach approved these changes Sep 16, 2024

View reviewed changes

melvin-bot bot requested a review from Julesssss September 16, 2024 13:04

Julesssss approved these changes Sep 16, 2024

View reviewed changes

Julesssss merged commit d17cada into Expensify:feature-attendeeTracking Sep 16, 2024
20 checks passed

This was referenced Oct 25, 2024

[Tracking] [External] Attendee Tracking project #44725

Open

[HOLD for payment] Attendee Tracking feature C+ reviews #51484

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create Attendees item row for editing requests #48870

Create Attendees item row for editing requests #48870

SzymczakJ commented Sep 10, 2024 •

edited

Loading

zfurtak left a comment

zfurtak Sep 12, 2024

zfurtak Sep 12, 2024

zfurtak left a comment

melvin-bot bot commented Sep 12, 2024

SzymczakJ commented Sep 13, 2024

ZhenjaHorbach commented Sep 13, 2024

ZhenjaHorbach commented Sep 13, 2024 •

edited

Loading

allgandalf commented Sep 13, 2024

allgandalf commented Sep 13, 2024

ZhenjaHorbach commented Sep 13, 2024 •

edited

Loading

allgandalf commented Sep 13, 2024

ZhenjaHorbach commented Sep 13, 2024

SzymczakJ commented Sep 13, 2024

Julesssss commented Sep 16, 2024

Julesssss commented Sep 16, 2024

ZhenjaHorbach commented Sep 16, 2024

This comment has been minimized.

ZhenjaHorbach Sep 16, 2024

ZhenjaHorbach Sep 16, 2024

ZhenjaHorbach commented Sep 16, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 16, 2024

zfurtak commented Sep 16, 2024

ZhenjaHorbach commented Sep 16, 2024

ZhenjaHorbach commented Sep 16, 2024

zfurtak commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

Create Attendees item row for editing requests #48870

Create Attendees item row for editing requests #48870

Conversation

SzymczakJ commented Sep 10, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

zfurtak left a comment

Choose a reason for hiding this comment

zfurtak Sep 12, 2024

Choose a reason for hiding this comment

zfurtak Sep 12, 2024

Choose a reason for hiding this comment

zfurtak left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 12, 2024

SzymczakJ commented Sep 13, 2024

ZhenjaHorbach commented Sep 13, 2024

ZhenjaHorbach commented Sep 13, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

allgandalf commented Sep 13, 2024

allgandalf commented Sep 13, 2024

ZhenjaHorbach commented Sep 13, 2024 • edited Loading

allgandalf commented Sep 13, 2024

ZhenjaHorbach commented Sep 13, 2024

SzymczakJ commented Sep 13, 2024

Julesssss commented Sep 16, 2024

Julesssss commented Sep 16, 2024

ZhenjaHorbach commented Sep 16, 2024

This comment has been minimized.

ZhenjaHorbach Sep 16, 2024

Choose a reason for hiding this comment

ZhenjaHorbach Sep 16, 2024

Choose a reason for hiding this comment

ZhenjaHorbach commented Sep 16, 2024 • edited Loading

ZhenjaHorbach commented Sep 16, 2024

zfurtak commented Sep 16, 2024

ZhenjaHorbach commented Sep 16, 2024

ZhenjaHorbach commented Sep 16, 2024

zfurtak commented Sep 16, 2024

github-actions bot commented Sep 16, 2024

SzymczakJ commented Sep 10, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 13, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 13, 2024 •

edited

Loading

ZhenjaHorbach commented Sep 16, 2024 •

edited

Loading