-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for REJECTED report action #48385
Changes from 6 commits
ea0f382
2d5a575
bd1a3f1
2f9f72e
d5d2e9e
15f3793
eedd172
b49d66f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -573,6 +573,7 @@ type OriginalMessageMap = { | |
/** */ | ||
[CONST.REPORT.ACTIONS.TYPE.MARKED_REIMBURSED]: never; | ||
/** */ | ||
/** */ | ||
[CONST.REPORT.ACTIONS.TYPE.MERGED_WITH_CASH_TRANSACTION]: never; | ||
/** */ | ||
[CONST.REPORT.ACTIONS.TYPE.MODIFIED_EXPENSE]: OriginalMessageModifiedExpense; | ||
|
@@ -595,6 +596,8 @@ type OriginalMessageMap = { | |
/** */ | ||
[CONST.REPORT.ACTIONS.TYPE.RENAMED]: OriginalMessageRenamed; | ||
/** */ | ||
[CONST.REPORT.ACTIONS.TYPE.REJECTED]: never; | ||
/** */ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do you know why do we have empty comments, feels weird There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no idea! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ok nice hack whoever did it 👍 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think I'll just disable the rule for the rest of that file |
||
[CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW]: OriginalMessageReportPreview; | ||
/** */ | ||
[CONST.REPORT.ACTIONS.TYPE.SELECTED_FOR_RANDOM_AUDIT]: never; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
action type is
REJECTEDTOSUBMITTER
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see my comment above.