chore: bump formatJS libraries #48067

hurali97 · 2024-08-27T10:25:05Z

Details

To benefit from the performance improvements available in formatJS, we can bump the libraries to the latest versions. This also fixes this issue.

Fixed Issues

$ #37657
$ #47988
PROPOSAL: #37657 (comment), #47988 (comment)

Tests

Verify that no errors appear in the JS console

Testing Steps:

Verify the general flow of the App doesn't break

Copied from the issue:

Open expensify web
Log in with your HT account
Navigate to your account settings
Select the Profile menu
Navigate to the Timezone menu
Disable automatic location detection
Select Timezone Asia/Almaty
Create a new conversation
Send a message to the conversation
Match the time to https://time.is/Almaty

Offline tests

QA Steps

Same as test steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2024-08-27.at.12.56.06.PM.mov

Android: mWeb Chrome

Screen.Recording.2024-08-27.at.1.36.54.PM.mov

iOS: Native

Screen.Recording.2024-08-27.at.1.32.45.PM.mov

iOS: mWeb Safari

Screen.Recording.2024-08-27.at.1.36.34.PM.mov

MacOS: Chrome / Safari

Screen.Recording.2024-08-27.at.1.43.38.PM.mov

MacOS: Desktop

Screen.Recording.2024-08-27.at.1.52.21.PM.mov

melvin-bot · 2024-08-27T13:05:55Z

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Ollyws · 2024-08-28T10:57:10Z

Reviewing today...

mountiny · 2024-08-28T11:19:53Z

@hurali97 Can you please add the test steps based on the issue this should also fix?

Ollyws · 2024-08-28T11:41:38Z

Getting this error on android:

github-actions · 2024-08-28T13:28:43Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪

Android 🤖	iOS 🍎
❌ FAILED ❌	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/48067/index.html
The QR code can't be generated, because the android build failed
Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/48067/NewExpensify.dmg	https://48067.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

hurali97 · 2024-08-29T08:51:59Z

Getting this error on android:

@Ollyws Can you add the repro steps for the error you're seeing? I tried using the android app and there was no crash.

Screen.Recording.2024-08-29.at.1.50.09.PM.mov

Ollyws · 2024-08-29T13:05:53Z

Strange, I can no longer reproduce. Must have been an issue with my setup. I'll do a little more testing and we should be good to go.

Ollyws · 2024-08-30T07:30:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

01_Android_Native.mp4

Android: mWeb Chrome

02_Android_Chrome.mp4

iOS: Native

03_iOS_Native.mp4

iOS: mWeb Safari

04_iOS_Safari.mp4

MacOS: Chrome / Safari

05_MacOS_Chrome.mp4

MacOS: Desktop

06_MacOS_Desktop.mp4

Ollyws

#37657 seems to persist on Android Native and Android Chrome, but aside from that LGTM.

hurali97 · 2024-08-30T12:15:29Z

#37657 seems to persist on Android Native and Android Chrome, but aside from that LGTM.

@Ollyws Thanks.

To re-iterate, this PR was originally intended to fix the performance issues by bumping formatjs libraries. Since, we were doing the bump anyway, @shubham1206agra suggested to include the linked issue as well.

If that issue is persisting on some platforms, we can keep that issue open and consider debugging it there, since it will be out of scope of this PR.

Let me know if you agree and we can move forward.

Ollyws · 2024-08-30T12:44:42Z

@hurali97 that's fine I don't think it's a huge issue.

mountiny

Thanks, I agree we can move ahead even if the issue was not fixed by the bump @shubham1206agra seems like this was not the golden shot

OSBotify · 2024-09-02T12:13:42Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-09-02T23:45:11Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.0.28-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-09-03T23:25:47Z

🚀 Deployed to production by https://github.com/roryabraham in version: 9.0.28-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

chore: bump formatjs libraries

a013646

hurali97 marked this pull request as ready for review August 27, 2024 13:05

hurali97 requested a review from a team as a code owner August 27, 2024 13:05

melvin-bot bot requested review from Ollyws and removed request for a team August 27, 2024 13:05

mountiny assigned hurali97 Aug 28, 2024

mountiny added the Ready To Build label Aug 28, 2024

Ollyws approved these changes Aug 30, 2024

View reviewed changes

melvin-bot bot requested a review from mountiny August 30, 2024 07:36

mountiny approved these changes Sep 2, 2024

View reviewed changes

mountiny merged commit 9051e00 into Expensify:main Sep 2, 2024
21 checks passed

github-actions bot mentioned this pull request Sep 2, 2024

Deploy Checklist: New Expensify 2024-09-02 #48438

Closed

46 tasks

Ollyws mentioned this pull request Sep 21, 2024

[HOLD for payment 2024-09-23] Performance Improvement: Update formatjs libraries and upstream/patch date-fns-tz #47988

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: bump formatJS libraries #48067

chore: bump formatJS libraries #48067

hurali97 commented Aug 27, 2024 •

edited by roryabraham

Loading

melvin-bot bot commented Aug 27, 2024

Ollyws commented Aug 28, 2024

mountiny commented Aug 28, 2024

Ollyws commented Aug 28, 2024 •

edited

Loading

github-actions bot commented Aug 28, 2024

hurali97 commented Aug 29, 2024

Ollyws commented Aug 29, 2024

Ollyws commented Aug 30, 2024

Ollyws left a comment •

edited

Loading

hurali97 commented Aug 30, 2024

Ollyws commented Aug 30, 2024

mountiny left a comment

OSBotify commented Sep 2, 2024

OSBotify commented Sep 2, 2024

OSBotify commented Sep 3, 2024

chore: bump formatJS libraries #48067

chore: bump formatJS libraries #48067

Conversation

hurali97 commented Aug 27, 2024 • edited by roryabraham Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 27, 2024

Ollyws commented Aug 28, 2024

mountiny commented Aug 28, 2024

Ollyws commented Aug 28, 2024 • edited Loading

github-actions bot commented Aug 28, 2024

hurali97 commented Aug 29, 2024

Ollyws commented Aug 29, 2024

Ollyws commented Aug 30, 2024

Reviewer Checklist

Screenshots/Videos

Ollyws left a comment • edited Loading

Choose a reason for hiding this comment

hurali97 commented Aug 30, 2024

Ollyws commented Aug 30, 2024

mountiny left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 2, 2024

OSBotify commented Sep 2, 2024

OSBotify commented Sep 3, 2024

hurali97 commented Aug 27, 2024 •

edited by roryabraham

Loading

Ollyws commented Aug 28, 2024 •

edited

Loading

Ollyws left a comment •

edited

Loading