Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use medium button by default #47238

Merged
merged 9 commits into from
Sep 12, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolve conflicts, update logic
  • Loading branch information
luacmartins committed Sep 6, 2024

Verified

This commit was signed with the committer’s verified signature.
kosmydel Jakub Kosmydel
commit 00ec2e89c9ff2eec91ebea1d6bbfc7e6281db859
2 changes: 1 addition & 1 deletion src/components/Button/index.tsx
Original file line number Diff line number Diff line change
@@ -187,7 +187,7 @@ function Button(

small = false,
large = false,
medium = true,
medium = !small && !large,

isLoading = false,
isDisabled = false,
Original file line number Diff line number Diff line change
@@ -267,7 +267,7 @@ function ReportFieldsListValuesPage({

return (
<Button
style={[isSmallScreenWidth && styles.flexGrow1, isSmallScreenWidth && styles.mb3]}
style={[shouldUseNarrowLayout && styles.flexGrow1, shouldUseNarrowLayout && styles.mb3]}
success
icon={Expensicons.Plus}
text={translate('workspace.reportFields.addValue')}
Loading
You are viewing a condensed version of this merge commit. You can view the full changes here.