Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Add missing GITHUB_TOKEN #46608

Merged
merged 3 commits into from
Jul 31, 2024
Merged

[No QA] Add missing GITHUB_TOKEN #46608

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eccfbf1
Add missing GITHUB_TOKEN
roryabraham Jul 31, 2024
75231ce
Update mocks
roryabraham Jul 31, 2024
d904eeb
Delete GITHUB_TOKEN from mock
roryabraham Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/actions/javascript/getReleaseBody/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: 'Get Release Body'
description: 'Generate the body of a production release'
inputs:
GITHUB_TOKEN:
description: Auth token for New Expensify Github
required: true
PR_LIST:
description: JSON array of pull request numbers (string)
required: true
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ jobs:
id: getReleaseBody
uses: ./.github/actions/javascript/getReleaseBody
with:
GITHUB_TOKEN: ${{ github.token }}
PR_LIST: ${{ steps.getReleasePRList.outputs.PR_LIST }}

- name: 🚀 Create release to trigger production deploy 🚀
Expand Down
2 changes: 1 addition & 1 deletion workflow_tests/mocks/deployMocks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const DEPLOY_PRODUCTION__RELEASE_PR_LIST__STEP_MOCK = createMockStep(
null,
{PR_LIST: '["1.2.1", "1.2.2"]'},
);
const DEPLOY_PRODUCTION__GENERATE_RELEASE_BODY__STEP_MOCK = createMockStep('Generate Release Body', 'Generating release body', 'DEPLOY_PRODUCTION', ['PR_LIST'], null, {
const DEPLOY_PRODUCTION__GENERATE_RELEASE_BODY__STEP_MOCK = createMockStep('Generate Release Body', 'Generating release body', 'DEPLOY_PRODUCTION', ['PR_LIST', 'GITHUB_TOKEN'], null, {
RELEASE_BODY: 'Release body',
});
const DEPLOY_PRODUCTION__CREATE_RELEASE__STEP_MOCK = createMockStep(
Expand Down
Loading